From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D525B335BAA for ; Mon, 18 Aug 2025 13:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525041; cv=none; b=Tk/9F3pY1V5R2Vm7bCUzQljp2if6nis1kKa5zxz5kKpbBn9cmZL/6VcvifwdEdwqAoJX9mKket89/Lz00hgbdjapuXZzx4X9tDfbT7ZHo6maj0mqX6qzWDWAGuzNaOkSIcuCeMq4Mif48ZFRrxF4hOf+gLUCbT+TNlo+fuhYJ6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525041; c=relaxed/simple; bh=7yHgSWeRbcyIHbjLHLnRwx4d4C71Zhhg/Zdke7nbkOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jdjfEHkJhRmTousA7gG7A4Ix74w1PbyEO2QEnlgG/DBhb4NqucZNzjfGaAvpDa5o/jfBBGatqntlNVlVxZKF03hLIfK4Vtm78DufCsPXm7bHZCTVHyGtusMFUO/2aPvUPtF2QVkMkHGd6wHU2wjsaENxpv8YkL7gXm17hXMNTxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aH7Emne3; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aH7Emne3" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3b9e4193083so3942300f8f.3 for ; Mon, 18 Aug 2025 06:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755525037; x=1756129837; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5DVVUnvtZO4/Z08Z1SdfbMyHejdi9PdhiDncUyyHKx0=; b=aH7Emne3U+UkgKJDzVJS7F6bcfdWp/nQxhcWitu9crpnm1ipo8o4CqXyUqL4aWNWXv Zp/xALcU11IRJLUdRKMynxrmQfpmc5snOYkiqz0gCKmnu9wIdzga7fZPMuwR6cxKmFT1 1L/NQHQLur5ltp6HPU3H+zXmpauLVEuCGq/6IkD/4o+53XoQDJ6P8IXuzgd/EJa9u5r8 6MWQ8Rs2VYPgPcCTP8D6NJOwmjaOneF0tY/11Fj/V976tAZYS+cLIlpw0RXgFz5X8TSF GTz5hNOoNG7Zmu4Lef4lWio1AN0T4AwubR3DGWoEGZ70D7ZkCke17vxvUeJ7QgmZ4NVm w1uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755525037; x=1756129837; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5DVVUnvtZO4/Z08Z1SdfbMyHejdi9PdhiDncUyyHKx0=; b=UFNmVsOk8JChGVhRLjdwPPsMNWBank6krhxUVD3i4XKEs6atztPl+Eq4HlmN3Q0mS6 tIzXQ1LTbO+nZo9786mvgHMVmjvmnYbJwBaTwiDWMTS+/A7twwnTQ8ps14L1hP2VKRu9 CxbRoTnQg1B4NnO7I+rvg4gbqMlk0Uphplai/AkSUr9fWuuSdqi+tx+u7DUl/o5H0xAT OL4CgNNmjBP0VB9hS8Efa+b3kKtpBcqHB9Sd/TCPAcja5ltFDbdkFx+JuYT1jilPrnOd oY1TW2fAFRYKKVfaNWyiZ6S9PVEUq14QHLfXlG/sF+z/3VGYH9Ao+wT2eJho1T6HtSrh ePIA== X-Forwarded-Encrypted: i=1; AJvYcCU+NJL9ruxwFGN57Vw5+H5eHmBB8mJ3AORodPNV0rx4QY+D54OLQshILtFBV1nfZXoLq+FAWhQmToFc@vger.kernel.org X-Gm-Message-State: AOJu0YyvUz2Vo92GA4ktjlEd+IT6ydxNgH+dnnAlPs6X1P+XHm73JGhH 543ahVw0Q4GANc14btnTqT8FN+qARFs9r+FcD8CZ8sWf4toaKayZi/g2Jp0k+zlHTCc= X-Gm-Gg: ASbGncs5Lc3y4e7tnCUlA0H2Ldt9TIpUueo4jx06YU4pkGQvL7qI7CSMP67FLHJRzsn bqbENy5KTmrHXnLJ6Ex8M9gxgWruVwPYO09xtZ51fLrlQnsRRp18BrOR5PjAN2E1hzxkiBoByxf +HcLCytF+SAJeYnasCR81S1Vn926S3TX2rtLT/y6p8ckgAL4tGryNVdiZHkVWAV2ukE1oeScyYG 9A8NUA6BfJwt4E/RrNXlbLgdAgIx6m9pXKK2VIVN5fYdkamD38+GuLCLEpIGfqbqilpgrRdQ8ef IX6n7C/hlvsSNdCWFkIHaXj0bOdhPrMMxn+lVZxZJjwJ6R4ZEzk/sxGDkzBG0IMoU+LXTUDrM8X VMToXXzWLE1Om9H7wMKFKy+2lo0g= X-Google-Smtp-Source: AGHT+IFYGhlIbmElePo7wESeoOURpi8z/foNFggrXzWJl9Ckz2bQUv6UqjNpy4xJdPri66mHTNKaFw== X-Received: by 2002:a05:6000:2886:b0:3b7:8d70:dac5 with SMTP id ffacd0b85a97d-3bb665647dcmr9959991f8f.2.1755525037164; Mon, 18 Aug 2025 06:50:37 -0700 (PDT) Received: from [192.168.1.3] ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3bb6816ef48sm12603170f8f.58.2025.08.18.06.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 06:50:36 -0700 (PDT) Message-ID: Date: Mon, 18 Aug 2025 14:50:35 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] spi: spi-fsl-lpspi: Constify devtype datas To: Frank Li Cc: Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> <20250814-james-nxp-lpspi-v1-7-9586d7815d14@linaro.org> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/08/2025 7:38 pm, Frank Li wrote: > On Thu, Aug 14, 2025 at 05:06:47PM +0100, James Clark wrote: >> struct fsl_lpspi_data->devtype_data and fsl_lpspi_dt_ids that point here >> are already const, so these can be too. > > Add const for all devtype_data. > > Frank Ack >> >> Signed-off-by: James Clark >> --- >> drivers/spi/spi-fsl-lpspi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c >> index 98da6a5d7013..332a852b746f 100644 >> --- a/drivers/spi/spi-fsl-lpspi.c >> +++ b/drivers/spi/spi-fsl-lpspi.c >> @@ -145,11 +145,11 @@ struct fsl_lpspi_data { >> * ERR051608 fixed or not: >> * https://www.nxp.com/docs/en/errata/i.MX93_1P87f.pdf >> */ >> -static struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data = { >> +static const struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data = { >> .prescale_max = 1, >> }; >> >> -static struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data = { >> +static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data = { >> .prescale_max = 7, >> }; >> >> >> -- >> 2.34.1 >>