From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80FEFEB64D0 for ; Tue, 13 Jun 2023 18:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbjFMS5l (ORCPT ); Tue, 13 Jun 2023 14:57:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240315AbjFMS5k (ORCPT ); Tue, 13 Jun 2023 14:57:40 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65DF51BEF for ; Tue, 13 Jun 2023 11:57:33 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b1bf74e080so72022711fa.1 for ; Tue, 13 Jun 2023 11:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686682651; x=1689274651; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zsyyTwvaw/vp2AvSdxNLXUl1Sss7B+R+faApw6mGFPk=; b=EpsoCgNUbEr8P/ekHeYMePrH3lx9EnGuaih1xSHCfQ6AaSSa7tJ+X0msbZs5zB0RSh Bltvzflx0blflLlM249+PTlK7N38BjYPqzgSrxSeXu4pN3yG6njvv8jc7cWijBiIGKA2 6K15ceQw5uqBaHvM5VWV/tYfqevE/SUnWSbXPXmth40TgDyy8NJX7ilVxnozDQGaQSZr SnXicXCwgT2ajHUDvwtsU+MfImTkCTBqZG45sR346wlpG/Ta1gjS62h3xknna+BzTKG+ bTpcqwD7/n0NMkoqIJdqnl/lDOYgzFBCp3ZHv8CP7A6SGX8qpgN7xTU61OTuyLZ8X61N Wm6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686682651; x=1689274651; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zsyyTwvaw/vp2AvSdxNLXUl1Sss7B+R+faApw6mGFPk=; b=QYmk0opnNyOqSW3Dp3jIpEPCyx7UANj7bfj6xcAUCPwcaIsCwtUbHZGwpGSMKSMYYu rd/D9ADwfxmGlCUWoiDcMGUeQEY4ws/r5xhojEKDccOUUuyGcXIVz+ULpzsGOYGoE8Rc Dev8K2KvmIBbvDe9aVd148Vmpxgg/0N2+LHX/vyyUGfQiBhX1UEW/R7f+ASuKHtMTZ2s 2eXwk1IYw86OBe7UWRpLNsmGb1bYbVUza21NFvMjam3PFhCmcuFVPHMmz496KWIhPvk2 OgL1/bihfcKQnkAuQSNRhXyaNVJ2nJJfhgOantczZD9z+KsSOaLKQpQWB+j6qKDIYJnM hRWw== X-Gm-Message-State: AC+VfDxxLhBGHlghfaxp76x/lVFmkSuFgDHV7Z8qv3L8FNsmGMDrj8NM oZF8BTpdsnFNyqdlPZvt1n8d2g== X-Google-Smtp-Source: ACHHUZ58SPWpBS7mZjv7bdICxXgiAzg0Iw/ZCUujbrRo5NysRIPz5M1A2dBrKoFVdo4w57IT44ob+Q== X-Received: by 2002:a2e:b98f:0:b0:2b1:fa7c:9131 with SMTP id p15-20020a2eb98f000000b002b1fa7c9131mr3438013ljp.18.1686682651365; Tue, 13 Jun 2023 11:57:31 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id a11-20020a2e980b000000b002b1c0a663fbsm2258476ljj.77.2023.06.13.11.57.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 11:57:30 -0700 (PDT) Message-ID: Date: Tue, 13 Jun 2023 20:57:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 23/26] arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface Content-Language: en-US To: Bartosz Golaszewski , Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-24-brgl@bgdev.pl> From: Konrad Dybcio In-Reply-To: <20230612092355.87937-24-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.06.2023 11:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the node for the first ethernet interface on sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 30 +++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 0e59000a0c82..f43a2a5d1d11 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -2315,6 +2315,36 @@ cpufreq_hw: cpufreq@18591000 { > > #freq-domain-cells = <1>; > }; > + > + ethernet0: ethernet@23040000 { > + compatible = "qcom,sa8775p-ethqos"; > + reg = <0x0 0x23040000 0x0 0x10000>, > + <0x0 0x23056000 0x0 0x100>; > + reg-names = "stmmaceth", "rgmii"; > + > + clocks = <&gcc GCC_EMAC0_AXI_CLK>, > + <&gcc GCC_EMAC0_SLV_AHB_CLK>, > + <&gcc GCC_EMAC0_PTP_CLK>, > + <&gcc GCC_EMAC0_PHY_AUX_CLK>; > + clock-names = "stmmaceth", "pclk", "ptp_ref", "phyaux"; Please make this a vertical list, one per line > + > + power-domains = <&gcc EMAC0_GDSC>; > + > + interrupts = ; > + interrupt-names = "macirq"; And another nit, interrupts above clocks would match what I ask others to do.. Still working on checks/guidelines for this! Reviewed-by: Konrad Dybcio Konrad > + > + phys = <&serdes_phy>; > + phy-names = "serdes"; > + > + iommus = <&apps_smmu 0x120 0xf>; > + > + snps,tso; > + snps,pbl = <32>; > + rx-fifo-depth = <16384>; > + tx-fifo-depth = <16384>; > + > + status = "disabled"; > + }; > }; > > arch_timer: timer {