From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ki-Seok Jo <kiseok.jo@irondevice.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice,sma1303 binding
Date: Thu, 2 Feb 2023 10:03:31 +0100 [thread overview]
Message-ID: <a21e7783-cb1c-8fec-78e7-bdffcd5e25f1@linaro.org> (raw)
In-Reply-To: <SLXP216MB0077847FB6CF0EF4511E3A628CD69@SLXP216MB0077.KORP216.PROD.OUTLOOK.COM>
On 02/02/2023 09:58, Ki-Seok Jo wrote:
>>> Is there anything else I should do?
>>
>> Correct the binding:
>> 1. Add all properties - just open example-schema and your file and
>> document everything 2. Fix non-existing reference (there is no such file
>> as name-prefix.yaml) 3. i2c_bus -> i2c
>
> Fortunately, I modified the 3thigns you said, and I also tested with the
> above command with the contents.
>
> So, I'll send the patch file again.
> If it has any other problems, please give me feedback.
My revert was not applied, thus please send incremental fix to the bindings.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-02-02 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 13:10 [PATCH] ASoC: dt-bindings: Drop broken irondevice,sma1303 binding Krzysztof Kozlowski
2023-02-01 13:13 ` Krzysztof Kozlowski
2023-02-01 14:03 ` Mark Brown
2023-02-01 14:43 ` Krzysztof Kozlowski
2023-02-01 15:00 ` Mark Brown
2023-02-02 1:54 ` Ki-Seok Jo
2023-02-02 5:28 ` Ki-Seok Jo
2023-02-02 8:44 ` Krzysztof Kozlowski
2023-02-02 8:58 ` Ki-Seok Jo
2023-02-02 9:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a21e7783-cb1c-8fec-78e7-bdffcd5e25f1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kiseok.jo@irondevice.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).