From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9507C43219 for ; Fri, 11 Nov 2022 15:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234102AbiKKPSm (ORCPT ); Fri, 11 Nov 2022 10:18:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233477AbiKKPRy (ORCPT ); Fri, 11 Nov 2022 10:17:54 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3609664A38 for ; Fri, 11 Nov 2022 07:17:32 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id h12so4849766ljg.9 for ; Fri, 11 Nov 2022 07:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kBeLtt806xuAVLanhVYNh3Yb8OkYSIv62TYrl3SBTCg=; b=NpUQ1k7cnJ6Y+btt/QCKgUHDvfM24FoMAzrWdP2kHUVvRcdX39YHGWI7RhlKIvRtfY Fvqc7DfeHIZB8nWuKjzVacMTbB2q+eUW9FbYki/rYpF4RyhNkou+OrxE2fVthb+90zff SvYuUeqT8TsFNm2OjorlexvawJkgedmJLil4EPu38CXdFZT14sPIptQw7tjp601UWDR8 EkkjcVXQ5zQcFoVBp9VoZQcI3pBz+Yx2wUmaUJ9HZsF3wNPzDgEn4ryA2hMYlxK4OT3j LchupSZEtoaB1SoYHnaKv6t3WOwqGv1KFGsDAevEHy3Jls7iYNJCVYxI+QwB+FUNr2mq xWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kBeLtt806xuAVLanhVYNh3Yb8OkYSIv62TYrl3SBTCg=; b=p7a9MM49C63rFR3Xvq/RBftLqEDBssKz9iYTzVmMM6OIaIGGL47/+pmfMny5Af76Pg 5jzETZ/xnWzyJc9/3pk3OdbEhHgupKzIAHVA48QxLfVtenQ1JSJPW1G68F2hHeWmTYXl 3dCj9oC0rqLnkaH2KJy3O7Gw8So5ZuS0lHm+3nLv7LU0/NVwwiBf3uwiv/Jk8+Y74nHp Qnlu/uQ9/qPkqm9T0VKxhLV++S4Tb2d6PcpqNw7bXMBBq5sYjxdDIQldl66Tb9uZG7BM 9SYqDTrlSXkGTzvBVHg2as4+0t7EFW0u99t52QMiwtb1ACJZWofarUdJ3arHtw3UZQrS n7AQ== X-Gm-Message-State: ANoB5plKZhB56cYzPQUxfOH9Zp8RLDH8RVAuhoGlSp9bbrxOii5EWRln L8zF9q+2xczbDbULGAI8zS9Zwg== X-Google-Smtp-Source: AA0mqf67yeOajmW2PCp/0xsLFqXNEMXfRV/CNsGFNrg6CE4V6sENMpCjMFr1JbX99+cv2DrS5QSDSw== X-Received: by 2002:a2e:9ec2:0:b0:277:2600:9cc0 with SMTP id h2-20020a2e9ec2000000b0027726009cc0mr797972ljk.437.1668179850436; Fri, 11 Nov 2022 07:17:30 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id d8-20020a056512368800b0049110ba325asm367089lfs.158.2022.11.11.07.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 07:17:29 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 16:17:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 02/14] dt-bindings: phy: qcom,qmp-usb3-dp: fix sc8280xp bindings Content-Language: en-US To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221111092457.10546-1-johan+linaro@kernel.org> <20221111092457.10546-3-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20221111092457.10546-3-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 10:24, Johan Hovold wrote: > The current QMP USB3-DP PHY bindings are based on the original MSM8996 > binding which provided multiple PHYs per IP block and these in turn were > described by child nodes. > Thank you for your patch. There is something to discuss/improve. > + > +maintainers: > + - Vinod Koul Maybe you want to add also yourself? > + > +description: > + The QMP PHY controller supports physical layer functionality for a number of > + controllers on Qualcomm chipsets, such as, PCIe, UFS and USB. > + > + See also: > + - include/dt-bindings/dt-bindings/phy/phy.h > + > +properties: > + compatible: > + enum: > + - qcom,sc8280xp-qmp-usb43dp-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: aux > + - const: ref > + - const: com_aux > + - const: usb3_pipe > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: phy > + - const: common > + > + vdda-phy-supply: true > + > + vdda-pll-supply: true > + > + "#clock-cells": > + const: 1 > + > + clock-output-names: > + items: > + - const: usb3_pipe > + - const: dp_link > + - const: dp_vco_div Why defining here fixed names? The purpose of this field is to actually allow customizing these - at least in most cases. If these have to be fixed, then driver should just instantiate these clocks with such names, right? Best regards, Krzysztof