From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH v2 1/3] Bluetooth: btusb: add QCA6174A compatible properties Date: Tue, 26 Feb 2019 13:31:45 +0000 Message-ID: References: <20190222225345.69084-1-briannorris@chromium.org> <49653AC5-5800-4319-B3C0-0CCA6A920E2C@holtmann.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49653AC5-5800-4319-B3C0-0CCA6A920E2C@holtmann.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Marcel Holtmann , Brian Norris Cc: Heiko Stuebner , Johan Hedberg , Rob Herring , Enric Balletbo i Serra , Douglas Anderson , devicetree , linux-arm-kernel , linux-rockchip@lists.infradead.org, "open list:BLUETOOTH DRIVERS" , Linux Kernel Mailing List , Matthias Kaehlcke , Rajat Jain List-Id: devicetree@vger.kernel.org On 26/02/2019 09:01, Marcel Holtmann wrote: > Hi Brian, > >> We may need to specify a GPIO wake pin for this device, so add a >> compatible property for it. >> >> There are at least to USB PID/VID variations of this chip: one with a >> Lite-On ID and one with an Atheros ID. >> >> Signed-off-by: Brian Norris >> Reviewed-by: Matthias Kaehlcke >> --- >> v2: >> * drop leading zeroes from VID, per documented binding >> --- >> drivers/bluetooth/btusb.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index 470ee68555d9..54cb5f583b1d 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -2862,6 +2862,8 @@ static irqreturn_t btusb_oob_wake_handler(int irq, void *priv) >> >> static const struct of_device_id btusb_match_table[] = { >> { .compatible = "usb1286,204e" }, >> + { .compatible = "usbcf3,e300" }, /* QCA6174A */ >> + { .compatible = "usb4ca,301a" }, /* QCA6174A (Lite-On) */ > > are these really proper .compatible USB VID?PID strings. I think they are one letter short. Yup - however weird it may end up looking, the usb-device binding says "...with leading zeros suppressed". Blame Open Firmware, I guess ;) Robin.