From: Krzysztof Kozlowski <krzk@kernel.org>
To: Elson Roy Serrao <quic_eserrao@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 6/8] usb: misc: eud: Add High-Speed Phy control for EUD operations
Date: Wed, 31 Jul 2024 07:39:39 +0200 [thread overview]
Message-ID: <a2460e27-697c-495f-9106-bdb9109d674b@kernel.org> (raw)
In-Reply-To: <20240730222439.3469-7-quic_eserrao@quicinc.com>
On 31/07/2024 00:24, Elson Roy Serrao wrote:
> The Embedded USB Debugger(EUD) is a HS-USB on-chip hub to support the
> debug and trace capabilities on Qualcomm devices. It is physically
> present in between the usb connector and the usb controller. Being a
> HS USB hub, it relies on HS Phy for its functionality. Add HS phy
> support in the eud driver and control the phy during eud enable/disable
> operations.
>
...
> static ssize_t enable_show(struct device *dev,
> @@ -186,6 +216,11 @@ static int eud_probe(struct platform_device *pdev)
>
> chip->dev = &pdev->dev;
>
> + chip->usb2_phy = devm_phy_get(chip->dev, "usb2-phy");
> + if (IS_ERR(chip->usb2_phy))
> + return dev_err_probe(chip->dev, PTR_ERR(chip->usb2_phy),
> + "no usb2 phy configured\n");
This nicely breaks all users.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-31 5:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 22:24 [PATCH 0/8] Enable EUD on Qualcomm sm8450 SoC Elson Roy Serrao
2024-07-30 22:24 ` [PATCH 1/8] dt-bindings: soc: qcom: eud: Add phy related bindings Elson Roy Serrao
2024-07-31 5:33 ` Krzysztof Kozlowski
2024-07-31 22:23 ` Elson Serrao
2024-08-01 7:45 ` Krzysztof Kozlowski
2025-01-27 14:40 ` Konrad Dybcio
2025-01-27 14:50 ` Konrad Dybcio
2024-07-30 22:24 ` [PATCH 2/8] dt-bindings: soc: qcom: eud: Add usb role switch property Elson Roy Serrao
2024-07-31 5:36 ` Krzysztof Kozlowski
2024-08-01 0:16 ` Elson Serrao
2024-08-01 7:46 ` Krzysztof Kozlowski
2025-01-27 14:45 ` Konrad Dybcio
2024-07-30 22:24 ` [PATCH 3/8] dt-bindings: soc: qcom: eud: Add compatible for sm8450 Elson Roy Serrao
2024-07-31 5:38 ` Krzysztof Kozlowski
2024-07-30 22:24 ` [PATCH 4/8] arm64: dts: qcom: sm8450: Add EUD node Elson Roy Serrao
2024-07-30 22:24 ` [PATCH 5/8] arm64: dts: qcom: Enable EUD on sm8450 hdk Elson Roy Serrao
2024-07-30 22:24 ` [PATCH 6/8] usb: misc: eud: Add High-Speed Phy control for EUD operations Elson Roy Serrao
2024-07-31 5:39 ` Krzysztof Kozlowski [this message]
2024-07-31 22:38 ` Elson Serrao
2024-08-01 7:45 ` Krzysztof Kozlowski
2024-07-30 22:24 ` [PATCH 7/8] usb: misc: eud: Handle usb role switch notifications Elson Roy Serrao
2024-07-31 13:06 ` Dmitry Baryshkov
2024-08-01 0:51 ` Elson Serrao
2024-08-01 8:19 ` Dmitry Baryshkov
2024-08-01 22:28 ` kernel test robot
2024-07-30 22:24 ` [PATCH 8/8] usb: misc: eud: Add compatible for sm8450 Elson Roy Serrao
2024-07-31 5:40 ` Krzysztof Kozlowski
2024-07-31 11:13 ` [PATCH 0/8] Enable EUD on Qualcomm sm8450 SoC Caleb Connolly
2024-07-31 19:58 ` Trilok Soni
2024-08-01 10:52 ` Caleb Connolly
2024-08-06 18:58 ` Trilok Soni
2024-08-28 19:31 ` Dmitry Baryshkov
2024-08-01 7:55 ` Krzysztof Kozlowski
2024-08-01 11:00 ` Caleb Connolly
2024-08-01 11:11 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2460e27-697c-495f-9106-bdb9109d674b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).