From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
phone-devel@vger.kernel.org, Will Deacon <will@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Bjorn Andersson <andersson@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Lux Aliaga <they@mint.lgbt>, Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Melody Olvera <quic_molvera@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: arm-smmu: Document smmu-500 binding for SM6125
Date: Thu, 22 Dec 2022 10:29:40 +0100 [thread overview]
Message-ID: <a251f29d-58b7-5ccb-2661-a397e41fba80@linaro.org> (raw)
In-Reply-To: <20221222082353.lhdw7h3pdqyyvsxy@SoMainline.org>
On 22/12/2022 09:23, Marijn Suijten wrote:
> On 2022-12-20 10:52:49, Krzysztof Kozlowski wrote:
>> On 19/12/2022 20:28, Marijn Suijten wrote:
>>> On 2022-12-19 10:09:03, Krzysztof Kozlowski wrote:
>>>> On 19/12/2022 10:07, Krzysztof Kozlowski wrote:
>>>>> On 16/12/2022 22:58, Marijn Suijten wrote:
>>>>>> From: Martin Botka <martin.botka@somainline.org>
>>>>>>
>>>>>> Document smmu-500 compatibility with the SM6125 SoC.
>>>>>>
>>>>>
>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> Wait, not entirely... no constraints for clocks and regs?
>>>
>>> Quite odd that there is no warning for my DT patch as it clearly
>>> requires at least one clock...
>
> Again, any idea why there's no warning for this DT mismatching minItems:
> 1 for clocks, clock-names and power-domains?
I don't know what do you have in DT and what is mismatched. Why there
should be a warning?
>
>>> Irrespective of that downstream doesn't define any (nor power domains).
>>> How should we proceed?
>>
>> Binding now has constraints for clocks so at least that should be added
>> to your variant.
>
> And that should be:
>
> clock-names: false
> clocks: false
> power-domains: false
>
> Because this board does declare have any, at least not when going off of
> downstream DT?
I'll add it for existing platforms, so you can rebase on top.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-22 9:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 21:58 [PATCH v4 0/4] arm64: dts: qcom: sm6125: Enable APPS SMMU Marijn Suijten
2022-12-16 21:58 ` [PATCH v4 1/4] dt-bindings: arm-smmu: Document smmu-500 binding for SM6125 Marijn Suijten
2022-12-19 9:07 ` Krzysztof Kozlowski
2022-12-19 9:09 ` Krzysztof Kozlowski
2022-12-19 19:28 ` Marijn Suijten
2022-12-20 9:52 ` Krzysztof Kozlowski
2022-12-22 8:23 ` Marijn Suijten
2022-12-22 9:29 ` Krzysztof Kozlowski [this message]
2022-12-22 10:10 ` Marijn Suijten
2022-12-22 10:36 ` Krzysztof Kozlowski
2022-12-22 13:17 ` Marijn Suijten
2022-12-16 21:58 ` [PATCH v4 2/4] arm64: dts: qcom: sm6125: Configure APPS SMMU Marijn Suijten
2022-12-17 14:25 ` Konrad Dybcio
2022-12-16 21:58 ` [PATCH v4 3/4] arm64: dts: qcom: sm6125: Add apps_smmu with streamID to SDHCI 1/2 nodes Marijn Suijten
2022-12-17 14:26 ` Konrad Dybcio
2022-12-18 10:26 ` Marijn Suijten
2022-12-18 11:10 ` Martin Botka
2022-12-16 21:58 ` [PATCH v4 4/4] arm64: dts: qcom: sm6125: Add IOMMU context to DWC3 Marijn Suijten
2022-12-17 14:26 ` Konrad Dybcio
2022-12-18 11:10 ` Martin Botka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a251f29d-58b7-5ccb-2661-a397e41fba80@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux.dev \
--cc=jami.kettunen@somainline.org \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=they@mint.lgbt \
--cc=treding@nvidia.com \
--cc=will@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).