From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kuldeep Singh <singh.kuldeep87k@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings
Date: Sat, 2 Apr 2022 21:57:50 +0200 [thread overview]
Message-ID: <a25961c9-3e37-46d7-844d-01b0c8a1eaba@linaro.org> (raw)
In-Reply-To: <20220402194453.GE35664@9a2d8922b8f1>
On 02/04/2022 21:44, Kuldeep Singh wrote:
> On Sat, Apr 02, 2022 at 02:29:59PM +0200, Krzysztof Kozlowski wrote:
>> On 02/04/2022 07:12, Kuldeep Singh wrote:
>>> GENI(generic interface) based Qualcomm Universal Peripheral controller
>>> can support multiple serial interfaces like spi,uart and i2c.
>>>
>>> +
>>> + power-domains:
>>> + maxItems: 1
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + required-opps:
>>> + maxItems: 1
>>
>> I have doubts this is correct property. Usually it is part of the
>> opp-table. I see sc7180 needs this, but I think it is a mistake. Do you
>> know how it is supposed to work?
>
> Not sure how exactly it works. I took reference from
> Documentation/devicetree/bindings/clock/qcom,videocc.yaml on how to add
> required-opps.
>
I see now that power domains consumer bindings also mention it:
Documentation/devicetree/bindings/power/power_domain.txt
and it might be actually used via __genpd_dev_pm_attach().
Let's keep it then.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-02 19:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220402051206.6115-1-singh.kuldeep87k@gmail.com>
2022-04-02 5:12 ` [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings Kuldeep Singh
2022-04-02 12:29 ` Krzysztof Kozlowski
2022-04-02 19:44 ` Kuldeep Singh
2022-04-02 19:57 ` Krzysztof Kozlowski [this message]
2022-04-02 18:24 ` Krzysztof Kozlowski
2022-04-02 19:34 ` Kuldeep Singh
2022-04-02 5:12 ` [PATCH 2/5] dt-bindings: qcom: geni-se: Update i2c schema reference Kuldeep Singh
2022-04-02 12:30 ` Krzysztof Kozlowski
2022-04-02 5:12 ` [PATCH 3/5] dt-bindings: serial: Update Qualcomm geni based QUP uart bindings Kuldeep Singh
2022-04-02 15:37 ` Krzysztof Kozlowski
2022-04-02 19:24 ` Kuldeep Singh
2022-04-02 5:12 ` [PATCH 4/5] dt-bindings: qcom: geni-se: Update uart schema reference Kuldeep Singh
2022-04-02 15:39 ` Krzysztof Kozlowski
2022-04-02 19:28 ` Kuldeep Singh
2022-04-02 5:12 ` [PATCH 5/5] dt-bindings: qcom: geni-se: Remove common controller properties Kuldeep Singh
2022-04-02 15:41 ` Krzysztof Kozlowski
2022-04-02 19:32 ` Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25961c9-3e37-46d7-844d-01b0c8a1eaba@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=singh.kuldeep87k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).