From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B6DC433EF for ; Sat, 2 Apr 2022 19:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240976AbiDBT7s (ORCPT ); Sat, 2 Apr 2022 15:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239677AbiDBT7r (ORCPT ); Sat, 2 Apr 2022 15:59:47 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C1BFFB6F for ; Sat, 2 Apr 2022 12:57:53 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id bg10so12434466ejb.4 for ; Sat, 02 Apr 2022 12:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=CTS+Ip4BTGEFZUlSMz44QvTyeeBYV9kdeaNljtycro8=; b=YWgHiPOBHJ6swM4FsJenjmz2o24qpjOZKscmp3Zk1ZwZ4lJsH+ADdisZOewKJpPsMd GFlXINxMCaAPEGpW1G5chekViYD8CyGGA25i6dmBy6Yngtdsmc5uE518+IdEhV2KbzKx 1e8d8dR1PGPgrey3CCjakXigighu/SQqpmxLHryw+IcOHdgvGWDumUBZtLfaHstYQ45s ktbH0oHsN2g4iSASoX9gk0Nl4JcJqXyF1mowX/9iCbsjxpv8ZlbvKl7moZJMRgbPr/Oo QUki0FD/YdSWcHcJv9ao1LxLNCbvJn0eyF/fkqC/pUF2ywQ7OYyLQnI0Yw1gUMW2AZzY fBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=CTS+Ip4BTGEFZUlSMz44QvTyeeBYV9kdeaNljtycro8=; b=uPs9UZvkCd0gb/Jti+jR6Mc31R5N2NHbZoC3q6wvHgaU26RhPNgsnkvdEwWH/abx7t braxO4/gOI5gYGyKB/rc3c6WvQA2ucV3K4rw73qyykhAisHmaY4dY1XePS/8+kGYlRdM /QpGsLo1BaoUvLZiEEbXXW4lKFRhR9TrLpN02R/a8mEkFYUdY3dqnDLBvCBDzpTSJynp HxNZMq3vhPWDGkre50d11NWTU6e5NnvMsFqa8roULsU1R7salc9KLkreuxaVZ9WTkhBo 7rcGBphe5gXMWY11Jw3gYU0gCeyIpHl2LHmZ+7duPyuEsbTvFW5nV7Q0ugz94rF1gwta PA/A== X-Gm-Message-State: AOAM532VtTG466DntemX6YlEZvaG/3OaPWMf7PCOZuS/yyjs4tPBxua0 15t0Qyqh15YUGOJad/8A8Na4fA== X-Google-Smtp-Source: ABdhPJxfx3xopyMVaLrIzERU4TjCwEaY/+buz+oZUEOJcank761ouAdg/mVhW2nFrc8qBWKStXWNsg== X-Received: by 2002:a17:907:3e0d:b0:6e0:daaa:63e0 with SMTP id hp13-20020a1709073e0d00b006e0daaa63e0mr4786049ejc.657.1648929472243; Sat, 02 Apr 2022 12:57:52 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id t19-20020a056402525300b0041952a1a764sm2834201edd.33.2022.04.02.12.57.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 12:57:51 -0700 (PDT) Message-ID: Date: Sat, 2 Apr 2022 21:57:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings Content-Language: en-US To: Kuldeep Singh Cc: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org References: <20220402051206.6115-1-singh.kuldeep87k@gmail.com> <20220402051206.6115-2-singh.kuldeep87k@gmail.com> <20220402194453.GE35664@9a2d8922b8f1> From: Krzysztof Kozlowski In-Reply-To: <20220402194453.GE35664@9a2d8922b8f1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/04/2022 21:44, Kuldeep Singh wrote: > On Sat, Apr 02, 2022 at 02:29:59PM +0200, Krzysztof Kozlowski wrote: >> On 02/04/2022 07:12, Kuldeep Singh wrote: >>> GENI(generic interface) based Qualcomm Universal Peripheral controller >>> can support multiple serial interfaces like spi,uart and i2c. >>> >>> + >>> + power-domains: >>> + maxItems: 1 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + required-opps: >>> + maxItems: 1 >> >> I have doubts this is correct property. Usually it is part of the >> opp-table. I see sc7180 needs this, but I think it is a mistake. Do you >> know how it is supposed to work? > > Not sure how exactly it works. I took reference from > Documentation/devicetree/bindings/clock/qcom,videocc.yaml on how to add > required-opps. > I see now that power domains consumer bindings also mention it: Documentation/devicetree/bindings/power/power_domain.txt and it might be actually used via __genpd_dev_pm_attach(). Let's keep it then. Best regards, Krzysztof