From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanho Park <chanho61.park@samsung.com>,
'Kishon Vijay Abraham I' <kishon@ti.com>,
'Vinod Koul' <vkoul@kernel.org>,
'Alim Akhtar' <alim.akhtar@samsung.com>,
'Rob Herring' <robh+dt@kernel.org>,
'Krzysztof Kozlowski' <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] phy: samsung: ufs: constify samsung_ufs_phy_cfg
Date: Fri, 3 Jun 2022 09:25:37 +0200 [thread overview]
Message-ID: <a26ff8ce-8d4a-ff41-13cb-0ac0cb9a74d6@linaro.org> (raw)
In-Reply-To: <050401d87681$42e6cb70$c8b46250$@samsung.com>
On 02/06/2022 15:04, Chanho Park wrote:
>>> @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct
>>> phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) {
>>> struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy);
>>> - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
>>> + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
>>
>> This should be rather array of const pointers to const data.
>
> The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch.
> So, it should be,
>
> const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg;
Not entirely, that would be const pointer (array) of pointers to const
data. What you want is:
const struct samsung_ufs_phy_cfg * const * cfgs = ufs_phy->cfg;
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-03 7:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220602053329epcas2p402901736895e6cb802a04cc3f95d172e@epcas2p4.samsung.com>
2022-06-02 5:32 ` [PATCH v2 0/6] support secondary ufs for Exynos Auto v9 SoC Chanho Park
[not found] ` <CGME20220602053329epcas2p4c2baca2d161814f5d51dc48722f904b1@epcas2p4.samsung.com>
2022-06-02 5:32 ` [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Chanho Park
2022-06-02 9:34 ` Krzysztof Kozlowski
2022-06-02 9:37 ` Krzysztof Kozlowski
2022-06-02 10:10 ` Chanho Park
2022-06-02 11:42 ` Krzysztof Kozlowski
[not found] ` <CGME20220602053329epcas2p238f5019ff98e4d9fcf5fea0001a773a9@epcas2p2.samsung.com>
2022-06-02 5:32 ` [PATCH v2 2/6] phy: samsung: ufs: constify samsung_ufs_phy_cfg Chanho Park
2022-06-02 9:42 ` Krzysztof Kozlowski
2022-06-02 13:04 ` Chanho Park
2022-06-03 7:25 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20220602053329epcas2p19785735bcbf08ad274ff887797485b8c@epcas2p1.samsung.com>
2022-06-02 5:32 ` [PATCH v2 3/6] phy: samsung: ufs: support secondary ufs phy Chanho Park
2022-06-02 9:49 ` Krzysztof Kozlowski
2022-06-02 12:59 ` Chanho Park
[not found] ` <CGME20220602053329epcas2p407039a6087b6c460d6687b1cc1f3872a@epcas2p4.samsung.com>
2022-06-02 5:32 ` [PATCH v2 4/6] arm64: dts: exynosautov9: adjust DT style of ufs nodes Chanho Park
2022-06-02 9:49 ` Krzysztof Kozlowski
2022-06-06 9:22 ` Krzysztof Kozlowski
2022-06-07 5:21 ` Chanho Park
2022-06-07 6:33 ` Krzysztof Kozlowski
2022-06-07 6:48 ` Chanho Park
2022-06-07 6:32 ` (subset) " Krzysztof Kozlowski
[not found] ` <CGME20220602053329epcas2p3dc1aa5e50c5eab03309e67b95e2993ff@epcas2p3.samsung.com>
2022-06-02 5:32 ` [PATCH v2 5/6] arm64: dts: exynosautov9: add secondary ufs devices Chanho Park
[not found] ` <CGME20220602053329epcas2p263a77beaaa17d20655bbf55874760054@epcas2p2.samsung.com>
2022-06-02 5:32 ` [PATCH v2 6/6] arm64: dts: exynosautov9-sadk: enable " Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26ff8ce-8d4a-ff41-13cb-0ac0cb9a74d6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).