From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D06C43334 for ; Fri, 3 Jun 2022 07:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242342AbiFCHZ7 (ORCPT ); Fri, 3 Jun 2022 03:25:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbiFCHZt (ORCPT ); Fri, 3 Jun 2022 03:25:49 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5AFB3703A for ; Fri, 3 Jun 2022 00:25:40 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id w27so9015269edl.7 for ; Fri, 03 Jun 2022 00:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zG5AY7gRdR9REFolbYOoL6mkBmPRBxthFvw+JcZiEBI=; b=OokJ/+xIcnmapqXFSxrsQuJTABgsm0t0PF1D2E91yuSX2c6qoKpBTTMJi1+4qSRlUg wxX/dkg5rWq39IJqBxvZw76CSAGLpoXzly4PkOCzsZtRe4LOtaRkaP3t8dR0a8LdpNMl KsOORwvhI6cLQY+5nzcsMm2SVVRYIqI6lUPct275MyFDBXL9zahYpHzt/1hBbBoT9Aep TnSTseg2L0D+cS9Bf8O03NXFXvLoLx6wot0Xv0Qi7Z2qGtmM/iAz7g0PG3g3ONWvFdiZ cTnl4OxBbqG+mG1q9NVgNj6rs+HJ56F6i+K1ozjC+x+Gton2dPeE1YYGX4jhL4PGAQYC BBAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zG5AY7gRdR9REFolbYOoL6mkBmPRBxthFvw+JcZiEBI=; b=hXZ2uVzju0bW9NHYFwS7O7vfg3SgKf5d4zbJRrBn307d2/dze/+xBlggD5IMZsz5B+ t8a1xND4RuWbFv0R46pX6Hu8e8x07FNIh8qiJXQSR5DdUkrLqs3W9GeXdOYtXd1/A9OG /87iTzz7f0egvJWR845eqPNAtwm8EgR0HA1vIiM7ys9kyc0uiS5rEuCcFCgY6QDt7ELQ Gdq0Mt8XhX8BjbW6VLtoHGPQABTeHmubPPTI/LFnH9AYk/tRIBIuK83La36D5d1IU7e+ sUyok8SsNcesAZUzioLTZq4ejhvkwd08wakARy8fgc2YQWDhpseKooRSuctpZsM6D8Ne 1FYg== X-Gm-Message-State: AOAM532sPl59mVCcvGoRuBVc2T8T3gClUwyZWH0GGrrNc6glyGlEaUHO 6LAKB2p4Biwv+YwqiY/pTQZtTA== X-Google-Smtp-Source: ABdhPJzOolN1W6YFoKkVEOMoe+Drf+5VNDcIUTEWcWXTOzwVU81e3daQrXlTynC8ImczDTyd9p00EA== X-Received: by 2002:a05:6402:528c:b0:42d:cf7e:bc87 with SMTP id en12-20020a056402528c00b0042dcf7ebc87mr9419571edb.70.1654241139408; Fri, 03 Jun 2022 00:25:39 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o19-20020a1709061b1300b006fed85c1a8fsm2568465ejg.202.2022.06.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 00:25:39 -0700 (PDT) Message-ID: Date: Fri, 3 Jun 2022 09:25:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 2/6] phy: samsung: ufs: constify samsung_ufs_phy_cfg Content-Language: en-US To: Chanho Park , 'Kishon Vijay Abraham I' , 'Vinod Koul' , 'Alim Akhtar' , 'Rob Herring' , 'Krzysztof Kozlowski' Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-3-chanho61.park@samsung.com> <58e06727-a9ae-7466-6bc3-feee92bd9bf1@linaro.org> <050401d87681$42e6cb70$c8b46250$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <050401d87681$42e6cb70$c8b46250$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/06/2022 15:04, Chanho Park wrote: >>> @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct >>> phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { >>> struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); >>> - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; >>> + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg; >> >> This should be rather array of const pointers to const data. > > The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch. > So, it should be, > > const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg; Not entirely, that would be const pointer (array) of pointers to const data. What you want is: const struct samsung_ufs_phy_cfg * const * cfgs = ufs_phy->cfg; Best regards, Krzysztof