From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: alison@she-devel.com, johan@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, achaiken@aurora.tech
Subject: Re: [PATCH 2/2] dt-bindings: gnss: Add U-Blox Zed-F9
Date: Mon, 8 May 2023 08:39:03 +0200 [thread overview]
Message-ID: <a2718541-9dd7-e093-0f62-d62e56dcb04d@linaro.org> (raw)
In-Reply-To: <20230508011159.263322-3-alison@she-devel.com>
On 08/05/2023 03:11, alison@she-devel.com wrote:
> From: Alison Chaiken <achaiken@aurora.tech>
>
> Add support for the U-Blox Zed-F9P GNSS device.
>
> Signed-off-by: Alison Chaiken <achaiken@aurora.tech>
> ---
You miss versioning your paches and changelog here.
Also:
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Missing tag:
Acked-by: Rob Herring <robh@kernel.org>
> Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 1 +
> 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-08 6:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 1:11 [PATCH v5 0/2] support config of U-Blox Zed-F9P GNSS alison
2023-05-08 1:11 ` [PATCH v4 1/2] gnss: ubx: customize serial device open to set U-Blox Zed-F9P baud alison
2023-05-08 7:52 ` kernel test robot
2023-05-08 8:00 ` Krzysztof Kozlowski
2023-05-08 1:11 ` [PATCH 2/2] dt-bindings: gnss: Add U-Blox Zed-F9 alison
2023-05-08 2:26 ` Rob Herring
2023-05-08 6:39 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-05-15 0:40 [PATCH v6 0/2] alison
2023-05-15 0:40 ` [PATCH 2/2] dt-bindings: gnss: Add U-Blox Zed-F9 alison
2023-05-15 6:30 ` Krzysztof Kozlowski
2023-05-15 17:06 ` Conor Dooley
2023-05-06 22:58 [PATCH v4 0/2] support config of U-Blox Zed-F9P GNSS alison
2023-05-06 22:58 ` [PATCH 2/2] dt-bindings: gnss: Add U-Blox Zed-F9 alison
2023-05-01 17:01 [PATCH v3 0/2] support config of U-Blox Zed-F9P GNSS alison
2023-05-01 17:01 ` [PATCH 2/2] dt-bindings: gnss: Add U-Blox Zed-F9 alison
2023-05-01 17:42 ` Krzysztof Kozlowski
2023-05-05 21:21 ` Rob Herring
2023-05-05 21:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2718541-9dd7-e093-0f62-d62e56dcb04d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=achaiken@aurora.tech \
--cc=alison@she-devel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).