From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D56E1CBE90 for ; Fri, 6 Sep 2024 13:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725627637; cv=none; b=qWPQ8O0O1RnhcfF5+/q28yiLCk7ihRsez8sC8+O1Gyqpm1vbbED43+979h73cYR9SMQnlvusm/CX3If0ytWcGC7906iGABbni2NGVScNEEvJBEP9p6wK+fcsRyzUA+EjyOV1/q7HpB8mvRkSyngAPnivG3JIuoWJJhGq81XYX4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725627637; c=relaxed/simple; bh=a3n6h+tmjlmVA4Afuyy01EvnM6vGCqk59VkMNlPDoxA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rKfimJG4VUjqsFB1DH8rGCBUoZhFuhS21IiEN/9HiXv1rOsSWHQ7UT6qy0NqQuiBhijbiSnfcyoCybV9ds+c/BtvnngQ5V/N0qHw3Lag4EySpDtCAlHKAKDKrOSANx+ScHyfzdCZ/X84SzGElRKsZGUOH3wPAI5GrotoRaRPc/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GCc2uuLa; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GCc2uuLa" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-53653c23c3bso269198e87.3 for ; Fri, 06 Sep 2024 06:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725627634; x=1726232434; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+HldWfppnPmR7E3ewI2SdbP6fmafd7q2H7imYAtRaLo=; b=GCc2uuLa1lVY4mSDdkzNUD9eoBqS3S8LqAsSF9IjfTVrHsby10gmkQggMhho5X6NxV HoUTf10QmGnofQl/R+V98RLhFGEAO1y4hfGomvNLCqRNSzf6scn8AEJuDMXF0EvyiHIy lx/XJurbyttNVmnWDlCIy4Ia2Tif4ItRiVIORYbzFa0CQuupxGjzeuAxFMevhuSh4OGG Q+Y1+51ulq2EEzqMJ1GbJlAM6eYIgUDjRWPGA/pMc1MF1idyaVrYZ7VB6yPW1N4YJ/jD TQLThgFhR8IwlHPvxfTsZn2TiUYiirJKAWMMzdlLZx4q5ykDp0lgyCzVV6qX5y48/o/S yzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725627634; x=1726232434; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+HldWfppnPmR7E3ewI2SdbP6fmafd7q2H7imYAtRaLo=; b=YN5hFk2N3h5eb1ATHlQgt0jyz+Dt+xEL8qxyoT08BATc5XHttkvmAlXFUy6eO0EAID bpyckzJrDpr5B+OAs7rKDkWbq2rVE1Uku89Hl23N/xtFQh5v/Gwfe+zrrZvSNkhreHOk 7IfXlPbQEZIagzUADWwg08bzbD53YzbI4Tv4y9SwlfMykLaRBIc+8bGj/yaS+ZJCM7Si MAICGvnG35/zPBnoayKl2TyehTTbc4biWUznGae4AAPttP8hwgRnTjKAutBha4VWH+rE eTC3xFC+eqABsmXMUtXQyV2oTGQzPC0kIZPqru/lUBrEVholQG/RWF3TZZyT5+k6Fzdr Iduw== X-Forwarded-Encrypted: i=1; AJvYcCWZmR5TYYJ4xXrkK1bPgngiZ/86hBF/ag6u+dqCqD/3s7pyN5qNBNJsJ3sMaNl86iL3SVsINNqb050X@vger.kernel.org X-Gm-Message-State: AOJu0YyWM34BxLlD6v6vLNB6UHJ0JUc68PHVcQ3ubEsAcOPqfwtQGpv+ MJmml5WETx+eIau4UK9yQSABRGFGDzDhk+FLrndI7+doHFGqjDdYU5mBgR8h/VsBYVPuKWSK+ZN R X-Google-Smtp-Source: AGHT+IEPgCZe7nIoVPCspseu508VwlLQFUeA/X0Be0jNtg/3vmAW2na6nGzOrDVGstjDu5h3e861tg== X-Received: by 2002:a05:6512:3d1b:b0:536:55f2:2ad0 with SMTP id 2adb3069b0e04-53658814568mr887069e87.9.1725627634001; Fri, 06 Sep 2024 06:00:34 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53569ee732fsm624590e87.156.2024.09.06.06.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2024 06:00:33 -0700 (PDT) Message-ID: Date: Fri, 6 Sep 2024 16:00:32 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/7] Add SDM670 camera subsystem Content-Language: en-US To: Bryan O'Donoghue , Richard Acayan , Andi Shyti Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org References: <20240904020448.52035-9-mailingradian@gmail.com> <5c58b41a-7fc7-456d-979c-edb8dbe4305d@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <5c58b41a-7fc7-456d-979c-edb8dbe4305d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bryan, Richard, On 9/6/24 15:19, Bryan O'Donoghue wrote: > On 06/09/2024 03:36, Richard Acayan wrote: >> On Thu, Sep 05, 2024 at 10:09:34PM +0200, Andi Shyti wrote: >>> Hi Richard, >>> >>> On Tue, Sep 03, 2024 at 10:04:49PM GMT, Richard Acayan wrote: >>>> This adds support for the camera subsystem on the Snapdragon 670. >>>> >>>> As of next-20240902, camss seems to be a bit broken, but the same series >>>> works on stable (although it is much less reliable now that the CCI clock >>>> frequency is not being assigned). >>> >>> I am not understanding this bit: is this series making it better >>> or not? Can you please clarify what is broken, what is less >>> reliable and what works? >> >> When applying this camss series and some camera sensor patches on >> linux-next, the Pixel 3a seems to hang when camera capture starts. >> >> When applying the same patches on stable, the camera does not cause the >> Pixel 3a to hang. > > Right so -next isn't stable that's not exactly a revelation. > > >> When these device tree properties from the previous series were removed: >> >> assigned-clocks = <&camcc CAM_CC_CCI_CLK>; >> assigned-clock-rates = <37500000>; >> >> the CCI would sometimes fail to probe with the error: > > Right, we don't have clk_set_rate in the cci driver. > > Maybe just leave the assigned clock for this submission and we can do a > sweep of fixes to CCI at a later stage including setting the clock > instead of having it be assigned. first of all it would be nice to confirm that the setting of a particular clock frequency is actually needed. Fortunately it's pretty trivial to check it in runtime with a temporary modification in the board dts file, namely disable CAMSS in board dts file, but keep CCI enabled, then simply scan the bus with a regular "i2cdetect" tool in runtime. If i2cdetect on the CCI bus works only for 37.5MHz clock frequency, then it is needed, otherwise (and this is my expectation) it is not needed neither in the dtsi files nor in the driver. >> >> [ 51.572732] i2c-qcom-cci ac4a000.cci: deferred probe timeout, ignoring dependency >> [ 51.572769] i2c-qcom-cci ac4a000.cci: probe with driver i2c-qcom-cci failed with error -110 >> >> On further testing, the rate can be set to 19.2 MHz, and there would be >> no failure (or rather, it wouldn't happen often enough for me to witness >> it). > > That's expected 19.2 and 37.5 MHz are supported by CAMCC for your part. > I read it as the setting of 37.5MHz clock frequency is not needed, please correct me. -- Best wishes, Vladimir