From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>, Lee Jones <lee@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Support Opensource <support.opensource@diasemi.com>,
Steve Twiss <stwiss.opensource@diasemi.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
Date: Thu, 7 Dec 2023 09:35:20 +0100 [thread overview]
Message-ID: <a27c0fc9-614d-4207-b087-87b44bc38156@linaro.org> (raw)
In-Reply-To: <20231206155740.5278-3-biju.das.jz@bp.renesas.com>
On 06/12/2023 16:57, Biju Das wrote:
> The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> are required. The fallback compatible string "dlg,da9062-watchdog" will be
> used on DA9061 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v3->v4:
> * Dropped comment for d9061 watchdog fallback.
> * Replaced enum->const for dlg,da9061-watchdog and its fallback.
> v2->v3:
> * No change
> v2:
> * New patch
> ---
> .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> index f058628bb632..7c63b99dac85 100644
> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> @@ -14,9 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - dlg,da9061-watchdog
> - - dlg,da9062-watchdog
> + oneOf:
> + - items:
Drop items, just enum. Easier to read so usually we keep such syntax for
compatibles.
> + - enum:
> + - dlg,da9062-watchdog
> + - items:
> + - const: dlg,da9061-watchdog
> + - const: dlg,da9062-watchdog
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-07 8:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 15:57 [PATCH v4 0/8] Convert DA906{1,2} bindings to json-schema Biju Das
2023-12-06 15:57 ` [PATCH v4 1/8] dt-bindings: mfd: da9062: Update watchdog description Biju Das
2023-12-07 8:34 ` Krzysztof Kozlowski
2023-12-06 15:57 ` [PATCH v4 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
2023-12-07 8:35 ` Krzysztof Kozlowski [this message]
2023-12-07 16:41 ` Biju Das
2023-12-06 15:57 ` [PATCH v4 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
2023-12-06 15:57 ` [PATCH v4 4/8] dt-bindings: mfd: dlg,da9063: Update watchdog property Biju Das
2023-12-06 15:57 ` [PATCH v4 5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema Biju Das
2023-12-07 8:37 ` Krzysztof Kozlowski
2023-12-07 16:42 ` Biju Das
2023-12-06 15:57 ` [PATCH v4 6/8] dt-bindings: thermal: Convert da906{1,2} thermal " Biju Das
2023-12-06 15:57 ` [PATCH v4 7/8] dt-bindings: mfd: dlg,da9063: Sort child devices Biju Das
2023-12-06 15:57 ` [PATCH v4 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema Biju Das
2023-12-07 8:43 ` Krzysztof Kozlowski
2023-12-07 17:03 ` Biju Das
2023-12-08 7:55 ` Krzysztof Kozlowski
2023-12-09 15:41 ` Biju Das
2023-12-09 16:07 ` Krzysztof Kozlowski
2023-12-09 16:38 ` Biju Das
2023-12-07 8:38 ` [PATCH v4 0/8] Convert DA906{1,2} bindings " Krzysztof Kozlowski
2023-12-07 9:01 ` Biju Das
2023-12-07 9:16 ` Krzysztof Kozlowski
2023-12-07 9:20 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a27c0fc9-614d-4207-b087-87b44bc38156@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).