From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524EEC001DE for ; Mon, 31 Jul 2023 12:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231247AbjGaMmX (ORCPT ); Mon, 31 Jul 2023 08:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbjGaMmW (ORCPT ); Mon, 31 Jul 2023 08:42:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF0ECBE for ; Mon, 31 Jul 2023 05:42:20 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qQSE5-0006f4-5g; Mon, 31 Jul 2023 14:42:17 +0200 Message-ID: Date: Mon, 31 Jul 2023 14:42:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply Content-Language: en-US To: =?UTF-8?Q?Guido_G=c3=bcnther?= , David Heidelberg Cc: devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Fabio Estevam , Sascha Hauer , Peng Fan , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org, kernel@puri.sm References: <20230730121047.43115-1-david@ixit.cz> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello David, Hello Guido, On 31.07.23 13:32, Guido Günther wrote: > Hi, > On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: >> Resolves following warning: >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) >> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# >> >> Cc: kernel@puri.sm >> Cc: Guido Günther >> Signed-off-by: David Heidelberg >> --- >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> index b3549eae6278..a8b5da3ca08f 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> @@ -1031,7 +1031,7 @@ &usdhc2 { >> pinctrl-2 = <&pinctrl_usdhc2_200mhz>; >> bus-width = <4>; >> vmmc-supply = <®_usdhc2_vmmc>; >> - power-supply = <&wifi_pwr_en>; >> + vqmmc-supply = <&wifi_pwr_en>; > > From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` > so I don't think vqmmc is correct here. I wonder if there's a better way > to model that in DT? Any suggestions would be welcome. I think mmc-pwrseq is what you are after. Cheers, Ahmad > > Cheers, > -- Guido > >> broken-cd; >> disable-wp; >> cap-sdio-irq; >> -- >> 2.40.1 >> > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |