* [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
@ 2023-07-30 12:10 David Heidelberg
2023-07-31 11:32 ` Guido Günther
0 siblings, 1 reply; 4+ messages in thread
From: David Heidelberg @ 2023-07-30 12:10 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Guido Günther, David Heidelberg, Peng Fan
Cc: kernel, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-kernel
Resolves following warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
Cc: kernel@puri.sm
Cc: Guido Günther <agx@sigxcpu.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index b3549eae6278..a8b5da3ca08f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -1031,7 +1031,7 @@ &usdhc2 {
pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
bus-width = <4>;
vmmc-supply = <®_usdhc2_vmmc>;
- power-supply = <&wifi_pwr_en>;
+ vqmmc-supply = <&wifi_pwr_en>;
broken-cd;
disable-wp;
cap-sdio-irq;
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
2023-07-30 12:10 [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply David Heidelberg
@ 2023-07-31 11:32 ` Guido Günther
2023-07-31 12:42 ` Ahmad Fatoum
0 siblings, 1 reply; 4+ messages in thread
From: Guido Günther @ 2023-07-31 11:32 UTC (permalink / raw)
To: David Heidelberg
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Peng Fan, kernel, Krzysztof Kozlowski, devicetree,
linux-arm-kernel, linux-kernel
Hi,
On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
> Resolves following warning:
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>
> Cc: kernel@puri.sm
> Cc: Guido Günther <agx@sigxcpu.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index b3549eae6278..a8b5da3ca08f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -1031,7 +1031,7 @@ &usdhc2 {
> pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
> bus-width = <4>;
> vmmc-supply = <®_usdhc2_vmmc>;
> - power-supply = <&wifi_pwr_en>;
> + vqmmc-supply = <&wifi_pwr_en>;
From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
so I don't think vqmmc is correct here. I wonder if there's a better way
to model that in DT? Any suggestions would be welcome.
Cheers,
-- Guido
> broken-cd;
> disable-wp;
> cap-sdio-irq;
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
2023-07-31 11:32 ` Guido Günther
@ 2023-07-31 12:42 ` Ahmad Fatoum
2023-08-10 5:23 ` David Heidelberg
0 siblings, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2023-07-31 12:42 UTC (permalink / raw)
To: Guido Günther, David Heidelberg
Cc: devicetree, Conor Dooley, Krzysztof Kozlowski, Fabio Estevam,
Sascha Hauer, Peng Fan, linux-kernel, Krzysztof Kozlowski,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
linux-arm-kernel, kernel
Hello David,
Hello Guido,
On 31.07.23 13:32, Guido Günther wrote:
> Hi,
> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
>> Resolves following warning:
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
>> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>>
>> Cc: kernel@puri.sm
>> Cc: Guido Günther <agx@sigxcpu.org>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> index b3549eae6278..a8b5da3ca08f 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> @@ -1031,7 +1031,7 @@ &usdhc2 {
>> pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
>> bus-width = <4>;
>> vmmc-supply = <®_usdhc2_vmmc>;
>> - power-supply = <&wifi_pwr_en>;
>> + vqmmc-supply = <&wifi_pwr_en>;
>
> From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
> so I don't think vqmmc is correct here. I wonder if there's a better way
> to model that in DT? Any suggestions would be welcome.
I think mmc-pwrseq is what you are after.
Cheers,
Ahmad
>
> Cheers,
> -- Guido
>
>> broken-cd;
>> disable-wp;
>> cap-sdio-irq;
>> --
>> 2.40.1
>>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
2023-07-31 12:42 ` Ahmad Fatoum
@ 2023-08-10 5:23 ` David Heidelberg
0 siblings, 0 replies; 4+ messages in thread
From: David Heidelberg @ 2023-08-10 5:23 UTC (permalink / raw)
To: Ahmad Fatoum, Guido Günther
Cc: devicetree, Conor Dooley, Krzysztof Kozlowski, Fabio Estevam,
Sascha Hauer, Peng Fan, linux-kernel, Krzysztof Kozlowski,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
linux-arm-kernel, kernel
On 31/07/2023 14:42, Ahmad Fatoum wrote:
> Hello David,
> Hello Guido,
>
> On 31.07.23 13:32, Guido Günther wrote:
>> Hi,
>> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
>>> Resolves following warning:
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
>>> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>>>
>>> Cc: kernel@puri.sm
>>> Cc: Guido Günther <agx@sigxcpu.org>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> index b3549eae6278..a8b5da3ca08f 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> @@ -1031,7 +1031,7 @@ &usdhc2 {
>>> pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
>>> bus-width = <4>;
>>> vmmc-supply = <®_usdhc2_vmmc>;
>>> - power-supply = <&wifi_pwr_en>;
>>> + vqmmc-supply = <&wifi_pwr_en>;
>> From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
>> so I don't think vqmmc is correct here. I wonder if there's a better way
>> to model that in DT? Any suggestions would be welcome.
> I think mmc-pwrseq is what you are after.
Guido sent patch to replace it with `mmc-pwrseq` in
https://www.spinics.net/lists/kernel/msg4894084.html
--
David Heidelberg
Certified Linux Magician
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-10 5:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-30 12:10 [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply David Heidelberg
2023-07-31 11:32 ` Guido Günther
2023-07-31 12:42 ` Ahmad Fatoum
2023-08-10 5:23 ` David Heidelberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).