From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF230C61DA4 for ; Mon, 6 Feb 2023 11:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjBFLU1 (ORCPT ); Mon, 6 Feb 2023 06:20:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbjBFLU0 (ORCPT ); Mon, 6 Feb 2023 06:20:26 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B41A593EF for ; Mon, 6 Feb 2023 03:20:24 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id i38so227082eda.1 for ; Mon, 06 Feb 2023 03:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uhqMPSXHkvCWfILufq4Ld5aNdSejDT2hVXfv3Ko2CUk=; b=raPqjNh3bznGcgDJNpjJBoLmU9KWkSOkMrFpN7R1Hgnir1F0Uqs123HqifgHra8qQi EAMz90ugLBZPLTZ3LmsJD1AT4+N6KRqgbdAoxb+oL860KL+oHsW60dI90Tspq5hhBVcF jgbIJ9LO4oabGBLUewmdyw5AxF+uY634xAsdogI/47oL2guzk4+kGzQePDmJjZCUf1s9 qnJjRHiFVMR4FmFqXG5KiLfYDhJZh11oQngLr6eoKjqSnPaCR9T3/yYJHws6sqOpQEQT MniwC2wyCE+o/0l/HWIJPV4rpLL6rSBr/KPhIiqwuL3M6dZZFy0Y6SV7egdvEjH4vrPL Suaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uhqMPSXHkvCWfILufq4Ld5aNdSejDT2hVXfv3Ko2CUk=; b=OHVSwjZc01wrJIrSzph+7ZZW1HqyBa4geGA9DIgVTKD2HVYUh/4i40lYn/v/9UO0bb PnS7GXHUPetQRMtm8IeZUaSoNOUvZ7LY36C+q3ZlafTVM5aDw3dCDBxb9wwfhTUsOxRs fpA0aMOnrQQXIOkukPHpuYBcHfXs+fuB3t0MkuMZpOjnjbffnFLBMCrLR5ix5jQG5FsJ l27iKSjPtdZ/Ev/q49WkevsCF4H+U+26mbdjz+hP/dN6XMNkrJHjTqJREz/WAi9MuPaK sfYRUhenXht/bEldqZaxDP+yVTYtZI/CTzS+dmbjDchTyDNYoJnnH6KhW5s0OQ2FNomm +GhQ== X-Gm-Message-State: AO0yUKX3bzygnf4MgFNigiCPVoORcmuEg6Pt8fwdt9JqeY1M5zj8z2BK QdK1HSUpaxJznVbYOFvAU+tIUQ== X-Google-Smtp-Source: AK7set/hlkKx+T8IiESp6Csj2ct0GVBLugzKhydhbyw/fPZb4IlnO73KtOwKu/XBQbnVKeR1sPtxPw== X-Received: by 2002:a05:6402:3603:b0:4a0:e237:2cef with SMTP id el3-20020a056402360300b004a0e2372cefmr20831204edb.4.1675682423357; Mon, 06 Feb 2023 03:20:23 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id v17-20020aa7dbd1000000b004a249a97d84sm4903348edt.23.2023.02.06.03.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 03:20:23 -0800 (PST) Message-ID: Date: Mon, 6 Feb 2023 13:20:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible Content-Language: en-GB To: Krzysztof Kozlowski , Neil Armstrong , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Kuogee Hsieh , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230206-topic-sm8450-upstream-dp-controller-v1-0-f1345872ed19@linaro.org> <20230206-topic-sm8450-upstream-dp-controller-v1-1-f1345872ed19@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/02/2023 12:33, Krzysztof Kozlowski wrote: > On 06/02/2023 11:17, Neil Armstrong wrote: >> The SM8450 & SM350 shares the same DT TX IP version, use the >> SM8350 compatible as fallback for SM8450. >> >> Signed-off-by: Neil Armstrong >> --- >> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index 0e8d8df686dc..98bae326e655 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -25,6 +25,10 @@ properties: >> - qcom,sc8280xp-edp >> - qcom,sdm845-dp >> - qcom,sm8350-dp >> + - items: >> + - enum: >> + - qcom,sm8450-dp > > Indentation looks wrong here. Testing should fail, did you test it? Moreover it also breaks dt-schema, see https://github.com/devicetree-org/dt-schema/issues/98 > > Best regards, > Krzysztof > -- With best wishes Dmitry