From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA5AC7EE2F for ; Thu, 1 Jun 2023 08:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232050AbjFAISb (ORCPT ); Thu, 1 Jun 2023 04:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232014AbjFAISa (ORCPT ); Thu, 1 Jun 2023 04:18:30 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 189AD11F for ; Thu, 1 Jun 2023 01:18:29 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5149aafef44so898906a12.0 for ; Thu, 01 Jun 2023 01:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685607507; x=1688199507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lIA79XBwvYumb/G8gUWPX+7zKEo7ElCUwf5JGjf9O3k=; b=zsKPj3I6Qhnvcy8aehpi2yXfXSU26bcoom+KTNnFvB/Iwkk81xZJ+aKsIEBs5bmXvf 0OO4gPbCrMOqljgg5vygSJJa//lYsViC5ql5FF3n1Lo6MOU3pyIqqDmAY8Cjeb5fe2Z5 /RnFClxAYbEeCarLTy3yAe8Xl9D/32+Ys/4rDmeZuvmHQuRDwe3NE+DTrzQkqmYIljPR Z5y7QjZcBm7SeoocTblARvt746oxvQuTjuDDcVAsAENh6DP+x8rMbBSZ8TlNqrxkpjhB FSQ+Sf6jeY+yVZiEkMQuq8WpkC7gYnTodq1zhYmq/FLiDX28KGTnLtCgiYdH4pYQrTxY 9TNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685607507; x=1688199507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lIA79XBwvYumb/G8gUWPX+7zKEo7ElCUwf5JGjf9O3k=; b=IOAwEsT8PLHwC2JoT/YBj5ZY679vhuOLihQ8TZfLgH4Y2vDP6fywKdL/mS290349m+ GBsuaiFO3EYm9oddiHZTuwHrkerykEagoUcF7YwD+vSMdQL+eWhnkNUZy5jI/vDvufOj ZxPDhVz8ulPNf+9gKr8cvAPGFSgnuoP+QHyYgsLqEOLQVwZCrjOia4Q8AqWMKOkP2JWf uEKuASNa01BhxtHSr1jJsB6TJQKLVHNI4GuW/z+4nBnD4oPbfGrMzf8FnJ0v1Q7/C9L1 KyS0UURvuI3dKgL4g4jKOz7cQvrY4lsPiCxMKvnxwg5EHi419YgDXpbzwpFoUZZw0jeM QnEg== X-Gm-Message-State: AC+VfDyYTFLJ36FkFC2wI7A1OJzVZbVI6nIg/v3VkBlPpOg234JnRe0t lXBtZxvVFvc30yhtqLpAzLwhDA== X-Google-Smtp-Source: ACHHUZ7+qR1XZbCdhw3gHi5Up/bxJ6eI81Q8ByfLGunNMvzPMiH3SU8lsg35Mbo1RH0mvBXraMgkhw== X-Received: by 2002:a05:6402:1a4c:b0:514:8f89:fafe with SMTP id bf12-20020a0564021a4c00b005148f89fafemr5353142edb.33.1685607507452; Thu, 01 Jun 2023 01:18:27 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id a19-20020a50ff13000000b005148f0e8568sm6502020edu.39.2023.06.01.01.18.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 01:18:27 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 10:18:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86 Content-Language: en-US To: Nikita Shubin , Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Michael Peters , Kris Bahnsen , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-11-nikita.shubin@maquefel.me> From: Krzysztof Kozlowski In-Reply-To: <20230601054549.10843-11-nikita.shubin@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/06/2023 07:45, Nikita Shubin wrote: > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC. > > Signed-off-by: Nikita Shubin > --- > > Notes: > v0 -> v1: > > - s/dallas/st/ > - description for regs > - s/additionalProperties/unevaluatedProperties/ > - add ref rtc.yaml > - changed compatible to st,m48t86 > - dropped label in example > - replaced Alessandro Alessandro to Alexandre Belloni > > .../bindings/rtc/st,m48t86-rtc.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > new file mode 100644 > index 000000000000..eb8e6451d7c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml Filename based on compatible, so drop "rtc". > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM typo: with > + > +maintainers: > + - Alexandre Belloni > + > +properties: > + compatible: > + enum: > + - st,m48t86 > + > + reg: > + items: > + - description: index register > + - description: data register > + > +allOf: > + - $ref: rtc.yaml > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg required goes after properties: Keep the same order in all your patches. > + > +examples: > + - | > + rtc@10800000 { > + compatible = "st,m48t86"; > + reg = <0x10800000 0x1>, <0x11700000 0x1>; One byte long? Not a word? > + }; > + > +... Best regards, Krzysztof