From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1245C4332F for ; Fri, 9 Dec 2022 01:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbiLIB2Z (ORCPT ); Thu, 8 Dec 2022 20:28:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiLIB2Y (ORCPT ); Thu, 8 Dec 2022 20:28:24 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2959801CF; Thu, 8 Dec 2022 17:28:22 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 0C79924E1FF; Fri, 9 Dec 2022 09:28:13 +0800 (CST) Received: from EXMBX173.cuchost.com (172.16.6.93) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 09:28:13 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX173.cuchost.com (172.16.6.93) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 09:28:11 +0800 Message-ID: Date: Fri, 9 Dec 2022 09:28:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration Content-Language: en-US To: Conor Dooley CC: , , , , "David S . Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20221201090242.2381-1-yanhong.wang@starfivetech.com> <20221201090242.2381-8-yanhong.wang@starfivetech.com> From: yanhong wang In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX173.cuchost.com (172.16.6.93) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/12/2 3:30, Conor Dooley wrote: > On Thu, Dec 01, 2022 at 05:49:08PM +0000, Conor Dooley wrote: >> On Thu, Dec 01, 2022 at 05:02:42PM +0800, Yanhong Wang wrote: >> > riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration >> > >> > Add phy delay_chain configuration to support motorcomm phy driver for >> > StarFive VisionFive 2 board. > > nit: please re-word this commit next time around to actually say what > you're doing here. I didn't notice it initially, but this patch is doing > a lot more than adding `delay_chain` configuration. To my dwmac unaware > brain, there's nothing hits for that term outside of the changelog :( > I will re-word the commit message and add another dt-binding to describe the details that such as "rxc_dly_en","tx_inverted_10" etc. > Thanks, > Conor. > >> > >> > Signed-off-by: Yanhong Wang >> > --- >> > .../jh7110-starfive-visionfive-v2.dts | 46 +++++++++++++++++++ >> > 1 file changed, 46 insertions(+) >> > >> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts >> > index c8946cf3a268..2868ef4c74ef 100644 >> > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts >> > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts >> > @@ -15,6 +15,8 @@ >> > >> > aliases { >> > serial0 = &uart0; >> > + ethernet0=&gmac0; >> > + ethernet1=&gmac1; >> >> Please match the whitespace usage of the existing entry. >> >> > }; >> > >> > chosen { >> > @@ -114,3 +116,47 @@ >> > pinctrl-0 = <&uart0_pins>; >> > status = "okay"; >> > }; >> > + >> > +&gmac0 { >> > + status = "okay"; >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + phy-handle = <&phy0>; >> > + status = "okay"; >> > + mdio0 { >> >> A line of whitespace before the child nodes too please :) >> >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + compatible = "snps,dwmac-mdio"; >> > + phy0: ethernet-phy@0 { >> > + reg = <0>; >> > + rxc_dly_en = <1>; >> > + tx_delay_sel_fe = <5>; >> > + tx_delay_sel = <0xa>; >> > + tx_inverted_10 = <0x1>; >> > + tx_inverted_100 = <0x1>; >> > + tx_inverted_1000 = <0x1>; >> > + }; >> > + }; >> > +}; >> > + >> > +&gmac1 { >> > + status = "okay"; >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + phy-handle = <&phy1>; >> > + status = "okay"; >> > + mdio1 { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + compatible = "snps,dwmac-mdio"; >> > + phy1: ethernet-phy@1 { >> > + reg = <1>; >> > + tx_delay_sel_fe = <5>; >> > + tx_delay_sel = <0>; >> > + rxc_dly_en = <0>; >> > + tx_inverted_10 = <0x1>; >> > + tx_inverted_100 = <0x1>; >> > + tx_inverted_1000 = <0x0>; >> > + }; >> > + }; >> > +}; >> > -- >> > 2.17.1 >> >