From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59610C77B76 for ; Fri, 14 Apr 2023 15:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230325AbjDNP36 (ORCPT ); Fri, 14 Apr 2023 11:29:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbjDNP3x (ORCPT ); Fri, 14 Apr 2023 11:29:53 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7571AAF38; Fri, 14 Apr 2023 08:29:30 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id eo6-20020a05600c82c600b003ee5157346cso12148903wmb.1; Fri, 14 Apr 2023 08:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681486169; x=1684078169; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HtvEF7ctih6jlBUmz6x/cmRorGRIdeQUmzhDbFqzUMQ=; b=qGZQxhLElmhzJf9nLKo4r6pq51rc+4IyPDfzuvQ3gAUsJ6/Y65MzYa6I9BK0cz9KNF stVUm/P2RdtVbOU1aGZISu5RMETCa/RffUliJ/MLHAEFLdSbyckAoXSVsH6b9egMRFIX TgVSJX6L1Sg9SQ1eoWC/gn+tM235APmaoraCI2vruVNVLxcPKdTNrq841NStrTlE2/p1 wn7pTiP/S1Sy9RZ3VuwaDcRD92ap89W6450zE890yMDyXbzlcfczRj1CUBKYWmwMA9la OHvDTRrPJPEIwLRPvasejlfJEFC2FhHQ95rmoy2cI6HgM8WEm8kENox7BXc2E+oOIXVK BoMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681486169; x=1684078169; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HtvEF7ctih6jlBUmz6x/cmRorGRIdeQUmzhDbFqzUMQ=; b=P6/PY+yCc6sorVTgfBgmuJ5M7zdPI3jspOcGYoosPJKAbx3yDHPhlupm4xDQxTtikx +mqz3lNeFRNSLwpIf7RghSOBR2SjCmmymA7uiROCSs8pmAIChfJYqI5PMbf3b2qlGLhE Lc0hmm8J0f21w0I6qlJJe2W76y9B+TE6uGf289rrl1o3V7sH6A9YXarXCr7X/f58LH0a PsYZU7YWXixKslO/IvI7kJvCnlxwqbmlGdeNMmHLhw1DL9oWXijc8/NzMKCZxSL7SOco Y6+07APk4H9EDMLVP0+7xEE+Mi2UxkQ1gQS9VdSNt6eiDYptiwyTonSnQo+pPJdFiX6Q D7jw== X-Gm-Message-State: AAQBX9ei+2CzTXa0s2T71fDSo4ZEQXC/cmg8emrha/YXdXyv6b+PMbOy IZVvHn0jyPspi2VCmRS5+6o= X-Google-Smtp-Source: AKy350baTmaodBGZvLaW/t3L808sxui2s3mXy0yd4/BPSh2Or7HSibikk/nbTxRns3ESdPZBy2bm3g== X-Received: by 2002:a05:600c:2904:b0:3ee:3df6:e411 with SMTP id i4-20020a05600c290400b003ee3df6e411mr4750042wmd.28.1681486168723; Fri, 14 Apr 2023 08:29:28 -0700 (PDT) Received: from [192.168.2.177] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id i8-20020a05600c354800b003f15e5a16b1sm880791wmq.30.2023.04.14.08.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 08:29:27 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 17:29:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 2/6] dt-bindings: hypervisor: Add binding for MediaTek GenieZone hypervisor Content-Language: en-US To: =?UTF-8?B?WWktRGUgV3UgKOWQs+S4gOW+tyk=?= , "corbet@lwn.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski@linaro.org" , "catalin.marinas@arm.com" , "krzysztof.kozlowski+dt@linaro.org" , =?UTF-8?B?WWluZ3NoaXVhbiBQYW4gKOa9mOepjui7kik=?= , "angelogioacchino.delregno@collabora.com" , "will@kernel.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?TVkgQ2h1YW5nICjojormmI7ouo0p?= , "devicetree@vger.kernel.org" , =?UTF-8?B?UGVpTHVuIFN1ZWkgKOmai+WfueWAqyk=?= , =?UTF-8?B?TGlqdS1jbHIgQ2hlbiAo6Zmz6bqX5aaCKQ==?= , =?UTF-8?B?SmFkZXMgU2hpaCAo5pa95ZCR546oKQ==?= , "dbrazdil@google.com" , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?U2hhd24gSHNpYW8gKOiVreW/l+elpSk=?= , =?UTF-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , "linux-doc@vger.kernel.org" , =?UTF-8?B?SXZhbiBUc2VuZyAo5pu+5b+X6LuSKQ==?= , =?UTF-8?B?WmUteXUgV2FuZyAo546L5r6k5a6HKQ==?= References: <20230413090735.4182-1-yi-de.wu@mediatek.com> <20230413090735.4182-3-yi-de.wu@mediatek.com> <8ace9b0f-742a-7ebc-555f-1f8be04a5955@linaro.org> <7b4492efa4a1becbdfb79d23a0a0c0fe11dba5f4.camel@mediatek.com> From: Matthias Brugger In-Reply-To: <7b4492efa4a1becbdfb79d23a0a0c0fe11dba5f4.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2023 10:35, Yi-De Wu (吳一德) wrote: > On Thu, 2023-04-13 at 15:05 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 13/04/2023 11:07, Yi-De Wu wrote: >>> From: "Yingshiuan Pan" >>> >>> Add documentation for GenieZone(gzvm) node. This node informs gzvm >>> driver to start probing if geniezone hypervisor is available and >> >> Subject: drop second/last, redundant "binding for". The "dt-bindings" >> prefix is already stating that these are bindings. >> > Thank you for the review comments. We would remove the "binding for" > wording in the subject on the next version. > >>> able to do virtual machine operations. >>> >>> Signed-off-by: Yingshiuan Pan >>> Signed-off-by: Yi-De Wu >>> --- >>> .../bindings/hypervisor/mediatek,gzvm.yaml | 30 >>> +++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml >>> b/Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml >>> new file mode 100644 >>> index 000000000000..35e1e5b18e47 >>> --- /dev/null >>> +++ >>> b/Documentation/devicetree/bindings/hypervisor/mediatek,gzvm.yaml >>> @@ -0,0 +1,30 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: >>> https://urldefense.com/v3/__http://devicetree.org/schemas/hypervisor/mediatek,gzvm.yaml*__;Iw!!CTRNKA9wMg0ARbw!lp4d4WBp26cpOeEGcKn_aHcNGfyl1Y--BYzfR8oR_0Xzr9TLvUELfOQAAdqHlLIOra1W_QdjVSJv0-HMpLesJmA3TPJSag$ >>> +$schema: >>> https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lp4d4WBp26cpOeEGcKn_aHcNGfyl1Y--BYzfR8oR_0Xzr9TLvUELfOQAAdqHlLIOra1W_QdjVSJv0-HMpLesJmDSXil_Qw$ >>> + >>> +title: MediaTek GenieZone hypervisor >>> + >>> +maintainers: >>> + - Yingshiuan Pan >>> + >>> +description: >>> + GenieZone is MediaTek proprietary hypervisor. This device node >>> informs its >>> + driver, gzvm, to probe if platform supports running virtual >>> machines. >> >> Do not describe Linux, we all know how driver binding works, but >> hardware/firmware/hypervisor. >> > Noted. We would enhance the description on next version. > >> I don't know if we actually want to support proprietary hypervisors. >> There can be hundreds of them, one per each SoC manufacturer, and >> they >> can come with many ridiculous ideas. >> > MediaTek, as a partner of Android, our GenieZone hypervisor has been > one of the backend options under Android Virtualization Framework(AVF) > now. > Thus, we'd like to donate these patches for better supporting the > Linux/Android ecosystem. > > Reference link: https://crosvm.dev/book/hypervisors.html#geniezone > What is the difference between geniezone and gunyah? Why will we need both of them? Couldn't we just get one hypervisor implementation merged that includes all the needed features. In the end it will be used with the same VMM. Regards, Matthias >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,gzvm >>> + >>> +required: >>> + - compatible >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + hypervisor { >>> + compatible = "mediatek,gzvm"; >>> + status = "okay"; >> >> Drop status. >> >> Best regards, >> Krzysztof >>