From: Philipp Zabel <p.zabel@pengutronix.de>
To: Rob Herring <robh@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: dt-bindings: coda: Add missing 'additionalProperties'
Date: Thu, 03 Dec 2020 16:57:28 +0100 [thread overview]
Message-ID: <a306bc26edf7d3b009126859a96750cda2c1160c.camel@pengutronix.de> (raw)
In-Reply-To: <9147a168f368e7ed4e25f155c03394421b74511c.camel@pengutronix.de>
On Thu, 2020-12-03 at 16:51 +0100, Philipp Zabel wrote:
> On Tue, 2020-11-17 at 14:07 -0600, Rob Herring wrote:
> > 'additionalProperties' is now required by the meta-schema. Add it for
> > coda. As a result, 'interrupts', 'interrupt-names' and 'power-domains'
> > need to be reworked to be defined at the top level.
> >
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: linux-media@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > .../devicetree/bindings/media/coda.yaml | 42 +++++++++----------
> > 1 file changed, 21 insertions(+), 21 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml
> > index 7bac0057faf7..36781ee4617f 100644
> > --- a/Documentation/devicetree/bindings/media/coda.yaml
> > +++ b/Documentation/devicetree/bindings/media/coda.yaml
> > @@ -44,6 +44,21 @@ properties:
> > - const: per
> > - const: ahb
> >
> > + interrupts:
> > + minItems: 1
> > + items:
> > + - description: BIT processor interrupt
> > + - description: JPEG unit interrupt
> > +
> > + interrupt-names:
> > + minItems: 1
> > + items:
> > + - const: bit
> > + - const: jpeg
>
> I understand this would require a property
>
> interrupt-names = "bit";
>
> in the arch/arm/boot/dts/imx{27,51,53}.dtsi device trees.
> That property is currently not required nor present, with only one
> interrupt on those devices. Is it possible to set "minItems: 0"?
Never mind, sorry for the noise. interrupt-names is still not required.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2020-12-03 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 20:07 [PATCH v2] media: dt-bindings: coda: Add missing 'additionalProperties' Rob Herring
2020-12-03 15:10 ` Rob Herring
2020-12-03 15:51 ` Philipp Zabel
2020-12-03 15:57 ` Philipp Zabel [this message]
2020-12-18 21:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a306bc26edf7d3b009126859a96750cda2c1160c.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).