From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA4DC4361A for ; Thu, 3 Dec 2020 15:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B67BC207AA for ; Thu, 3 Dec 2020 15:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbgLCP6N convert rfc822-to-8bit (ORCPT ); Thu, 3 Dec 2020 10:58:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgLCP6N (ORCPT ); Thu, 3 Dec 2020 10:58:13 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30B8AC061A4E for ; Thu, 3 Dec 2020 07:57:33 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkqz2-0003yW-G6; Thu, 03 Dec 2020 16:57:28 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kkqz2-00008A-41; Thu, 03 Dec 2020 16:57:28 +0100 Message-ID: Subject: Re: [PATCH v2] media: dt-bindings: coda: Add missing 'additionalProperties' From: Philipp Zabel To: Rob Herring , Mauro Carvalho Chehab Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org Date: Thu, 03 Dec 2020 16:57:28 +0100 In-Reply-To: <9147a168f368e7ed4e25f155c03394421b74511c.camel@pengutronix.de> References: <20201117200752.4004368-1-robh@kernel.org> <9147a168f368e7ed4e25f155c03394421b74511c.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 2020-12-03 at 16:51 +0100, Philipp Zabel wrote: > On Tue, 2020-11-17 at 14:07 -0600, Rob Herring wrote: > > 'additionalProperties' is now required by the meta-schema. Add it for > > coda. As a result, 'interrupts', 'interrupt-names' and 'power-domains' > > need to be reworked to be defined at the top level. > > > > Cc: Philipp Zabel > > Cc: Mauro Carvalho Chehab > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > .../devicetree/bindings/media/coda.yaml | 42 +++++++++---------- > > 1 file changed, 21 insertions(+), 21 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml > > index 7bac0057faf7..36781ee4617f 100644 > > --- a/Documentation/devicetree/bindings/media/coda.yaml > > +++ b/Documentation/devicetree/bindings/media/coda.yaml > > @@ -44,6 +44,21 @@ properties: > > - const: per > > - const: ahb > > > > + interrupts: > > + minItems: 1 > > + items: > > + - description: BIT processor interrupt > > + - description: JPEG unit interrupt > > + > > + interrupt-names: > > + minItems: 1 > > + items: > > + - const: bit > > + - const: jpeg > > I understand this would require a property > > interrupt-names = "bit"; > > in the arch/arm/boot/dts/imx{27,51,53}.dtsi device trees. > That property is currently not required nor present, with only one > interrupt on those devices. Is it possible to set "minItems: 0"? Never mind, sorry for the noise. interrupt-names is still not required. Reviewed-by: Philipp Zabel regards Philipp