From: neil.armstrong@linaro.org
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
Kalle Valo <kvalo@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 06/12] remoteproc: qcom_q6v5_pas: switch to mbn files by default
Date: Tue, 21 May 2024 11:49:42 +0200 [thread overview]
Message-ID: <a314906d-b297-474d-910c-6634c8c23042@linaro.org> (raw)
In-Reply-To: <20240521-qcom-firmware-name-v1-6-99a6d32b1e5e@linaro.org>
On 21/05/2024 11:45, Dmitry Baryshkov wrote:
> We have been pushing userspace to use mbn files by default for ages.
> As a preparation for making the firmware-name optional, make the driver
> use .mbn instead of .mdt files by default.
I think we should have a mechanism to fallback to .mdt since downstream
uses split mdt on the devices filesystem.
Perhaps only specify .firmware_name = "adsp" and add a list of allowed extension
it will try in a loop ?
Neil
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 76 +++++++++++++++++++-------------------
> 1 file changed, 38 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 54d8005d40a3..4694ec4f038d 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -812,7 +812,7 @@ static void adsp_remove(struct platform_device *pdev)
>
> static const struct adsp_data adsp_resource_init = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .ssr_name = "lpass",
> @@ -822,7 +822,7 @@ static const struct adsp_data adsp_resource_init = {
>
> static const struct adsp_data sdm845_adsp_resource_init = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .load_state = "adsp",
> @@ -833,7 +833,7 @@ static const struct adsp_data sdm845_adsp_resource_init = {
>
> static const struct adsp_data sm6350_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -849,7 +849,7 @@ static const struct adsp_data sm6350_adsp_resource = {
>
> static const struct adsp_data sm6375_mpss_resource = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> + .firmware_name = "modem.mbn",
> .pas_id = 4,
> .minidump_id = 3,
> .auto_boot = false,
> @@ -864,7 +864,7 @@ static const struct adsp_data sm6375_mpss_resource = {
>
> static const struct adsp_data sm8150_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -879,7 +879,7 @@ static const struct adsp_data sm8150_adsp_resource = {
>
> static const struct adsp_data sm8250_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -895,7 +895,7 @@ static const struct adsp_data sm8250_adsp_resource = {
>
> static const struct adsp_data sm8350_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -911,7 +911,7 @@ static const struct adsp_data sm8350_adsp_resource = {
>
> static const struct adsp_data msm8996_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> + .firmware_name = "adsp.mbn",
> .pas_id = 1,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -925,7 +925,7 @@ static const struct adsp_data msm8996_adsp_resource = {
>
> static const struct adsp_data cdsp_resource_init = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .ssr_name = "cdsp",
> @@ -935,7 +935,7 @@ static const struct adsp_data cdsp_resource_init = {
>
> static const struct adsp_data sdm845_cdsp_resource_init = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .load_state = "cdsp",
> @@ -946,7 +946,7 @@ static const struct adsp_data sdm845_cdsp_resource_init = {
>
> static const struct adsp_data sm6350_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -962,7 +962,7 @@ static const struct adsp_data sm6350_cdsp_resource = {
>
> static const struct adsp_data sm8150_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -977,7 +977,7 @@ static const struct adsp_data sm8150_cdsp_resource = {
>
> static const struct adsp_data sm8250_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -992,7 +992,7 @@ static const struct adsp_data sm8250_cdsp_resource = {
>
> static const struct adsp_data sc8280xp_nsp0_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1006,7 +1006,7 @@ static const struct adsp_data sc8280xp_nsp0_resource = {
>
> static const struct adsp_data sc8280xp_nsp1_resource = {
> .crash_reason_smem = 633,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 30,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1020,8 +1020,8 @@ static const struct adsp_data sc8280xp_nsp1_resource = {
>
> static const struct adsp_data x1e80100_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> - .dtb_firmware_name = "adsp_dtb.mdt",
> + .firmware_name = "adsp.mbn",
> + .dtb_firmware_name = "adsp_dtb.mbn",
> .pas_id = 1,
> .dtb_pas_id = 0x24,
> .lite_pas_id = 0x1f,
> @@ -1040,8 +1040,8 @@ static const struct adsp_data x1e80100_adsp_resource = {
>
> static const struct adsp_data x1e80100_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> - .dtb_firmware_name = "cdsp_dtb.mdt",
> + .firmware_name = "cdsp.mbn",
> + .dtb_firmware_name = "cdsp_dtb.mbn",
> .pas_id = 18,
> .dtb_pas_id = 0x25,
> .minidump_id = 7,
> @@ -1060,7 +1060,7 @@ static const struct adsp_data x1e80100_cdsp_resource = {
>
> static const struct adsp_data sm8350_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> + .firmware_name = "cdsp.mbn",
> .pas_id = 18,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1076,7 +1076,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
>
> static const struct adsp_data mpss_resource_init = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> + .firmware_name = "modem.mbn",
> .pas_id = 4,
> .minidump_id = 3,
> .auto_boot = false,
> @@ -1093,7 +1093,7 @@ static const struct adsp_data mpss_resource_init = {
>
> static const struct adsp_data sc8180x_mpss_resource = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> + .firmware_name = "modem.mbn",
> .pas_id = 4,
> .auto_boot = false,
> .proxy_pd_names = (char*[]){
> @@ -1108,7 +1108,7 @@ static const struct adsp_data sc8180x_mpss_resource = {
>
> static const struct adsp_data msm8996_slpi_resource_init = {
> .crash_reason_smem = 424,
> - .firmware_name = "slpi.mdt",
> + .firmware_name = "slpi.mbn",
> .pas_id = 12,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1122,7 +1122,7 @@ static const struct adsp_data msm8996_slpi_resource_init = {
>
> static const struct adsp_data sdm845_slpi_resource_init = {
> .crash_reason_smem = 424,
> - .firmware_name = "slpi.mdt",
> + .firmware_name = "slpi.mbn",
> .pas_id = 12,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1138,7 +1138,7 @@ static const struct adsp_data sdm845_slpi_resource_init = {
>
> static const struct adsp_data wcss_resource_init = {
> .crash_reason_smem = 421,
> - .firmware_name = "wcnss.mdt",
> + .firmware_name = "wcnss.mbn",
> .pas_id = 6,
> .auto_boot = true,
> .ssr_name = "mpss",
> @@ -1148,7 +1148,7 @@ static const struct adsp_data wcss_resource_init = {
>
> static const struct adsp_data sdx55_mpss_resource = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> + .firmware_name = "modem.mbn",
> .pas_id = 4,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1163,7 +1163,7 @@ static const struct adsp_data sdx55_mpss_resource = {
>
> static const struct adsp_data sm8450_mpss_resource = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> + .firmware_name = "modem.mbn",
> .pas_id = 4,
> .minidump_id = 3,
> .auto_boot = false,
> @@ -1181,8 +1181,8 @@ static const struct adsp_data sm8450_mpss_resource = {
>
> static const struct adsp_data sm8550_adsp_resource = {
> .crash_reason_smem = 423,
> - .firmware_name = "adsp.mdt",
> - .dtb_firmware_name = "adsp_dtb.mdt",
> + .firmware_name = "adsp.mbn",
> + .dtb_firmware_name = "adsp_dtb.mbn",
> .pas_id = 1,
> .dtb_pas_id = 0x24,
> .minidump_id = 5,
> @@ -1200,8 +1200,8 @@ static const struct adsp_data sm8550_adsp_resource = {
>
> static const struct adsp_data sm8550_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> - .dtb_firmware_name = "cdsp_dtb.mdt",
> + .firmware_name = "cdsp.mbn",
> + .dtb_firmware_name = "cdsp_dtb.mbn",
> .pas_id = 18,
> .dtb_pas_id = 0x25,
> .minidump_id = 7,
> @@ -1220,8 +1220,8 @@ static const struct adsp_data sm8550_cdsp_resource = {
>
> static const struct adsp_data sm8550_mpss_resource = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> - .dtb_firmware_name = "modem_dtb.mdt",
> + .firmware_name = "modem.mbn",
> + .dtb_firmware_name = "modem_dtb.mbn",
> .pas_id = 4,
> .dtb_pas_id = 0x26,
> .minidump_id = 3,
> @@ -1243,7 +1243,7 @@ static const struct adsp_data sm8550_mpss_resource = {
>
> static const struct adsp_data sc7280_wpss_resource = {
> .crash_reason_smem = 626,
> - .firmware_name = "wpss.mdt",
> + .firmware_name = "wpss.mbn",
> .pas_id = 6,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> @@ -1259,8 +1259,8 @@ static const struct adsp_data sc7280_wpss_resource = {
>
> static const struct adsp_data sm8650_cdsp_resource = {
> .crash_reason_smem = 601,
> - .firmware_name = "cdsp.mdt",
> - .dtb_firmware_name = "cdsp_dtb.mdt",
> + .firmware_name = "cdsp.mbn",
> + .dtb_firmware_name = "cdsp_dtb.mbn",
> .pas_id = 18,
> .dtb_pas_id = 0x25,
> .minidump_id = 7,
> @@ -1283,8 +1283,8 @@ static const struct adsp_data sm8650_cdsp_resource = {
>
> static const struct adsp_data sm8650_mpss_resource = {
> .crash_reason_smem = 421,
> - .firmware_name = "modem.mdt",
> - .dtb_firmware_name = "modem_dtb.mdt",
> + .firmware_name = "modem.mbn",
> + .dtb_firmware_name = "modem_dtb.mbn",
> .pas_id = 4,
> .dtb_pas_id = 0x26,
> .minidump_id = 3,
>
next prev parent reply other threads:[~2024-05-21 9:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 9:45 [PATCH 00/12] arm64: qcom: autodetect firmware paths Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 01/12] soc: qcom: add firmware name helper Dmitry Baryshkov
2024-05-21 9:52 ` neil.armstrong
2024-05-21 10:01 ` Dmitry Baryshkov
2024-05-21 11:20 ` Kalle Valo
2024-05-21 13:08 ` Dmitry Baryshkov
2024-05-22 22:48 ` Bjorn Andersson
2024-05-27 11:42 ` Dmitry Baryshkov
2024-05-29 2:28 ` Bjorn Andersson
2024-05-31 18:48 ` Kalle Valo
2024-05-21 9:45 ` [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-31 18:53 ` Kalle Valo
2024-05-21 9:45 ` [PATCH 03/12] soc: qcom: wcnss_ctrl: " Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 04/12] remoteproc: qcom_q6v5_mss: switch to mbn files by default Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 05/12] remoteproc: qcom_q6v5_mss: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 06/12] remoteproc: qcom_q6v5_pas: switch to mbn files by default Dmitry Baryshkov
2024-05-21 9:49 ` neil.armstrong [this message]
2024-05-21 10:01 ` Dmitry Baryshkov
2024-05-21 19:40 ` Bjorn Andersson
2024-05-21 9:45 ` [PATCH 07/12] remoteproc: qcom_q6v5_pas: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 08/12] remoteproc: qcom_wcnss: switch to mbn files by default Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 09/12] remoteproc: qcom_wcnss: make use of QCOM_FW_HELPER Dmitry Baryshkov
2024-05-22 19:21 ` Jeff Johnson
2024-05-22 20:42 ` Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 10/12] " Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 11/12] arm64: dts: qcom: apq8016-sbc: drop firmware-name properties Dmitry Baryshkov
2024-05-21 9:45 ` [PATCH 12/12] arm64: dts: qcom: apq8096-db820c: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a314906d-b297-474d-910c-6634c8c23042@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).