From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60084C33C9E for ; Mon, 6 Jan 2020 17:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 369692081E for ; Mon, 6 Jan 2020 17:12:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="sb3amGNi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgAFRM4 (ORCPT ); Mon, 6 Jan 2020 12:12:56 -0500 Received: from vern.gendns.com ([98.142.107.122]:55024 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgAFRM4 (ORCPT ); Mon, 6 Jan 2020 12:12:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fHCqKA80u5NASV1pLYpW+PomktqDzS5QR7r7N/IPo38=; b=sb3amGNiUMrG1Mw6I+zMFN1zVA hrKr9c5nliKBR1ayEo3c9fXAYHrBczY0oOc8ALP754zGq32oWLDRzDKS7wvHsgCj7b7w+VahOf3FH GGpQYXUEJrNH5MPcPfrUzBJRG7AJoFftYfCJlpXKbEkBQ6/UnxU1bQWYZHigdMrVEImNIC/SoZjB7 7Olxxsq8zzeQKNKjvgr0cjXsyv0kSLah4I0Tb0D/Krv0TrW3idm6vxy2VV5hzcSICwg28s+xSBIzq EXEoE7kJ7CtoUuYF0OQbVq538RUnaxp7wZkEQSMAAvMRARbBX0E1oembH6gYiGsR6ovjtmnm446fW UxyXzHZw==; Received: from [2600:1700:4830:165f::fb2] (port=55016) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1ioVXp-0002In-F0; Mon, 06 Jan 2020 11:47:57 -0500 Subject: Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t To: Sam Ravnborg , Geert Uytterhoeven Cc: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Rob Herring , Mark Rutland , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Chris Brandt , dri-devel@lists.freedesktop.org References: <20200102141246.370-1-geert+renesas@glider.be> <20200102141246.370-2-geert+renesas@glider.be> <20200102144636.GA10075@ravnborg.org> From: David Lechner Message-ID: Date: Mon, 6 Jan 2020 10:47:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200102144636.GA10075@ravnborg.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1/2/20 8:46 AM, Sam Ravnborg wrote: > Hi Geert. > > On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote: >> Document support for the Okaya RH128128T display, which is a 128x128 >> 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. >> >> ST7715R and ST7735R are very similar. Their major difference is that >> the former is restricted to displays of up to 132x132 pixels, while the >> latter supports displays up to 132x162 pixels. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> .../devicetree/bindings/display/sitronix,st7735r.txt | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> index cd5c7186890a2be7..87ebdcb294e29798 100644 >> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt >> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt > While touching the bindings file, can I convince you to convert it to > meta-schema format (.yaml)? > > >> @@ -4,7 +4,9 @@ This binding is for display panels using a Sitronix ST7735R controller in SPI >> mode. >> >> Required properties: >> -- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r" >> +- compatible: Must be one of the following combinations: >> + - "jianda,jd-t18003-t01", "sitronix,st7735r" >> + - "okaya,rh128128t", "sitronix,st7715r" > > It would be nice if there was a "description" for each pair of > compatible that identified the actual panel. > In your case "Okaya RH128128T 1.44" 128x128 TFT display" > It can be looked up in git history - but better to have it in the > binding file. > > Sam > It would be nice to have the Adafruit part name in here too while we are at it. I had to dig really deep to find what the actual display panel was. https://www.adafruit.com/product/358 https://www.adafruit.com/product/618