From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27652EB64DD for ; Wed, 12 Jul 2023 08:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229536AbjGLIDl (ORCPT ); Wed, 12 Jul 2023 04:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231260AbjGLIDK (ORCPT ); Wed, 12 Jul 2023 04:03:10 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520C61989 for ; Wed, 12 Jul 2023 01:02:02 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fc0aecf15bso40769695e9.1 for ; Wed, 12 Jul 2023 01:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1689148921; x=1691740921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YkIwyBsrrasbrw6SKcJzFKY+sZkplhIF1ednI0kruDo=; b=bDSyjqZU/kFai51bS4zMV7wkn6IN8baUYkKTFjyQ9VhethzeBGEkbszBcepIHQbhX/ SR/g8PJirC6plcC2OT3jO68NN6EISfhUEmvt1ZcYlS/KOUSkMDDyzznSdhUpivM0iJrQ 13i1l9cefjz5I67sRJQjmQxF2fa4P6dQ1xUf9knjRn5qTZv38166mojcNDNcHvXl6FfO ZPLuDOoK4MudT/YUB8wSHQ5pU5Z1S1Uo9G9e864mQVzsIieIc4ZhlEWbw2DVMhPKZv+y 9pxVVcRTZpHSUgTEL4Ayjp11/BWLsAVT7lgVUza3wY3VczprtRt4N1StlWKYkVsvVF/d dVMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689148921; x=1691740921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YkIwyBsrrasbrw6SKcJzFKY+sZkplhIF1ednI0kruDo=; b=hxaqb2YUgWhJysL0G++UAQ4jySJKBhJhTfZNnN4ilocEAdc+tvLOPhwYTRp0tDqimu uQTAWQIWGhSTo7wvsAGrrJOHb7yxyqF9QqazFie+YYQAXSV5h9EULeRy7intyYNGid3R nzFbioZgLryCgE8kFWNUUdiqbrdOt+ioXxY37Y8zk4Pi+j8+55zyvl0kUt1xF7Wc8nia RTNuEgDmtezO6IAxnTcS36USkpxpK7SGgnM8mbZog3FvaupfqaSwY6IVzycUV6OFMVpP zX9CHqU2Yb8LRH1P40mFzCL+tE2DJMoGtQmYfXJY2kpcyPgsPJvCsSqxS3XzOuF+0UWq t07A== X-Gm-Message-State: ABy/qLbx1B9Sg6OxD4itHItc+wpHii+MfZn5u3c3pqzK3v1WMNSHsiCF l22V/EM8DxcXwmJStJzo44oGzaj6bILNDNPO9wg= X-Google-Smtp-Source: APBJJlFBDoZQA2YW3Bxt2cfhjxIimssHNv6+Ox3A25mufenbLcs3GAodp0BeuMoLjGNPDIVyI6916Q== X-Received: by 2002:a1c:ed10:0:b0:3fb:b008:2002 with SMTP id l16-20020a1ced10000000b003fbb0082002mr18164102wmh.0.1689148920442; Wed, 12 Jul 2023 01:02:00 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id g23-20020a7bc4d7000000b003fc02a410d0sm12536303wmk.48.2023.07.12.01.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 01:02:00 -0700 (PDT) Message-ID: Date: Wed, 12 Jul 2023 10:01:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support To: Krzysztof Kozlowski , Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon Cc: Guillaume La Roque , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230711-startek_display-v1-0-163917bed385@baylibre.com> <20230711-startek_display-v1-1-163917bed385@baylibre.com> <14bed951-22ae-4aa8-5fcb-b2cd92ebdbef@linaro.org> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <14bed951-22ae-4aa8-5fcb-b2cd92ebdbef@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, Thanks for your review On 12/07/2023 07:32, Krzysztof Kozlowski wrote: > On 11/07/2023 17:36, Alexandre Mergnat wrote: >> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution snip >> + >> + dcdc-gpios: true > > From where does this come? Which schema defines it? It's a miss. I will fix it and reset-gpios too by adding a maxItems and a description. >> + >> + height-mm: >> + const: 151 >> + >> + iovcc-supply: >> + description: Reference to the regulator powering the panel IO pins. >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + reset-gpios: true >> + >> + port: true >> + >> + power-supply: true >> + >> + width-mm: >> + const: 95 >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - dcdc-gpios >> + - iovcc-supply >> + - reg >> + - reset-gpios >> + - port >> + - power-supply > > Missing example. I will add it. -- Regards, Alexandre