From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>, Andre Kalb <Andre.Kalb@sma.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] of: __of_update_property_sysfs only call __of_sysfs_remove_bin_file if of_node_is_attached
Date: Wed, 26 Sep 2018 18:35:56 -0700 [thread overview]
Message-ID: <a3374cea-32b7-92e8-21a3-8bc14ed5ee2e@gmail.com> (raw)
In-Reply-To: <20180926210537.GA3143@bogus>
On 09/26/18 14:05, Rob Herring wrote:
> On Thu, Sep 13, 2018 at 03:21:27PM +0000, Andre Kalb wrote:
>> Hi Rob,
>>
>> I have used an other hardware to check the patch. I hope it doesn’t matter. I added few lines at the untitest.c. All existing unittest use an attached sysfs, therefore the bug isn't detectable.
>
> Okay, can you resend both patches in one series rather than pasted in
> here.
>
> Rob
I don't understand the need for the patch to __of_update_property_sysfs()
in the context of the current mainline Linux kernel.
As far as I know, there are no callers of of_update_property() against
a tree that is detached. As such, the patch is adding complexity
without adding any functionality.
-Frank
next prev parent reply other threads:[~2018-09-27 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 15:51 [PATCH v2] of: __of_update_property_sysfs only call __of_sysfs_remove_bin_file if of_node_is_attached Andre Kalb
2018-09-07 20:00 ` Frank Rowand
2018-09-10 9:47 ` AW: " Andre Kalb
2018-09-10 13:46 ` Rob Herring
2018-09-13 15:21 ` AW: " Andre Kalb
2018-09-26 21:05 ` Rob Herring
2018-09-27 1:35 ` Frank Rowand [this message]
2018-09-19 9:25 ` Andre Kalb
-- strict thread matches above, loose matches on Subject: below --
2018-09-17 7:42 Andre Kalb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3374cea-32b7-92e8-21a3-8bc14ed5ee2e@gmail.com \
--to=frowand.list@gmail.com \
--cc=Andre.Kalb@sma.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).