From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dennis Lambe Jr <dennis@sparkcharge.io>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, Alexander Bigga <ab@mycable.de>
Subject: Re: [PATCH 2/3] dt-bindings: m41t80: add xtal load capacitance
Date: Tue, 20 Dec 2022 11:52:02 +0100 [thread overview]
Message-ID: <a3414477-eb9b-83ee-ab11-b2b629b6d23b@linaro.org> (raw)
In-Reply-To: <20221219190915.3912384-3-dennis@sparkcharge.io>
On 19/12/2022 20:09, Dennis Lambe Jr wrote:
> The ST m41t82 and m41t83 support programmable load capacitance from 3.5
> pF to 17.4 pF. The hardware defaults to 12.5 pF.
>
> The accuracy of the xtal can be calibrated precisely by adjusting the
> load capacicance.
>
> Add default, minimum, and maximum for the standard rtc property
> quartz-load-femtofarads on compatible devices.
>
> Signed-off-by: Dennis Lambe Jr <dennis@sparkcharge.io>
> ---
> .../devicetree/bindings/rtc/st,m41t80.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml
> index fc9c6da6483f..6b72580dc031 100644
> --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml
> +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml
> @@ -33,6 +33,11 @@ properties:
> "#clock-cells":
> const: 1
>
> + quartz-load-femtofarads:
> + default: 12500
> + minimum: 3500
> + maximum: 17375
> +
> clock-output-names:
> maxItems: 1
> description: From common clock binding to override the default output clock name.
> @@ -44,8 +49,21 @@ properties:
> clock-frequency:
> const: 32768
>
> + wakeup-source: true
Why do you need it here? It's already accepted in rtc.yaml. Adding it is
not explained in commit msg.
> +
> allOf:
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-20 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:09 [PATCH 0/3] rtc: m41t80: set xtal load capacitance from DT Dennis Lambe Jr
2022-12-19 19:09 ` [PATCH 1/3] rtc: m41t80: probe: use IS_ENABLED for CONFIG_OF Dennis Lambe Jr
2022-12-19 19:09 ` [PATCH 2/3] dt-bindings: m41t80: add xtal load capacitance Dennis Lambe Jr
2022-12-20 10:52 ` Krzysztof Kozlowski [this message]
2022-12-20 15:43 ` Dennis Lambe
2022-12-19 19:09 ` [PATCH 3/3] rtc: m41t80: set xtal load capacitance from DT Dennis Lambe Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3414477-eb9b-83ee-ab11-b2b629b6d23b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=ab@mycable.de \
--cc=alexandre.belloni@bootlin.com \
--cc=dennis@sparkcharge.io \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).