From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3690FC4167B for ; Tue, 20 Dec 2022 10:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233425AbiLTKwS (ORCPT ); Tue, 20 Dec 2022 05:52:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233657AbiLTKwG (ORCPT ); Tue, 20 Dec 2022 05:52:06 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A7E0186B2 for ; Tue, 20 Dec 2022 02:52:05 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id m29so17771610lfo.11 for ; Tue, 20 Dec 2022 02:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xhjhk+r4I/urUe50CHvmJaxBj9q3ZzrLGBb8/x9cWjw=; b=N7iPb/8U9sNHulv5n/T/nqtYGRGjrlGEMFOBX/D45ZP8pBDQ4bQn9gpWmqvXZ7SjyA ShmX8Onj+yeLWXIMzWY/slE6G4UgoDzLe5+ETDepQe0pCWjO5t+OZ+dlXQUUPEH1B5pZ lKY2Wk/RbKX1jia06jDA8UsJVXAUCPOozwk3L88tx1JGbt7dsyU4W7mawrqiiECvxWNB 4pFvgp9E3+W/Nv9hEcE9c740Af97tL4s2O6Rm0Lv88JbRX2S21A5jJTtgsvAC39cuBuL FI4kTTD7IjvFfo8XATLf8eyKBD2sY/MKDEY2UjDalSHbh/BlEAx0L4vlRxG1RrpdweNU locg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xhjhk+r4I/urUe50CHvmJaxBj9q3ZzrLGBb8/x9cWjw=; b=Y+OL7gf2M/MxaH1YHV8NHVmbfuQIm4a7+TaWYMqS44R8mhKMjxu2RA4Ey9EeonA11g 7BXY0bcXfBxMG0iRpob3HHgT0P2u7CMEw1HVm9eNRPb79aiLaxmNYDzi5k5BZozvWMft 4ry+fowxuiNAEocfyX8P0VjU1GEVgRqZW6SgYWE9dDYGdhP6WidQvYIEche9YWs1FuRt hr0+yZaF/SXsd+IjLwnV9q6K/kWAK7hISzGbu8zq7gnpE6np+g5kNm3F/lroEQKEUrI9 7ZxS/ZOtv2w9ThjNdElbiOSN0dagLrD/b0ZLxVgYfZGIGmYioHXUS77YWSFegx8FxadJ EVew== X-Gm-Message-State: ANoB5pl9dswKOS4h4RkWJ06/QCd2e+CNSQdbgnW/cXrbbTS+iB54KzVy 3cHOazI13gAgx1azJZJo0R7BJQ== X-Google-Smtp-Source: AA0mqf57xGpbOxVQYqGlY6dApDnrR3iSOA73z3w87Bf1ofEDLxMNEwYRikJWL2oK3oz6tOWmIy39Sg== X-Received: by 2002:a19:6a0f:0:b0:4b5:6db0:d598 with SMTP id u15-20020a196a0f000000b004b56db0d598mr12785985lfu.20.1671533523447; Tue, 20 Dec 2022 02:52:03 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c5-20020a056512074500b004994117b0fdsm1398758lfs.281.2022.12.20.02.52.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:52:03 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 11:52:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/3] dt-bindings: m41t80: add xtal load capacitance Content-Language: en-US To: Dennis Lambe Jr , Alessandro Zummo , Alexandre Belloni , Krzysztof Kozlowski , Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Alexander Bigga References: <20221219190915.3912384-1-dennis@sparkcharge.io> <20221219190915.3912384-3-dennis@sparkcharge.io> From: Krzysztof Kozlowski In-Reply-To: <20221219190915.3912384-3-dennis@sparkcharge.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/12/2022 20:09, Dennis Lambe Jr wrote: > The ST m41t82 and m41t83 support programmable load capacitance from 3.5 > pF to 17.4 pF. The hardware defaults to 12.5 pF. > > The accuracy of the xtal can be calibrated precisely by adjusting the > load capacicance. > > Add default, minimum, and maximum for the standard rtc property > quartz-load-femtofarads on compatible devices. > > Signed-off-by: Dennis Lambe Jr > --- > .../devicetree/bindings/rtc/st,m41t80.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > index fc9c6da6483f..6b72580dc031 100644 > --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > @@ -33,6 +33,11 @@ properties: > "#clock-cells": > const: 1 > > + quartz-load-femtofarads: > + default: 12500 > + minimum: 3500 > + maximum: 17375 > + > clock-output-names: > maxItems: 1 > description: From common clock binding to override the default output clock name. > @@ -44,8 +49,21 @@ properties: > clock-frequency: > const: 32768 > > + wakeup-source: true Why do you need it here? It's already accepted in rtc.yaml. Adding it is not explained in commit msg. > + > allOf: Best regards, Krzysztof