From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E52ECAAD3 for ; Fri, 9 Sep 2022 07:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231700AbiIIHkP (ORCPT ); Fri, 9 Sep 2022 03:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbiIIHjT (ORCPT ); Fri, 9 Sep 2022 03:39:19 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B35F79AFEE for ; Fri, 9 Sep 2022 00:35:52 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id bs13so814473ljb.8 for ; Fri, 09 Sep 2022 00:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=555JM3E3kG8yPe2JWLkJCiVLUYiSpaWOeW349uC31mA=; b=GVP49Aqh8XFH5zTOQOiwICGGzG0Y+YD79RjoInSRl0WHma35J8zZoSogeT3sUx4xoj sp8g1WsO2IDhFqiFIxy4Jk8F08KUwRS50dlbN73jtu8Qsnm7jW6TWMhDNfZjHSPByzqa G/YHbvWVf/4C3rXj1O0V2j01rNtypZXB5vuVIMF8Qz0LlxWYpHcjymO6leVQ3XgxzXfd VVJ4pIswb+b6Lxf8JBUkJIVToCZ+3jBzvzUxgysC23zpD1GFX4XRdmG8RClIfImon4dL EXWxLvQ9/slO3r4DLg/nZMfIVT5qaBDn2At1MIE5JtktTarTgNUn9mmpDlpCRJ1Qs772 h7Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=555JM3E3kG8yPe2JWLkJCiVLUYiSpaWOeW349uC31mA=; b=4sIMoGTprI/m16aS9sK24igCjrQb5ePAbQBPY3836Jp8Hq2GOnLCA27ezqoE229vY7 r6lZ/eStbWTJHH2LwV45R2mNdHHAmfv0kW5fqqep85pxhJlgXGHdpAHbE3jnnN1lv5v9 JcLOqdTsmiu9XhEHvZ+kBTOMwgZbQTqjrwPgtKo+jDsZLW4WeDvJVYcoI0eeZWXwDThc snBP3bm1rK5yVv+N+GLWsIZmRhZVFhe+PvdC6MrPBo2No8/20Ax3OmmkY6Zq629VqTGX gJ3bDStRi8hwC+yDoKc5I+mDP046rqf5fDuxoneaV2EtKPzFFsLkAenNDU4HhhYgFnZh h+Ag== X-Gm-Message-State: ACgBeo2xc1Cq/LMKMj9bzBL27cp0EGEVrvePDD5m9FwAVNJSK40N86mh F6JsUEe4m5YKdcevyXfg2RAqfkmiHnZ19g== X-Google-Smtp-Source: AA6agR5+9OZpQc/apjMdPrSeSbMl1+YhF8ynIZ+NrlpyerosYwA1YdN0TD3MuDYyujc8ahYgwRssfQ== X-Received: by 2002:a2e:7019:0:b0:26b:db2a:577f with SMTP id l25-20020a2e7019000000b0026bdb2a577fmr1678252ljc.105.1662708949663; Fri, 09 Sep 2022 00:35:49 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t23-20020a056512209700b004974da17c2bsm178594lfr.0.2022.09.09.00.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 00:35:49 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 09:35:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/4] pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping Content-Language: en-US To: Anjelique Melendez , agross@kernel.org, bjorn.andersson@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: konrad.dybcio@somainline.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Anirudh Ghayal References: <20220907201528.9351-1-quic_amelende@quicinc.com> <20220907201528.9351-3-quic_amelende@quicinc.com> <2b809e98-85ea-6ad9-e810-106563937ddc@linaro.org> <330b5f46-1bd2-5727-b63c-c730fbdda22c@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <330b5f46-1bd2-5727-b63c-c730fbdda22c@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/09/2022 01:52, Anjelique Melendez wrote: pio.h b/include/dt-bindings/pinctrl/qcom,pmic-gpio.h >>> index e5df5ce45a0f..950be952ad3e 100644 >>> --- a/include/dt-bindings/pinctrl/qcom,pmic-gpio.h >>> +++ b/include/dt-bindings/pinctrl/qcom,pmic-gpio.h >> >> You cannot mix bindings with driver. This is an ABI break. > Ack - Will separate into two changes. >>> @@ -12,9 +12,14 @@ >>> #define PMIC_GPIO_PULL_UP_1P5_30 3 >>> >>> #define PMIC_GPIO_STRENGTH_NO 0 >>> -#define PMIC_GPIO_STRENGTH_HIGH 1 >>> +#define PMIC_GPIO_STRENGTH_LOW 1 >>> #define PMIC_GPIO_STRENGTH_MED 2 >>> -#define PMIC_GPIO_STRENGTH_LOW 3 >>> +#define PMIC_GPIO_STRENGTH_HIGH 3 >> >> Didn't you just break all DTSes in the world? > Ack - lol. Next version will include changes to update any DTS > that uses PMIC_GPIO_STRENGTH_ There is discussion with David, so please wait till consensus is reached. It seems you want to change DT binding constant to match register value which is not appropriate. Constants are not change'able. Constants are abstractions which might or might not match register value. Best regards, Krzysztof