public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox: Document msg region requirement
@ 2025-12-22  4:46 Harini T
  2025-12-22  9:09 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Harini T @ 2025-12-22  4:46 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, michal.simek,
	shubhrajyoti.datta
  Cc: linux-kernel, devicetree, linux-arm-kernel, git, Harini T

Add description clarifying that for Versal IPI mailboxes, both host and
remote agents must have the "msg" register region defined for successful
message passing. Without both, only notification-based communication
works.

Signed-off-by: Harini T <harini.t@amd.com>
---
 .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml           | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
index 04d6473d666f..8fdf77c7935c 100644
--- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
+++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
@@ -165,6 +165,12 @@ allOf:
         reg-names: false
 
     else:
+      description:
+        For Versal IPI mailboxes, the "msg" register region is optional.
+        However, for successful message passing via mailbox, both the host IPI
+        agent and the remote IPI agent must have the "msg" register region
+        defined. If either agent lacks the "msg" field, only notification-based
+        communication (without message buffers) will work.
       properties:
         reg:
           items:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox: Document msg region requirement
  2025-12-22  4:46 [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox: Document msg region requirement Harini T
@ 2025-12-22  9:09 ` Krzysztof Kozlowski
  2025-12-23 10:48   ` T, Harini
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-22  9:09 UTC (permalink / raw)
  To: Harini T
  Cc: jassisinghbrar, robh, krzk+dt, conor+dt, michal.simek,
	shubhrajyoti.datta, linux-kernel, devicetree, linux-arm-kernel,
	git

On Mon, Dec 22, 2025 at 10:16:53AM +0530, Harini T wrote:
> Add description clarifying that for Versal IPI mailboxes, both host and
> remote agents must have the "msg" register region defined for successful
> message passing. Without both, only notification-based communication
> works.
> 
> Signed-off-by: Harini T <harini.t@amd.com>
> ---
>  .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml           | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> index 04d6473d666f..8fdf77c7935c 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> @@ -165,6 +165,12 @@ allOf:
>          reg-names: false
>  
>      else:
> +      description:

Else block cannot have description.

> +        For Versal IPI mailboxes, the "msg" register region is optional.

So it is optional...

> +        However, for successful message passing via mailbox, both the host IPI

And it is not optional. If nothing works, then it is not optional.

And why would it be optional in the first place? You generate your same
IP with different settings?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox: Document msg region requirement
  2025-12-22  9:09 ` Krzysztof Kozlowski
@ 2025-12-23 10:48   ` T, Harini
  2026-02-08 10:36     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: T, Harini @ 2025-12-23 10:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, Simek, Michal, Datta, Shubhrajyoti,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, git (AMD-Xilinx)

[Public]

Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, December 22, 2025 2:39 PM
> To: T, Harini <Harini.T@amd.com>
> Cc: jassisinghbrar@gmail.com; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; Simek, Michal <michal.simek@amd.com>; Datta,
> Shubhrajyoti <shubhrajyoti.datta@amd.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git (AMD-
> Xilinx) <git@amd.com>
> Subject: Re: [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox:
> Document msg region requirement
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Mon, Dec 22, 2025 at 10:16:53AM +0530, Harini T wrote:
> > Add description clarifying that for Versal IPI mailboxes, both host
> > and remote agents must have the "msg" register region defined for
> > successful message passing. Without both, only notification-based
> > communication works.
> >
> > Signed-off-by: Harini T <harini.t@amd.com>
> > ---
> >  .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml           | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.ya
> > ml
> > b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.ya
> > ml index 04d6473d666f..8fdf77c7935c 100644
> > ---
> > a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.ya
> > ml
> > +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbo
> > +++ x.yaml
> > @@ -165,6 +165,12 @@ allOf:
> >          reg-names: false
> >
> >      else:
> > +      description:
>
> Else block cannot have description.

Can I remove the description from else block and move the clarifying text to the top-level description field?

>
> > +        For Versal IPI mailboxes, the "msg" register region is optional.
>
> So it is optional...

The schema marks "msg" as optional to support both notification-only and message-passing use-cases. In hardware, some mailbox channels may be designed for notification only (no buffer), while others support full message passing (with buffer). The schema allows both, but for message passing, "msg" is required on both ends

>
> > +        However, for successful message passing via mailbox, both the
> > + host IPI
>
> And it is not optional. If nothing works, then it is not optional.
>
> And why would it be optional in the first place? You generate your same IP
> with different settings?

There are 2 types of IPI channels (Buffered and Buffer-less)
Some IPI channels are used only for notification (no message buffer, so "msg" is omitted).
Others are used for message passing (buffer present, so "msg" is required).
Reference: https://docs.amd.com/r/en-US/am026-versal-ai-edge-prime-gen2-trm/Features?tocId=K2dUHSdNOkFPpbvkR5v6bQ

>
> Best regards,
> Krzysztof

Thanks,
Harini T


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox: Document msg region requirement
  2025-12-23 10:48   ` T, Harini
@ 2026-02-08 10:36     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-08 10:36 UTC (permalink / raw)
  To: T, Harini
  Cc: jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, Simek, Michal, Datta, Shubhrajyoti,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, git (AMD-Xilinx)

On 23/12/2025 11:48, T, Harini wrote:
> [Public]

What? Fix your email client, so we wan't be dealing with your corporate
rules.

[Private]

or rather let's mess with corporate systems:

[Confidential]

> 
> Hi,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, December 22, 2025 2:39 PM
>> To: T, Harini <Harini.T@amd.com>
>> Cc: jassisinghbrar@gmail.com; robh@kernel.org; krzk+dt@kernel.org;
>> conor+dt@kernel.org; Simek, Michal <michal.simek@amd.com>; Datta,
>> Shubhrajyoti <shubhrajyoti.datta@amd.com>; linux-kernel@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git (AMD-
>> Xilinx) <git@amd.com>
>> Subject: Re: [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox:
>> Document msg region requirement
>>
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> On Mon, Dec 22, 2025 at 10:16:53AM +0530, Harini T wrote:
>>> Add description clarifying that for Versal IPI mailboxes, both host
>>> and remote agents must have the "msg" register region defined for
>>> successful message passing. Without both, only notification-based
>>> communication works.
>>>
>>> Signed-off-by: Harini T <harini.t@amd.com>
>>> ---
>>>  .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml           | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.ya
>>> ml
>>> b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.ya
>>> ml index 04d6473d666f..8fdf77c7935c 100644
>>> ---
>>> a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.ya
>>> ml
>>> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbo
>>> +++ x.yaml
>>> @@ -165,6 +165,12 @@ allOf:
>>>          reg-names: false
>>>
>>>      else:
>>> +      description:
>>
>> Else block cannot have description.
> 
> Can I remove the description from else block and move the clarifying text to the top-level description field?
> 
>>
>>> +        For Versal IPI mailboxes, the "msg" register region is optional.
>>
>> So it is optional...
> 
> The schema marks "msg" as optional to support both notification-only and message-passing use-cases. In hardware, some mailbox channels may be designed for notification only (no buffer), while others support full message passing (with buffer). The schema allows both, but for message passing, "msg" is required on both ends

This is not wrapped. Again, fix your email client.

> 
>>
>>> +        However, for successful message passing via mailbox, both the
>>> + host IPI
>>
>> And it is not optional. If nothing works, then it is not optional.
>>
>> And why would it be optional in the first place? You generate your same IP
>> with different settings?
> 
> There are 2 types of IPI channels (Buffered and Buffer-less)
> Some IPI channels are used only for notification (no message buffer, so "msg" is omitted).


Confusing description then.

> 


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-08 10:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-22  4:46 [PATCH] dt-bindings: mailbox: xlnx,zynqmp-ipi-mailbox: Document msg region requirement Harini T
2025-12-22  9:09 ` Krzysztof Kozlowski
2025-12-23 10:48   ` T, Harini
2026-02-08 10:36     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox