From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Minghao Xue <quic_mingxue@quicinc.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, robh+dt@kernel.org,
jean-philippe@linaro.org,
virtualization@lists.linux-foundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_ztu@quicinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property
Date: Tue, 29 Mar 2022 09:59:31 +0200 [thread overview]
Message-ID: <a35529be-d9cb-9913-76aa-653faed87b54@linaro.org> (raw)
In-Reply-To: <20220329074610.GA20342@mingxue-gv.qualcomm.com>
On 29/03/2022 09:46, Minghao Xue wrote:
> On Mon, Mar 28, 2022 at 04:42:59PM -0400, Michael S. Tsirkin wrote:
>> On Fri, Mar 25, 2022 at 09:59:45AM +0800, Minghao Xue wrote:
>>> Some systems want to set the interrupt of virtio_mmio device
>>> as a wakeup source. On such systems, we'll use the existence
>>> of the "wakeup-source" property as a signal of requirement.
>>>
>>> Signed-off-by: Minghao Xue <quic_mingxue@quicinc.com>
>>
>> I don't have enough of a clue about dt to review this.
>> Pls get some acks from people with DT expertise.
>>
> Hi Michael,
> I had a discussion with Krzysztof on the first version of patch. And we've
> got aligned.
>
I thought I reviewed this and provided an ack, but apparently I did not.
Sorry for late response.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-29 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 1:59 [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property Minghao Xue
2022-03-28 20:42 ` Michael S. Tsirkin
2022-03-29 7:46 ` Minghao Xue
2022-03-29 7:59 ` Krzysztof Kozlowski [this message]
2022-04-25 8:58 ` Minghao Xue
2022-05-19 7:23 ` Minghao Xue
2022-06-10 5:44 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2022-06-10 8:58 [PATCH v2 0/2] virtio_mmio: add support to set IRQ of a virtio device as wakeup source Minghao Xue
2022-06-10 8:58 ` [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property Minghao Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a35529be-d9cb-9913-76aa-653faed87b54@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=quic_mingxue@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).