From: Krzysztof Kozlowski <krzk@kernel.org>
To: Randy Li <ayaka@soulik.info>, devicetree@vger.kernel.org
Cc: mark.rutland@arm.com, linux@armlinux.org.uk, kgene@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
robh@kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: Add TOPEET itop core board SCP package version
Date: Tue, 30 Aug 2016 09:16:46 +0200 [thread overview]
Message-ID: <a35686c3-294b-a16a-2b0e-0ef2fd460244@kernel.org> (raw)
In-Reply-To: <1472383269-3126-2-git-send-email-ayaka@soulik.info>
On 08/28/2016 01:21 PM, Randy Li wrote:
> The TOPEET itop is a samsung exnynos 4412 core board, which have
> two package versions. This patch add the support for SCP version.
>
> Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and
> PMIC. The future features are in the based board. Also MFC and
> watchdog have been enabled.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
> arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 489 ++++++++++++++++++++++++
> 1 file changed, 489 insertions(+)
> create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
>
> diff --git a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
> new file mode 100644
> index 0000000..ce5076c
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
> @@ -0,0 +1,489 @@
> +/*
> + * TOPEET's Exynos4412 based itop board device tree source
> + *
> + * Copyright (c) 2016 SUMOMO Computer Association
> + * https://www.sumomo.mobi
> + * Randy Li <ayaka@soulik.info>
> + *
> + * Device tree source file for TOPEET iTop Exynos 4412 SCP package core
> + * board which is based on Samsung's Exynos4412 SoC.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#include "exynos4412.dtsi"
> +#include "exynos4412-ppmu-common.dtsi"
> +#include "exynos-mfc-reserved-memory.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
First system-wide includes, then local ones.
> +
> +/ {
> + memory {
> + reg = <0x40000000 0x40000000>;
> + };
> +
> + firmware@0203F000 {
> + compatible = "samsung,secure-firmware";
> + reg = <0x0203F000 0x1000>;
> + };
> +
> + fixed-rate-clocks {
> + xxti {
> + compatible = "samsung,clock-xxti";
> + clock-frequency = <0>;
> + };
> +
> + xusbxti {
> + compatible = "samsung,clock-xusbxti";
> + clock-frequency = <24000000>;
> + };
> +
> + /* Clock from S5M8767A AP32K */
> + ap32k: xrtcxti {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <32768000>;
1. 32 MHz? Usually it is 32 kHz... Did you test these DTS?
2. Please use existing S5M8767 driver.
> + };
> + };
> +
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + cooling-maps {
> + map0 {
> + /* Corresponds to 800MHz at freq_table */
> + cooling-device = <&cpu0 7 7>;
> + };
> + map1 {
> + /* Corresponds to 200MHz at freq_table */
> + cooling-device = <&cpu0 13 13>;
> + };
> + };
> + };
> + };
> +
> + usb-hub {
> + compatible = "smsc,usb3503a";
Floating USB hub? Isn't it connected to SoC through I2C?
> + reset-gpios = <&gpm2 4 GPIO_ACTIVE_LOW>;
> + connect-gpios = <&gpm3 3 GPIO_ACTIVE_HIGH>;
> + intn-gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&hsic_reset>;
> + };
> +};
> +
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
> +
> +&bus_acp {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_c2c {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_leftbus {
> + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> + vdd-supply = <&buck3_reg>;
> + status = "okay";
> +};
> +
> +&bus_rightbus {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_fsys {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_peri {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_mfc {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&cpu0 {
> + cpu0-supply = <&buck2_reg>;
> +};
> +
> +&i2c_1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <400000>;
> + pinctrl-0 = <&i2c1_bus>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + s5m8767: s5m8767_pmic@66 {
> + compatible = "samsung,s5m8767-pmic";
> + reg = <0x66>;
> +
> + s5m8767,pmic-buck-default-dvs-idx = <3>;
> +
> + s5m8767,pmic-buck-dvs-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>,
> + <&gpb 6 GPIO_ACTIVE_HIGH>,
> + <&gpb 7 GPIO_ACTIVE_HIGH>;
> +
> + s5m8767,pmic-buck-ds-gpios = <&gpm3 5 GPIO_ACTIVE_HIGH>,
> + <&gpm3 6 GPIO_ACTIVE_HIGH>,
> + <&gpm3 7 GPIO_ACTIVE_HIGH>;
> +
> + /* VDD_ARM */
> + s5m8767,pmic-buck2-dvs-voltage = <1356250>, <1300000>,
> + <1243750>, <1118750>,
> + <1068750>, <1012500>,
> + <956250>, <900000>;
> + /* VDD_INT */
> + s5m8767,pmic-buck3-dvs-voltage = <1000000>, <1000000>,
> + <925000>, <925000>,
> + <887500>, <887500>,
> + <850000>, <850000>;
> + /* VDD_G3D */
> + s5m8767,pmic-buck4-dvs-voltage = <1081250>, <1081250>,
> + <1025000>, <950000>,
> + <918750>, <900000>,
> + <875000>, <831250>;
> +
> + regulators {
> + ldo1_reg: LDO1 {
> + regulator-name = "VDD_ALIVE";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1100000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + /* SCP uses 1.5v, POP uses 1.2v */
> + ldo2_reg: LDO2 {
> + regulator-name = "VDDQ_M12";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo3_reg: LDO3 {
> + regulator-name = "VDDIOAP_18";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo4_reg: LDO4 {
> + regulator-name = "VDDQ_PRE";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo6_reg: LDO6 {
> + regulator-name = "VDD10_MPLL";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo7_reg: LDO7 {
> + regulator-name = "VDD10_XPLL";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo8_reg: LDO8 {
> + regulator-name = "VDD10_MIPI";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo9_reg: LDO9 {
> + regulator-name = "VDD33_LCD";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo10_reg: LDO10 {
> + regulator-name = "VDD18_MIPI";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo11_reg: LDO11 {
> + regulator-name = "VDD18_ABB1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo12_reg: LDO12 {
> + regulator-name = "VDD33_UOTG";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo13_reg: LDO13 {
> + regulator-name = "VDDIOPERI_18";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo14_reg: LDO14 {
> + regulator-name = "VDD18_ABB02";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo15_reg: LDO15 {
> + regulator-name = "VDD10_USH";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo16_reg: LDO16 {
> + regulator-name = "VDD18_HSIC";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo17_reg: LDO17 {
> + regulator-name = "VDDIOAP_MMC012_28";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + /* Used by HSIC */
> + ldo18_reg: LDO18 {
> + regulator-name = "VDDIOPERI_28";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo20_reg: LDO20 {
> + regulator-name = "VDD28_CAM";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo21_reg: LDO21 {
> + regulator-name = "VDD28_AF";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo22_reg: LDO22 {
> + regulator-name = "VDDA28_2M";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo23_reg: LDO23 {
> + regulator-name = "VDD28_TF";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo24_reg: LDO24 {
> + regulator-name = "VDD33_A31";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo25_reg: LDO25 {
> + regulator-name = "VDD18_CAM";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo26_reg: LDO26 {
> + regulator-name = "VDD18_A31";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo27_reg: LDO27 {
> + regulator-name = "GPS_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + ldo28_reg: LDO28 {
> + regulator-name = "DVDD12";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck1_reg: BUCK1 {
> + regulator-name = "vdd_mif";
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <1100000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck2_reg: BUCK2 {
> + regulator-name = "vdd_arm";
> + regulator-min-microvolt = <850000>;
> + regulator-max-microvolt = <1456250>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck3_reg: BUCK3 {
> + regulator-name = "vdd_int";
> + regulator-min-microvolt = <875000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck4_reg: BUCK4 {
> + regulator-name = "vdd_g3d";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck5_reg: BUCK5 {
> + regulator-name = "vdd_m12";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck6_reg: BUCK6 {
> + regulator-name = "vdd12_5m";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck7_reg: BUCK7 {
> + regulator-name = "pvdd_buck7";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <2000000>;
> + regulator-boot-on;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck8_reg: BUCK8 {
> + regulator-name = "pvdd_buck8";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-boot-on;
> + regulator-always-on;
> + op_mode = <1>; /* Normal Mode */
> + };
> +
> + buck9_reg: BUCK9 {
> + regulator-name = "vddf28_emmc";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <3000000>;
> + op_mode = <1>; /* Normal Mode */
> + };
> + };
> + };
> +};
> +
> +&pinctrl_1 {
Please put it in alphabetical order.
> + hsic_reset: hsic-reset {
> + samsung,pins = "gpm2-4";
> + samsung,pin-function = <1>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <3>;
> + };
> +};
> +
> +&mfc {
> + status = "okay";
> +};
> +
> +&mshc_0 {
> + pinctrl-0 = <&sd4_clk &sd4_cmd &sd4_bus4 &sd4_bus8>;
> + pinctrl-names = "default";
> + status = "okay";
> + vmmc-supply = <&buck9_reg>;
> + num-slots = <1>;
> + broken-cd;
> + card-detect-delay = <200>;
> + samsung,dw-mshc-ciu-div = <3>;
> + samsung,dw-mshc-sdr-timing = <2 3>;
> + samsung,dw-mshc-ddr-timing = <1 2>;
> + bus-width = <8>;
> + cap-mmc-highspeed;
> +};
> +
> +&hsotg {
Please put it in alphabetical order.
> + vusb_d-supply = <&ldo15_reg>;
> + vusb_a-supply = <&ldo12_reg>;
> +};
> +
> +&rtc {
> + status = "okay";
> + clocks = <&clock CLK_RTC>, <&ap32k>;
Use S5M8767/S2MPS bindings for AP clock.
> + clock-names = "rtc", "rtc_src";
> +};
> +
> +&watchdog {
Please put it in alphabetical order.
Best regards,
Krzysztof
> + status = "okay";
> +};
> +
> +&tmu {
> + vtmu-supply = <&ldo16_reg>;
> + status = "okay";
> +};
>
next prev parent reply other threads:[~2016-08-30 7:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 20:04 [PATCH 0/2] Add a new board for exynos 4412 Randy Li
2016-08-21 20:04 ` [PATCH 1/2] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
2016-08-22 6:50 ` Marek Szyprowski
2016-08-22 8:28 ` Ayaka
2016-08-22 14:45 ` Chanwoo Choi
2016-08-22 14:49 ` ayaka
[not found] ` <4767fc2a-95b7-ee0d-f51a-7a5d6ca89d8f-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-08-22 14:18 ` [PATCH 0/2 v2] Add a new board TOPEET iTOP for exynos 4412 Randy Li
2016-08-22 14:18 ` [PATCH 1/2] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
2016-08-22 14:18 ` [PATCH 2/2] ARM: dts: add TOPEET itop elite based board Randy Li
2016-08-22 18:59 ` kbuild test robot
2016-08-23 18:14 ` Rob Herring
2016-08-23 18:36 ` ayaka
2016-08-23 22:38 ` Rob Herring
2016-08-24 8:29 ` Ayaka
[not found] ` <CAL_JsqKY=VEZ+U11kY+XbMWuXhaFDr6GpnR3AXKd1U=9_=8fgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-28 11:21 ` [PATCH 0/4 v3] Add a new board TOPEET iTOP for exynos 4412 Randy Li
2016-08-28 11:21 ` [PATCH 1/4] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
[not found] ` <1472383269-3126-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-28 21:13 ` Rask Ingemann Lambertsen
2016-08-30 7:16 ` Krzysztof Kozlowski [this message]
2016-08-31 12:58 ` [RESEND PATCH 1/3] " Randy Li
[not found] ` <1472648307-3818-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-31 18:42 ` Krzysztof Kozlowski
2016-08-31 19:49 ` Ayaka
2016-09-01 13:03 ` Bartlomiej Zolnierkiewicz
2016-09-01 16:12 ` Krzysztof Kozlowski
2016-08-28 11:21 ` [PATCH 2/4] ARM: dts: add TOPEET itop elite based board Randy Li
2016-08-30 7:32 ` Krzysztof Kozlowski
2016-08-31 12:59 ` [RESEND PATCH 2/3] " Randy Li
2016-09-01 13:07 ` Bartlomiej Zolnierkiewicz
2016-08-28 11:21 ` [PATCH 3/4] ARM: dts: add fimc support in exynos4412 TOPEET iTop Elite board Randy Li
2016-08-30 7:33 ` Krzysztof Kozlowski
[not found] ` <f90ffaf4-dc95-9c32-1f4d-771f96424783-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-31 13:00 ` [PATCH 3/3 v3] devicetree: bindings: Add vendor prefix for Topeet Randy Li
[not found] ` <1472383269-3126-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-28 11:21 ` [PATCH 4/4] ARM: dts: samsung: add analog audio codec on TOPEET iTop 4412 Elite Randy Li
2016-08-30 7:35 ` Krzysztof Kozlowski
2016-08-30 7:04 ` [PATCH 0/4 v3] Add a new board TOPEET iTOP for exynos 4412 Krzysztof Kozlowski
[not found] ` <1471809893-31147-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-21 20:04 ` [PATCH 2/2] ARM: dts: add TOPEET itop elite based board Randy Li
2016-08-21 20:12 ` [PATCH 2/2 v2] " Randy Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a35686c3-294b-a16a-2b0e-0ef2fd460244@kernel.org \
--to=krzk@kernel.org \
--cc=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).