devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sean Anderson <sean.anderson@seco.com>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-phy@lists.infradead.org
Cc: devicetree@vger.kernel.org, Madalin Bucur <madalin.bucur@nxp.com>,
	Camelia Alexandra Groza <camelia.groza@nxp.com>,
	linuxppc-dev@lists.ozlabs.org, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 3/8] dt-bindings: clock: Add ids for Lynx 10g PLLs
Date: Tue, 9 Aug 2022 08:21:54 +0300	[thread overview]
Message-ID: <a387164a-d42c-fc1e-529c-6000aa2db33e@linaro.org> (raw)
In-Reply-To: <04b08e1c-4af2-581e-7be5-96c5b7b00ae5@seco.com>

On 08/08/2022 18:16, Sean Anderson wrote:
> 
>> This entry here is not
>> parsed for any tools and only sometimes people look at it. The questions
>> are directed via entry in maintainers file or via git history, so you
>> can put company email just there.
> 
> As I understand it, the email is simply informative. There are literally
> hundreds of examples of mixing a "personal" copyright with a company email.
> It is easy to find if you grep. If you are so opposed to it, then I will
> remove the email and simply use my name.

No, no problem for me.

> 
>>>
>>>>> + */
>>>>> +
>>>>> +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H
>>>>> +#define __DT_BINDINGS_CLK_LYNX_10G_H
>>>>> +
>>>>> +#define LYNX10G_CLKS_PER_PLL 2
>>>>> +
>>>>> +#define LYNX10G_PLLa(a)		((a) * LYNX10G_CLKS_PER_PLL)
>>>>> +#define LYNX10G_PLLa_EX_DLY(a)	((a) * LYNX10G_CLKS_PER_PLL + 1)
>>>>
>>>> These do not look like proper IDs for clocks for bindings. Numbering
>>>> starts from 0 or 1 and any "a" needs to be clearly explained. What do
>>>> you bind here?
>>>
>>> This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc.
>>> This matches the notation used in the reference manual.
>>
>> This is a file for bindings, not for storing register values. There is
>> no single need to store register values (offsets, indexes) as bindings
>> as it is not appropriate. Therefore if you do not use it as an ID, just
>> remove the bindings header.
> 
> This *is* just for IDs, as stated in the commit message. The above example
> was only to illustrate that the clock controlled via the PLL1RSTCTL register
> (among others) would have an ID of LYNX10G_PLLa(0).
> 
> If you doubt it, review the driver.

Indeed, thanks. Except the driver, where is the DTS user of these
bindings? It's neither in bindings example, nor in the DTS patches.

Best regards,
Krzysztof

  reply	other threads:[~2022-08-09  5:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 22:05 [PATCH v4 0/8] phy: Add support for Lynx 10G SerDes Sean Anderson
2022-08-04 22:05 ` [PATCH v4 1/8] dt-bindings: phy: Add 2500BASE-X and 10GBASE-R Sean Anderson
2022-08-04 22:05 ` [PATCH v4 2/8] dt-bindings: phy: Add Lynx 10G phy binding Sean Anderson
2022-08-05 14:09   ` Rob Herring
2022-08-05 15:20     ` Sean Anderson
2022-08-04 22:05 ` [PATCH v4 3/8] dt-bindings: clock: Add ids for Lynx 10g PLLs Sean Anderson
2022-08-05  6:53   ` Krzysztof Kozlowski
2022-08-05 15:17     ` Sean Anderson
2022-08-08  5:46       ` Krzysztof Kozlowski
2022-08-08 15:16         ` Sean Anderson
2022-08-09  5:21           ` Krzysztof Kozlowski [this message]
2022-08-09 14:42             ` Sean Anderson
2022-08-04 22:05 ` [PATCH v4 4/8] phy: fsl: Add Lynx 10G SerDes driver Sean Anderson
2022-08-04 22:05 ` [PATCH v4 5/8] arm64: dts: ls1046a: Add serdes bindings Sean Anderson
2022-08-04 22:06 ` [PATCH v4 6/8] arm64: dts: ls1088a: " Sean Anderson
2022-08-04 22:06 ` [PATCH v4 7/8] arm64: dts: ls1046ardb: " Sean Anderson
2022-08-04 22:06 ` [PATCH v4 8/8] [WIP] arm64: dts: ls1088ardb: " Sean Anderson
2022-08-30 21:44 ` [PATCH v4 0/8] phy: Add support for Lynx 10G SerDes Sean Anderson
2022-09-02 17:41   ` Vinod Koul
2022-09-02 21:10     ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a387164a-d42c-fc1e-529c-6000aa2db33e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=camelia.groza@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bucur@nxp.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sean.anderson@seco.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).