From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki K Poulose Subject: Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Date: Fri, 12 Apr 2019 11:40:13 +0100 Message-ID: References: <20190412102738.12679-1-leo.yan@linaro.org> <20190412102738.12679-2-leo.yan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190412102738.12679-2-leo.yan@linaro.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: leo.yan@linaro.org, mathieu.poirier@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 04/12/2019 11:27 AM, Leo Yan wrote: > CoreSight uses below bindings for replicator: > > Dynamic replicator, aka. configurable replicator: > "arm,coresight-dynamic-replicator", "arm,primecell"; > > Static replicator, aka. non-configurable replicator: > "arm,coresight-replicator"; > > The compatible string "arm,coresight-replicator" is not an explicit > naming to express the replicator is 'static'. To unify the naming > convention, this patch introduces a new compatible string > "arm,coresight-static-replicator" for the static replicator; the > compatible string "arm,coresight-replicator" is kept for backward > compatibility, but tag it as obsolete and suggest to use the new > compatible string. > > As result CoreSight replicator have below bindings: > > Dynamic replicator: > "arm,coresight-dynamic-replicator", "arm,primecell"; > > Static replicator: > "arm,coresight-static-replicator"; > "arm,coresight-replicator"; (obsolete) > > Signed-off-by: Leo Yan > --- > Documentation/devicetree/bindings/arm/coresight.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > index f8aff65ab921..d02d160fa8ac 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -69,7 +69,10 @@ its hardware characteristcs. > > * compatible: Currently supported value is (note the absence of the > AMBA markee): > - - "arm,coresight-replicator" > + - Coresight Non-configurable Replicator: > + "arm,coresight-static-replicator"; > + "arm,coresight-replicator"; (OBSOLETE. For backward > + compatibility and will be removed) > > * port or ports: see "Graph bindings for Coresight" below. > > @@ -169,7 +172,7 @@ Example: > /* non-configurable replicators don't show up on the > * AMBA bus. As such no need to add "arm,primecell". > */ > - compatible = "arm,coresight-replicator"; > + compatible = "arm,coresight-static-replicator"; Reviewed-by: Suzuki K Poulose