From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D046A2F90CA for ; Mon, 20 Oct 2025 13:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760965226; cv=none; b=J4hKH+prVfjYE/jX3314sjaw44e7sStvVRHxWKo0Y0AAQJ84wypiKfdYJ5zbSEqaQvBMBHQwDJYQYjL62COlPh8Cbq41Y93PJ7pF9xrO9fmX+mmJ82nWBBhJ7jns4W5KXbsRxbxjHUH3TSzuMPA2n9rbiOCS65U1GFYjggwFil0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760965226; c=relaxed/simple; bh=8WkbNdMuBq7DpnVFLltNV+aBM21EVH5APcxMppriAT8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CGQoxdo5E5BEYcz8EvQZlNXuQSeeYSoN8YSHdfrChQPz+aG2VKs8X7KBkVhLaUdDYS/EI1C6AuH2R72i0iiYsG1PwblXNYAcQv7ueDVepWCQg6dqhTh5mmdRCVyBIFVq/JZq0vxz9IhjNtVsdU7bEXKPczGDI/TGz9BeDVkHmN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZvP4bzob; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZvP4bzob" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-63994113841so7422857a12.3 for ; Mon, 20 Oct 2025 06:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760965223; x=1761570023; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3R4NouHwR2gJkgcsNlR57aYLjQ4OTHNFMDfpxlNGqaQ=; b=ZvP4bzobdSik1ScG8uFeYmTGBzPUq/7WRtdLcQsje+O6t3ZhmS2uSLbRrEJiSt90s+ 520swG4nTipatEdgbx2Dua6oxlYspNcO7D2iGKIYGdKuhw3iwxBQI/lRAniaUja5d0uO Nx6Cn2v3Yp9+fpf8BtftWzGaDLxCmm73+I8Og4dpwodMZJm6Jl4KR5uvxo8mqJToc64y rmj9HKx0BoeU0l8Yy9mjoDR78vw12yqTYLmZCS0VE/1ih2cz+j47E/CsusJN/TsFl3TF BU7zQQZm9wvIxfgH5Spdfj5R+LziutJwRBZvlvPoM30EjgUlvoQD/Ak1C0XpGkdO1KxY NSDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760965223; x=1761570023; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3R4NouHwR2gJkgcsNlR57aYLjQ4OTHNFMDfpxlNGqaQ=; b=cD3z0Mqe2/l4uc/StA3l7Tr2MIP+jgJrhmHFg3HqkMybOOpceZiZWF81NsMRl+opF/ RQdob9T837QdQ5+Gokqa3RiMMQFCZleBbdFCK3tJ8sVVPFCTqyhhScrOWGQgJzIjojMX nZow+urJ0KSw6DU2BOvwjQ+QGaBbcxLLV+bmQ06jimWeZV9RT9fI7Ean/IA3BwFmfag8 0rwooH9KCCy40Ig40vbGJaPcTNi4cc5A/DtP1Bo4KNt8eYjnG02BVTQJenwHzGvWNrxw blzgQMhmoBUuuCyTrZwuQTgHXRd6mRCVkaFcp3wjtb4kqImBw3oe6B+vfDKlogyzQtyV zknw== X-Forwarded-Encrypted: i=1; AJvYcCUsCi75+8wUggdEdFEZOw0fUGY6zhontB+rA+WUFxITOZLFWeMxEFkoRv9YFF8Hhj+jTEawoAGD1oO5@vger.kernel.org X-Gm-Message-State: AOJu0Yz/kfB7RbU1H0Od4ESNqHlSZcLq3raRMXTPCdA1gG8KFcBUAKY9 VA+xcjCrXwdUky0LDENJOZr4OGL7u3oBW8uJpEfpK2mJlLDcxBMWDWOxn3coz0GVB3I= X-Gm-Gg: ASbGnctnlG9ccJDdzLbzU69kZSmqNCENRlGfBBz6j8qM2h5oOL6cWVeQu3b/UaWkEKO U+OVAQS2MnfJfuVsd7AqwvbsN2k87XOXV3yYthve1rVHJMgO3/XiEwMWN14Wt2bMc3gHtJI2Li9 u9YB3hpVKT0invlsiJce7M+wDQxKNPPTmNOaz00xcLpZG1yfDjuY/YNUWGnhAUlTT5YgebgfFVt s8Jk35PJ/XvHCUiuTNzHfkhXYu5DZLGSG32jHfW17jFJKI0D/6R8TkMBQMnhuRnbsHXoVNSQ0Gb svHIhC92jcKt1ytsEWEBiduxyVfR2GMnoDdXxFYJAiFgRR5kYZw5XrtO+k48MXoccAKlOQARh24 2pXsS4P7iUFH2ZTjzZ4D55n/bzgSo5qGddRUhdU/8eFkxGJgmwRgKt8jd8EkOvjDTIMKy6e7cES cEBpQVrQTPAC/74jgBPVg7XyNE+u+qG6WSbnshC6y67SfFRmSE3ruWSA== X-Google-Smtp-Source: AGHT+IGayW9zCBqvq6aXXWQ9uRWB3OMkgLybK2vzPwD7fbUYhsxu/O7OcSb2DNq+M/Bi8PvU4VO76A== X-Received: by 2002:a17:907:3d91:b0:b55:befd:8f8d with SMTP id a640c23a62f3a-b647500ec03mr1649485166b.57.1760965221397; Mon, 20 Oct 2025 06:00:21 -0700 (PDT) Received: from [192.168.0.163] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65eb9523a7sm803891966b.71.2025.10.20.06.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 06:00:20 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 14:00:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550: Additionally manage MXC power domain in camcc To: Konrad Dybcio , Luca Weiss , Taniya Das , Dmitry Baryshkov , Vladimir Zapolskiy Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Jagadeesh Kona , Michael Turquette , Stephen Boyd , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20250303225521.1780611-1-vladimir.zapolskiy@linaro.org> <20250303225521.1780611-3-vladimir.zapolskiy@linaro.org> <3210a484-b9c3-4399-bee1-9f5bbc90034c@linaro.org> <85bf3468-24bf-4f14-afcd-28878ad84dc9@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <85bf3468-24bf-4f14-afcd-28878ad84dc9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/10/2025 13:21, Konrad Dybcio wrote: > On 10/17/25 4:05 PM, Luca Weiss wrote: >> Hi Taniya, >> >> On Thu Mar 13, 2025 at 12:57 PM CET, Taniya Das wrote: >>> >>> >>> On 3/13/2025 1:22 PM, Luca Weiss wrote: >>>> Hi Taniya, >>>> >>>> On Thu Mar 13, 2025 at 5:39 AM CET, Taniya Das wrote: >>>>> >>>>> >>>>> On 3/4/2025 2:10 PM, Dmitry Baryshkov wrote: >>>>>> On Tue, 4 Mar 2025 at 09:37, Vladimir Zapolskiy >>>>>> wrote: >>>>>>> >>>>>>> On 3/4/25 01:53, Dmitry Baryshkov wrote: >>>>>>>> On Tue, Mar 04, 2025 at 12:55:21AM +0200, Vladimir Zapolskiy wrote: >>>>>>>>> SM8550 Camera Clock Controller shall enable both MXC and MMCX power >>>>>>>>> domains. >>>>>>>> >>>>>>>> Are those really required to access the registers of the cammcc? Or is >>>>>>>> one of those (MXC?) required to setup PLLs? Also, is this applicable >>>>>>>> only to sm8550 or to other similar clock controllers? >>>>>>> >>>>>>> Due to the described problem I experience a fatal CPU stall on SM8550-QRD, >>>>>>> not on any SM8450 or SM8650 powered board for instance, however it does >>>>>>> not exclude an option that the problem has to be fixed for other clock >>>>>>> controllers, but it's Qualcomm to confirm any other touched platforms, >>>>>> >>>>>> Please work with Taniya to identify used power domains. >>>>>> >>>>> >>>>> CAMCC requires both MMCX and MXC to be functional. >>>> >>>> Could you check whether any clock controllers on SM6350/SM7225 (Bitra) >>>> need multiple power domains, or in general which clock controller uses >>>> which power domain. >>>> >>>> That SoC has camcc, dispcc, gcc, gpucc, npucc and videocc. >>>> >>>> That'd be highly appreciated since I've been hitting weird issues there >>>> that could be explained by some missing power domains. >>>> >>> >>> Hi Luca, >>> >>> The targets you mentioned does not have any have multiple rail >>> dependency, but could you share the weird issues with respect to clock >>> controller I can take a look. >> >> Coming back to this, I've taken a shot at camera on SM6350 (Fairphone 4) >> again, but again hitting some clock issues. >> >> For reference, I am testing with following change: >> https://lore.kernel.org/linux-arm-msm/20250911011218.861322-3-vladimir.zapolskiy@linaro.org/ >> >> Trying to enable CAMCC_MCLK1_CLK - wired up to the IMX576 camera sensor >> on this phone - results in following error. >> >> [ 3.140232] ------------[ cut here ]------------ >> [ 3.141264] camcc_mclk1_clk status stuck at 'off' >> [ 3.141276] WARNING: CPU: 6 PID: 12 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x170/0x190 >> >> Checking the driver against downstream driver, it looks like the RCGs >> should be using clk_rcg2_shared_ops because of enable_safe_config in >> downstream, but changing that doesn't really improve the situation, but >> it does change the error message to this: >> >> [ 2.933254] ------------[ cut here ]------------ >> [ 2.933961] camcc_mclk1_clk_src: rcg didn't update its configuration. >> [ 2.933970] WARNING: CPU: 7 PID: 12 at drivers/clk/qcom/clk-rcg2.c:136 update_config+0xd4/0xe4 >> >> I've also noticed that some camcc drivers take in GCC_CAMERA_AHB_CLK as >> iface clk, could something like this be missing on sm6350? >> >> I'd appreciate any help or tips for resolving this. > > Is CAMCC_PLL2 online? > > Konrad Usually if you can't switch on a clock its because a power-domain is off or a GDSC is off. I'd guess one of the power-domains is missing. Looks... @Luca Is this actually right ? camcc: clock-controller@ad00000 { compatible = "qcom,sm6350-camcc"; reg = <0x0 0x0ad00000 0x0 0x16000>; clocks = <&rpmhcc RPMH_CXO_CLK>; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>; }; Isn't this clock controller missing at least one power-domain ? camcc: clock-controller@ad00000 { compatible = "qcom,sm6350-camcc"; reg = <0x0 0x0ad00000 0x0 0x16000>; clocks = <&rpmhcc RPMH_CXO_CLK>; + power-domains = <&rpmhpd SM6350_CX>; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>; }; Hmm but CX should already be on realistically.. --- bod