From: Florian Fainelli <f.fainelli@gmail.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: Sasi Kumar <sasi.kumar@broadcom.com>,
devicetree@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 3/7] bdc: Fix bug causing crash after multiple disconnects
Date: Tue, 21 Jul 2020 10:33:36 -0700 [thread overview]
Message-ID: <a39eb7a3-0dbe-194e-80b7-4d773949a276@gmail.com> (raw)
In-Reply-To: <20200721144326.7976-4-alcooperx@gmail.com>
On 7/21/20 7:43 AM, Al Cooper wrote:
> From: Sasi Kumar <sasi.kumar@broadcom.com>
>
> Multiple connects/disconnects can cause a crash on the second
> disconnect. The driver had a problem where it would try to send
> endpoint commands after it was disconnected which is not allowed
> by the hardware. The fix is to only allow the endpoint commands
> when the endpoint is connected. This will also fix issues that
> showed up when using configfs to create gadgets.
>
> Signed-off-by: Sasi Kumar <sasi.kumar@broadcom.com>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-21 17:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:43 [PATCH v2 0/7] usb: bdc: Updates and fixes to the USB BDC driver Al Cooper
2020-07-21 14:43 ` [PATCH v2 1/7] dt-bindings: usb: bdc: Update compatible strings Al Cooper
2020-07-21 17:33 ` Florian Fainelli
2020-07-21 14:43 ` [PATCH v2 2/7] usb: bdc: Add compatible string for new style USB DT nodes Al Cooper
2020-07-21 17:33 ` Florian Fainelli
2020-07-22 8:47 ` Sergei Shtylyov
2020-07-21 14:43 ` [PATCH v2 3/7] bdc: Fix bug causing crash after multiple disconnects Al Cooper
2020-07-21 17:33 ` Florian Fainelli [this message]
2020-07-21 14:43 ` [PATCH v2 4/7] usb: bdc: Adb shows offline after resuming from S2 Al Cooper
2020-07-21 17:33 ` Florian Fainelli
2020-07-21 14:43 ` [PATCH v2 5/7] usb: bdc: driver runs out of buffer descriptors on large ADB transfers Al Cooper
2020-07-21 17:34 ` Florian Fainelli
2020-07-21 14:43 ` [PATCH v2 6/7] usb: bdc: Halt controller on suspend Al Cooper
2020-07-21 17:34 ` Florian Fainelli
2020-07-21 14:43 ` [PATCH v2 7/7] usb: bdc: Use devm_clk_get_optional() Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a39eb7a3-0dbe-194e-80b7-4d773949a276@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sasi.kumar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).