From: Rohit Agarwal <quic_rohiagar@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Pavan Kondeti <quic_pkondeti@quicinc.com>, <agross@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD indexes
Date: Tue, 25 Jul 2023 13:44:55 +0530 [thread overview]
Message-ID: <a3a401fe-dbc6-03dd-ce6f-13abf30ef984@quicinc.com> (raw)
In-Reply-To: <a4zztrn6jhblozdswba7psqtvjt5l765mfr3yl4llsm5gsyqef@7x6q7yabydvm>
On 7/22/2023 8:35 AM, Bjorn Andersson wrote:
> On Fri, Jul 21, 2023 at 06:47:42PM +0530, Rohit Agarwal wrote:
>> On 7/21/2023 11:14 AM, Pavan Kondeti wrote:
>>> On Wed, Jul 19, 2023 at 10:52:41AM +0530, Rohit Agarwal wrote:
>>>> diff --git a/include/dt-bindings/power/qcom,rpmhpd.h b/include/dt-bindings/power/qcom,rpmhpd.h
> [..]
>>>> +
>>>> +#endif
>>>> --
>>> I see the PD performance levels (RPMH_REGULATOR_LEVEL_xxx) are still
>>> coming from qcom-rpmpd.h. Which means Socs with RPMh also need to
>>> include the older header for these definitions along with this newly
>>> created header. something to improve for the clarity sake?
>> Agreed. I think we can move these to the new header so that the new SoC with
>> RPMH can completely
>> move to rpmhpd.h.
> Sounds very reasonable, please do that in a follow up patch.
> I'm picking this as is.
I have a doubt related to this about sending the patches.
Since I will be moving the regulators level into the same rpmhpd.h
header, we
would need to update all the qcom soc dtsi file changes as well. Also
there is a
remaining dt-bindings patch that update the older rpmhpd bindings to
these new
ones basically the cleanup is remaining.
Shall I create a unified series updating all these in one and tagging
all the the
related maintainers in the CC
OR
should I create separate series where the dt changes are updated first
then the
followup cleanup dt-bindings series?
Thanks,
Rohit.
> Thanks,
> Bjorn
next prev parent reply other threads:[~2023-07-25 8:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 5:22 [PATCH 0/2] Introduce new generic bindings for RPMHPD Rohit Agarwal
2023-07-19 5:22 ` [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD indexes Rohit Agarwal
2023-07-19 9:00 ` Krzysztof Kozlowski
2023-07-19 9:13 ` Mukesh Ojha
2023-07-21 5:44 ` Pavan Kondeti
2023-07-21 13:17 ` Rohit Agarwal
2023-07-22 3:05 ` Bjorn Andersson
2023-07-25 8:14 ` Rohit Agarwal [this message]
2023-07-19 5:22 ` [PATCH 2/2] soc: qcom: rpmhpd: Use the newly created generic RPMHPD bindings Rohit Agarwal
2023-07-22 2:58 ` Bjorn Andersson
2023-07-22 5:17 ` (subset) [PATCH 0/2] Introduce new generic bindings for RPMHPD Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a401fe-dbc6-03dd-ce6f-13abf30ef984@quicinc.com \
--to=quic_rohiagar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_pkondeti@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).