From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: qcom_smd: Add PM8909 RPM regulators
Date: Thu, 23 Jun 2022 15:27:11 +0200 [thread overview]
Message-ID: <a3aad0cc-caab-2e02-c731-8fff57906cee@linaro.org> (raw)
In-Reply-To: <3f04d27f-4949-3544-9d39-73151a303569@linaro.org>
On 23/06/2022 15:26, Krzysztof Kozlowski wrote:
> On 23/06/2022 11:46, Stephan Gerhold wrote:
>
>> static const struct rpm_regulator_data rpm_pm8916_regulators[] = {
>> { "s1", QCOM_SMD_RPM_SMPA, 1, &pm8916_buck_lvo_smps, "vdd_s1" },
>> { "s2", QCOM_SMD_RPM_SMPA, 2, &pm8916_buck_lvo_smps, "vdd_s2" },
>> @@ -1222,6 +1245,7 @@ static const struct rpm_regulator_data rpm_pm2250_regulators[] = {
>> static const struct of_device_id rpm_of_match[] = {
>> { .compatible = "qcom,rpm-mp5496-regulators", .data = &rpm_mp5496_regulators },
>> { .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators },
>> + { .compatible = "qcom,rpm-pm8909-regulators", .data = &rpm_pm8909_regulators },
>> { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators },
>> { .compatible = "qcom,rpm-pm8226-regulators", .data = &rpm_pm8226_regulators },
>> { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators },
>
> Isn't this a new compatible? Looks like, so it needs bindings.
Ah, I see the patch now.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-23 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 9:46 [PATCH 0/3] regulator: qcom_smd: Add PM8909 and fix pm8916_pldo range Stephan Gerhold
2022-06-23 9:46 ` [PATCH 1/3] regulator: qcom_smd: Fix " Stephan Gerhold
2022-06-23 9:46 ` [PATCH 2/3] regulator: dt-bindings: qcom,smd-rpm: Add PM8909 Stephan Gerhold
2022-06-23 13:28 ` Krzysztof Kozlowski
2022-06-24 17:26 ` Rob Herring
2022-06-27 14:07 ` Stephan Gerhold
2022-06-23 9:46 ` [PATCH 3/3] regulator: qcom_smd: Add PM8909 RPM regulators Stephan Gerhold
2022-06-23 13:26 ` Krzysztof Kozlowski
2022-06-23 13:27 ` Krzysztof Kozlowski [this message]
2022-06-30 13:32 ` [PATCH 0/3] regulator: qcom_smd: Add PM8909 and fix pm8916_pldo range Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3aad0cc-caab-2e02-c731-8fff57906cee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).