From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C22CC83F16 for ; Tue, 29 Aug 2023 09:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232178AbjH2J5R (ORCPT ); Tue, 29 Aug 2023 05:57:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235062AbjH2J4z (ORCPT ); Tue, 29 Aug 2023 05:56:55 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD1FCF3 for ; Tue, 29 Aug 2023 02:56:25 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9936b3d0286so562651066b.0 for ; Tue, 29 Aug 2023 02:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693302971; x=1693907771; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9Jps0qXeyPLdx+b5De4g4xbuY+7aT5vkCHcXrjuUV+Y=; b=OKuqNU9MpyPIJHFWbNDDPELOreMyC3nGbzUQuvwWmKtrIcg8RHDNkDWzmbrmnnFmT6 DyQw4klN3ZaAualjzdSAmsWqsbpECq9vKBR7YPoHvvAfuejn7q5T+sd+RsZqBu5ae35Z z8GsJ+WzEPtVzeU++j8rnM4CobDrMKOgRgHaOS1ShOspnbDF9MEZUJ/pgPQxLRgtXEwk 88ANIHmf1xT28cdC47Thv18zt1doh1SeJLWtNn6A+f+V7KWzfP3awOAJoIyCfwuDhZVu SB3ME+oDJn9FlwIAJSIeOAmsUoahcY9niLlOaTRdrPk9iUa8DQviJKZqBVQHOBR0X16f ImgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693302971; x=1693907771; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Jps0qXeyPLdx+b5De4g4xbuY+7aT5vkCHcXrjuUV+Y=; b=K6lO50EMtjr8YckuOBxokwVlr9LL/1jTbNAspM9A+UB1hYd1SoKjH8fmuEAEqxH3Gy o6OxiBNTqgOgDdHb+OirT4f7T5aqxZSmaOp8t358PYRIBOHKtKIHQ6Z0ynXaaOZewzPa wk1Z4Zrbs5UR6WI42uKz7iZNivmVdH9apb7E/nlb0pd6eM+mW24xfsynvdRaWyhbLIvt XxVqqtVTlZGJZY1ngd9LTnZqjapzAEXUrqzKojYBpN1BzWwGI6Ap7k7zKNOtBTWZacPo 25YywcMkmU/D8TyHA3a1ehby+A9ftl/492go5DijvpohP0PKeQJJ83UfMS+Riuza9BWm A6Mg== X-Gm-Message-State: AOJu0Yyed0Oy9+7UCHtmveGDZ+ejCl1G5db4lHH1GxGqujqfGqkqY4vh eZ+eYv8LGR7Ih1iELh04BrHI/g== X-Google-Smtp-Source: AGHT+IEjhxFak4PhQe3Tgs47lEQYmobKxofGOlrRmfYW9HU2F55i2HVmIX6rN/v0yjl1q+ycOMRmMw== X-Received: by 2002:a17:906:2091:b0:9a2:ecd:d962 with SMTP id 17-20020a170906209100b009a20ecdd962mr9825131ejq.4.1693302970981; Tue, 29 Aug 2023 02:56:10 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.196]) by smtp.gmail.com with ESMTPSA id h25-20020a1709063b5900b0099cc3c7ace2sm5878362ejf.140.2023.08.29.02.56.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 02:56:10 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 11:56:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 04/11] thermal: exynos: remove fine-grained clk management Content-Language: en-US To: Mateusz Majewski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Liam Girdwood , Mark Brown , Marek Szyprowski References: <20230829091853.626011-1-m.majewski2@samsung.com> <20230829091853.626011-5-m.majewski2@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230829091853.626011-5-m.majewski2@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/08/2023 11:18, Mateusz Majewski wrote: > This clock only controls the register operations. The gain in power > efficiency is therefore quite dubious, while there is price of added > complexity that is important to get right (as a register operation might > outright hang the CPU if the clock is not enabled). So once it is done right, this stops being argument. The benefit is to keep this clock disabled most of the time, which now we lost. I don't find this patch correct approach. Best regards, Krzysztof