From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>,
neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
Date: Wed, 28 Sep 2022 09:24:22 +0200 [thread overview]
Message-ID: <a3d2d7db-e27b-3d6b-2bbf-9f8b258a23b4@linaro.org> (raw)
In-Reply-To: <13105309.uLZWGnKmhe@g550jk>
On 26/09/2022 17:07, Luca Weiss wrote:
> Hi Krzysztof,
>
> On Montag, 26. September 2022 12:29:11 CEST Krzysztof Kozlowski wrote:
>> On 26/09/2022 12:04, Neil Armstrong wrote:
>>> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>>>> };
>>>>>
>>>>> - usb_id: misc@900 {
>>>>> + usb_id: extcon@900 {
>>>>
>>>> Why? extcon is Linux specific name and should not be added to DTS.
>>>> Anything requires it?
>>>
>>> It matches the current dt bindings:
>> Then instead maybe let's fix it in the bindings and DTS?
>
> What node name do you propose? I doubt "misc" is a better name as it really
> doesn't describe anything so I don't really have a suggestion here..
>
Some manufacturers call it a muic (Micro-USB IC), but maybe just
usb-detect? The role of this device is accessory and cable detection.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-28 7:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-26 10:04 ` Neil Armstrong
2022-09-26 10:29 ` Krzysztof Kozlowski
2022-09-26 15:07 ` Luca Weiss
2022-09-28 7:24 ` Krzysztof Kozlowski [this message]
2022-09-26 15:17 ` Neil Armstrong
2022-09-27 13:07 ` Konrad Dybcio
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
2022-09-26 8:53 ` [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Neil Armstrong
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:05 ` Krzysztof Kozlowski
2022-09-26 9:12 ` Krzysztof Kozlowski
2022-09-26 9:19 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3d2d7db-e27b-3d6b-2bbf-9f8b258a23b4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).