Re: [PATCH v2 1/3] dt-bindings: arm: renesas: Document Renesas RZ/V2M System Configuration

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 14/11/2022 17:44, Biju Das wrote:
>>>>> If the hardware manual said this is called "foo-whatever-name" or
>>>>> "rz85736dfnx2", you would use it as well?
>>>>>
>>>>> Node names should be generic.
>>>
>>> I got the following feedback from LSI team.
>>>
>>> *The reason why we use "configuration" and not "controller" is the
>>> possibility that users might take it to mean "control" of system
>>> operation (product operation). This unit determines how the whole LSI
>> configure to operate LSI, so we use "configuration" for this IP name.
>>>
>>> As per this it is not a controller. It is a Configuration IP.
>>>
>>> What should be generic node name for system configuration IP?
>>
>> Then it's closer to chipid and should be in hwinfo?
> 
> You mean, sys: hwinfo@a3f03000 instead of sys: system-configuration@a3f03000 ??

Rather be put in hwinfo directory. Typical name is "chipid", but I don't
know if your device is a chipid.

> 
> Also the same IP block is present on rz/v2ma as well?
> 
> Shall I use the same file renesas,rzv2m-sys.yaml for both r9a09g011-sys and r9a09g055-sys?
> 
>>
>> Anyway, you wrote in bindings description: "performs system control", so what
>> can I say?
> 
> SYS functional description is as follows.
> 
> The SYS controls the overall configuration of the chip, such as

Exactly, it controls, so it is a controller... Anyway, do not introduce
your own names, but use something generic. There is no single reference
of "system-configuration".

> 
> ● Bank address settings for DMAC
> ● Bank address settings of the units for ICB> ● ETHER AxCACHE[1] (C bit) control function
> ● RAMA initialization control
> ● MD[7:0] pin monitoring
> ● LSI version register
> ● General-purpose 32-bit readable/writable registers
> ● Observability counting stop control for ICB
> ● WDT counter stop control
> ● Reading of the temperature sensor reference value
> 


Best regards,
Krzysztof