From: Marek Vasut <marex@denx.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge
Date: Sun, 26 Jul 2020 12:13:12 +0200 [thread overview]
Message-ID: <a3eb3adc-ebfc-50bb-4da9-032a5c7279fe@denx.de> (raw)
In-Reply-To: <20200726070627.GC1691925@ravnborg.org>
On 7/26/20 9:06 AM, Sam Ravnborg wrote:
> Hi Marek.
Hi,
> On Sat, Jul 25, 2020 at 11:14:56PM +0200, Marek Vasut wrote:
>> Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this
>> one is used in the Raspberry Pi 7" touchscreen display unit.
[...]
> This looks like a candidate for the simple-bridge-yaml binding.
> Did you check if this is sufficient or we really need a new binding?
The binding says "Transparent non-programmable DRM bridges", but this
TC358762 one is programmable, so I would expect a separate binding file
is better in case the driver evolves and needs more DT properties.
> If we need a new binding then they to take a look at how simple-bridge
> define the ports. You can do this in a simple way than what is used
> here.
> It looks like this was copied from toshiba,tc358768.yaml, but there are
> better examples to follow.
I took a subset of the file.
[...]
next prev parent reply other threads:[~2020-07-26 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 21:14 [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge Marek Vasut
2020-07-25 21:14 ` [PATCH 2/2] drm/bridge: tc358762: Add basic driver " Marek Vasut
2020-07-26 7:15 ` Sam Ravnborg
2020-07-26 10:17 ` Marek Vasut
2020-07-26 20:41 ` Sam Ravnborg
2020-07-26 7:06 ` [PATCH 1/2] dt-bindings: Add DT bindings " Sam Ravnborg
2020-07-26 10:13 ` Marek Vasut [this message]
2020-07-27 18:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3eb3adc-ebfc-50bb-4da9-032a5c7279fe@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).