From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFCBEB8FA5 for ; Wed, 6 Sep 2023 08:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbjIFIsv (ORCPT ); Wed, 6 Sep 2023 04:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235841AbjIFIsv (ORCPT ); Wed, 6 Sep 2023 04:48:51 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0035C1713 for ; Wed, 6 Sep 2023 01:48:26 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9a58dbd5daeso523496566b.2 for ; Wed, 06 Sep 2023 01:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693990105; x=1694594905; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RrCIcjF1rY1mMD/Gu+r4tbPGrpOuOBfXe5P30B5qf1Q=; b=gjd3AsiRvJZVpqXBjKKj4V23wJK37HZxuiRhYiR7YhEGsOElHNV3fd/X9IVNNr0Ypt bGGZd4fyi7r9EOZiFPl8QHWPSRfCQl1xoD+Y7ecOoY53m1ueuJJb7WRvpR9wotBVL1pc YSS9C3fUQ/9RJUN8tPAhtbMeeVQxyrSAy4a5/dsQjDNf/b7ueu2XwSwLd+M6pFPvjaGZ w3SDLoKbBa04PLbLbgsv2VZRQYkI90jPNrvOaRSUQ1txLmK0bEKDjbMG8zFOKhIh2wv4 ch3lS4s9eUlDVAJxVxipVR5hWxCjwzJSJB9nUcZAPS/GsB824pwZcMkQbJb+Z/Fn6eB9 vTvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693990105; x=1694594905; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RrCIcjF1rY1mMD/Gu+r4tbPGrpOuOBfXe5P30B5qf1Q=; b=Hn1AdNvA5wTM8Vkee4g3oGS10bUDi9vlhSVnLanN7YMmunqRPopeO0vW5TL08u37dx RFPtnMZw4GoIRLXMMfuUFbHtun7QfoHp7y8hw1OMCPFYhtXAZzEwap+Pp0qYmR6RkF42 unFQO5PFXTPC0O/zhqMaHG6rnO6lYE8jjvOIKfdH/BcmH9K6g6w5X0LjFdUOFKmR4CTJ Hi/uXuD6UhoO5ryFfUp15lwoIoLV/AzzQsSQG2cvQgINylH2dGOXR6g1FkSlH2uJmnVt raEWfbUnMQMyyz9jVJotsZaJbAD7GbV4OvW+Q9bn9J25Eo9S71aB1f7vadX9JARCG8m4 d3OA== X-Gm-Message-State: AOJu0YxAu2hsm2vc96sJLUGTZZzQXOKmXfl/hMGDkdGmO0Z+wcq/y7iy qwrTFI4dcdqay5+KomQ6BB2hXQ== X-Google-Smtp-Source: AGHT+IH8UP4xS9z1tEun/6EHP9/nk72OwvNjGqpg0zwCljUObKiMg7WpCrPYbEl9OzalF7MYJfPYtA== X-Received: by 2002:a17:906:cc4e:b0:9a2:292d:ea63 with SMTP id mm14-20020a170906cc4e00b009a2292dea63mr1570271ejb.37.1693990105263; Wed, 06 Sep 2023 01:48:25 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id ov22-20020a170906fc1600b00992c92af6f4sm8841374ejb.144.2023.09.06.01.48.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 01:48:24 -0700 (PDT) Message-ID: Date: Wed, 6 Sep 2023 10:48:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras Content-Language: en-US To: Laurent Pinchart Cc: Paul Elder , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230905233118.183140-1-paul.elder@ideasonboard.com> <20230905233118.183140-4-paul.elder@ideasonboard.com> <502fc7b1-a32d-6901-3a45-d2aa0e0c3849@linaro.org> <20230906083237.GL7971@pendragon.ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: <20230906083237.GL7971@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/09/2023 10:32, Laurent Pinchart wrote: > Hi Krzysztof, > > On Wed, Sep 06, 2023 at 09:27:07AM +0200, Krzysztof Kozlowski wrote: >> On 06/09/2023 01:31, Paul Elder wrote: >>> Add overlays for the Pumpkin i350 to support THP7312 cameras. >>> >>> Signed-off-by: Paul Elder >>> --- >>> arch/arm64/boot/dts/mediatek/Makefile | 4 + >>> .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++ >>> .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++ >>> .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++ >>> 4 files changed, 173 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile >>> index 20570bc40de8..ceaf24105001 100644 >>> --- a/arch/arm64/boot/dts/mediatek/Makefile >>> +++ b/arch/arm64/boot/dts/mediatek/Makefile >>> @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb >>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb >>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb >>> >>> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo >>> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo >>> mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo >>> + >>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> new file mode 100644 >>> index 000000000000..478697552617 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> @@ -0,0 +1,23 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (c) 2023 Ideas on Board >>> + * Author: Paul Elder >>> + */ >>> + >>> +/dts-v1/; >>> +/plugin/; >>> + >>> +&{/} { >>> + vsys_v4p2: regulator@0 { >> >> Hm? Is this a bus? > > There are multiple instances of "numbered" regulators in upstream DT > files, for instance arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_max.dtsi That's the only example I saw... I fixed it now. > has a regulator@0. There are similar instances for clocks. > > I understand why it may not be a good idea, and how the root node is > indeed not a bus. In some cases, those regulators and clocks are grouped > in a regulators or clocks node that has a "simple-bus" compatible. I'm > not sure if that's a good idea, but at least it should validate. > > What's the best practice for discrete board-level clocks and regulators > in overlays ? How do we ensure that their node name will not conflict > with the board to which the overlay is attached ? Top-level nodes (so under /) do not have unit addresses. If they have - it's an error, because it is not a bus. Also, unit address requires reg. No reg? No unit address. DTC reports this as warnings as well. >>> + orientation = <0>; >>> + rotation = <0>; >>> + >>> + thine,rx,data-lanes = <4 1 3 2>; >> >> NAK for this property. > > Please explain why. You commented very briefly in the bindings review, > and it wasn't clear to me if you were happy or not with the property, > and if not, why. Because it is duplicating endpoint. At least from the description. Best regards, Krzysztof