From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FDCC433DB for ; Wed, 6 Jan 2021 08:15:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C81E230FB for ; Wed, 6 Jan 2021 08:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725903AbhAFIPH (ORCPT ); Wed, 6 Jan 2021 03:15:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbhAFIPH (ORCPT ); Wed, 6 Jan 2021 03:15:07 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AD7C06134D for ; Wed, 6 Jan 2021 00:14:26 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id g185so1832032wmf.3 for ; Wed, 06 Jan 2021 00:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=FfV3hyzCprel4c8D5UUPJuvA+3HUguNV7GDsYJABWM4=; b=jiH7vMnyXhGc6f/iiS/rTXx9kzzVUfG/BwTF2CI1kpNGidrfh3UL+Y8rhMAbfplTQ4 1APk09ZE+FGVcGIKzGDKu5arR1tXi0qsinqrT436gD8iuG88GAuf0vOGzqLlcLeU/Hxw iDwYjnzvljeoblw4mZHcHTpcI0/9s46OU0sTNLJUsaYPgg7/d/KYmdqDq5m/0eYfK0KI GhZ+FCbYCn2RkIv+77WG/YWJMpfKTB7pr242B/FC0O0x3CnYdJGfCCT2X/Vgk5q3/Tpu /KQsVccG1r1Bwbpm0qaI9XgqQQb8XJ9bh+/FOCDyEiOBakkQO98ExTN2EWwr8+RrCt+m yPhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FfV3hyzCprel4c8D5UUPJuvA+3HUguNV7GDsYJABWM4=; b=M+X8cOPBKyQRJve2556IVqLzm8TEhPeLpZWhjdl0WGmOglA/npV1IC/Yt9+lmFKFGa mF4PAiGh/vxRV999OUHN1+rW/vdmulYc7YjQXM7+GI+y61gpmSWhIFVOuVZsyo5X6U4D ESOirrZYFklu5ruTra5C89hq0OUx5SoD6QEIpivLQrVMqs9wmkQhnSwo2O5J6cpBzj65 kAL/OPirNtHFG7boeiWp0Qijp7SoJbDxyBbsfjk1dJa/M67XNpAEfa14Jd3QEdHe+Hwp aKFIb0xfSyYBdqmqBR0LvTYy9Cmeb0Xu0vDbpw5BvMf7UL9NtR5AyM1FD9dmgIs31Ftl yfag== X-Gm-Message-State: AOAM5339giXiwOvsDa0A/GCORBJ+8y4+b1A/KUIKQ/3ZoynNUYioPLvX SUp8OlK4jTNnecBq6eKgv71GZh9EX/p0WQ== X-Google-Smtp-Source: ABdhPJzhtFE3/TrLKMfVx2COu7W0DF0IrzoUUUeya0H2MBGgal7PPIfG0DQ/A6JY9EnA7mGroFIOTQ== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr2639409wmj.168.1609920865385; Wed, 06 Jan 2021 00:14:25 -0800 (PST) Received: from [10.44.66.8] ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id j2sm2103092wrh.78.2021.01.06.00.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 00:14:24 -0800 (PST) To: Henry Chen Cc: Rob Herring , Matthias Brugger , Stephen Boyd , Ryan Case , Mark Brown , Mark Rutland , Nicolas Boichat , Fan Chen , James Liao , Arvin Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <1608790134-27425-1-git-send-email-henryc.chen@mediatek.com> <1608790134-27425-9-git-send-email-henryc.chen@mediatek.com> <1609918232.23066.5.camel@mtksdaap41> From: Georgi Djakov Subject: Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver Message-ID: Date: Wed, 6 Jan 2021 10:14:26 +0200 MIME-Version: 1.0 In-Reply-To: <1609918232.23066.5.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1/6/21 09:30, Henry Chen wrote: > On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote: >> On 12/24/20 08:08, Henry Chen wrote: >>> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver >>> using the interconnect framework. >>> >>> ICC provider ICC Nodes >>> ---- ---- >>> --------- |CPU | |--- |VPU | >>> ----- | |----- ---- | ---- >>> |DRAM |--|DRAM | ---- | ---- >>> | |--|scheduler|----- |GPU | |--- |DISP| >>> | |--|(EMI) | ---- | ---- >>> | |--| | ----- | ---- >>> ----- | |----- |MMSYS|--|--- |VDEC| >>> --------- ----- | ---- >>> /|\ | ---- >>> |change DRAM freq |--- |VENC| >>> ---------- | ---- >>> | DVFSR | | >>> | | | ---- >>> ---------- |--- |IMG | >>> | ---- >>> | ---- >>> |--- |CAM | >>> ---- >>> >>> Signed-off-by: Henry Chen >>> --- >>> drivers/interconnect/Kconfig | 1 + >>> drivers/interconnect/Makefile | 1 + >>> drivers/interconnect/mediatek/Kconfig | 13 ++ >>> drivers/interconnect/mediatek/Makefile | 3 + >>> drivers/interconnect/mediatek/mtk-emi.c | 330 ++++++++++++++++++++++++++++++++ >>> 5 files changed, 348 insertions(+) >>> create mode 100644 drivers/interconnect/mediatek/Kconfig >>> create mode 100644 drivers/interconnect/mediatek/Makefile >>> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c >>> >>> diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig >>> index 5b7204e..e939f5a 100644 >>> --- a/drivers/interconnect/Kconfig >>> +++ b/drivers/interconnect/Kconfig >>> @@ -13,5 +13,6 @@ if INTERCONNECT >>> >>> source "drivers/interconnect/imx/Kconfig" >>> source "drivers/interconnect/qcom/Kconfig" >>> +source "drivers/interconnect/mediatek/Kconfig" >> >> Sort alphabetically please. > Ok >> >>> >>> endif >>> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile >>> index d203520..0643a24 100644 >>> --- a/drivers/interconnect/Makefile >>> +++ b/drivers/interconnect/Makefile >>> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o >>> obj-$(CONFIG_INTERCONNECT) += icc-core.o >>> obj-$(CONFIG_INTERCONNECT_IMX) += imx/ >>> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/ >>> +obj-$(CONFIG_INTERCONNECT_MTK) += mediatek/ >> >> Ditto. > Ok >> >>> diff --git a/drivers/interconnect/mediatek/Kconfig b/drivers/interconnect/mediatek/Kconfig >>> new file mode 100644 >>> index 0000000..972d3bb >>> --- /dev/null >>> +++ b/drivers/interconnect/mediatek/Kconfig >>> @@ -0,0 +1,13 @@ >>> +config INTERCONNECT_MTK >>> + bool "Mediatek Network-on-Chip interconnect drivers" >>> + depends on ARCH_MEDIATEK >>> + help >>> + Support for Mediatek's Network-on-Chip interconnect hardware. >>> + >>> +config INTERCONNECT_MTK_EMI >>> + tristate "Mediatek EMI interconnect driver" >>> + depends on INTERCONNECT_MTK >>> + depends on (MTK_DVFSRC && OF) >> >> Would it be possible to enable COMPILE_TEST? > Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ? Yeah, there is a stub for mtk_dvfsrc_send_request(). Maybe we could even change it for INTERCONNECT_MTK to something like: depends on ARCH_MEDIATEK || COMPILE_TEST Will this work? Thanks, Georgi