Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Split HP Omnibook X14 AI in SoC variants

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/07/2025 10:17, Jens Glathe wrote:
> On 7/8/25 09:45, Krzysztof Kozlowski wrote:
>> On Sat, Jul 05, 2025 at 10:31:54PM +0200, Jens Glathe wrote:
>>> The HP Omnibook X14 AI PC is available in fe0 (Hamoa, x1e80100) and
>>> fe1 (Purwa, x1p42100) SKUs. Since they are not completely dtb-compatible,
>>> split the model strings in 2 variants:
>>>
>>> hp,omnibook-x14	compatible to qcom,x1e80100
>>> hp,omnibook-x14-fe1 compatible to cqom,x1p42100
>> I don't see split here. You are adding a new compatible for the fe1
>> variant. It's fine to mention there is fe0 already, but main point of
>> commit msg should express what you want to do and doing here.
> 
> Isn't the effect of creating 2 compatible strings for the same model 
> with different SKUs a split?
But you did not create 2 compatible strings in this patch,

Split means dividing (https://en.wiktionary.org/wiki/split) and nothing
here was divided. Claiming that by adding something you split is like
totally not matching reality.

Like adding 1 to existing 1 in math (1+1) ... so it is a split into 2?

Best regards,
Krzysztof