From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323B0303A22 for ; Tue, 9 Sep 2025 19:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757446612; cv=none; b=Sdiqi6ag7Ey7+yOVvqJa2oL84detkLQYcX3uRlgrm2gBb6+9BQkPSxDdO6SF18v7jb8ubJpQmMR6cvJO5klknvWosP8itVwViUxw1qd+TSMG4A7zTuw0EDORIGwShUMZwNJY6aB9fUYiSjfB2W0GlIL+RxA32I+J/AhjS/LKUEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757446612; c=relaxed/simple; bh=pW3yj6IzHWgOnjOMnUjUMtReo7OZoZL42xmhdCthF+8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MdXUORWuIf+P7vEvhuiIiRhvIT4zp/8J9T+FgZQTAo7Dh0MbXSID2YrL87llbJ5DlLp6Bm7kdzK8n0YrvtC5dKlM+lfwuoHFyCQyUIROzeqcdOlwI2Hi35DushdER0O0JXrNRKgrPi7AwpGxmVwJv9AXP4beqCwLfJnz3/+cGbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=OFfmGFf+; arc=none smtp.client-ip=121.127.44.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="OFfmGFf+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1757446609; bh=rwqoGtXjB1J++h8Zyy8TQBXX6o5DAsVUE4Q8MuslRI0=; b=OFfmGFf+DSTaRnQtHRgyhcVPO+nRMO7nfBbG+pII6Sw0EaIkfgIAKrI0FB01Wbx+LL+bn3C90 7efzAcM30OwFoH2pRh8qzMeYmvdk8go9Qw7jCK2G4DS/NlAYpniiuv5TJRVnsQfo3BFsd3Ow6gN XxxJSm4tn60nbrExecYzl7KL7bdV0WNL7abTXCC3yvZd+x9enZxOY5L+lw4MqdgBfqGx5Vzg+pB YGsZ8KuRN+LHsiMI3fBoOq51WKOlTpBlZiRWuRuD1MG5VyWvJD9XnKaGR+OCuzixHWEQra94HwW h/1B6mMaouwM6ezXF80QN414zHsu7ARVJNJj5BrDWYfg== X-Forward-Email-ID: 68c081cdd4f0dc47f6d79244 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 1.2.14 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: Date: Tue, 9 Sep 2025 21:36:39 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add Radxa E24C To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , FUKAUMI Naoki Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yao Zi , Chukun Pan , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250727144409.327740-1-jonas@kwiboo.se> <7d3c3b29-f89f-4801-8fd7-d6d0645095af@kwiboo.se> <17232684.geO5KgaWL5@diego> Content-Language: en-US From: Jonas Karlman In-Reply-To: <17232684.geO5KgaWL5@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/9/2025 5:39 PM, Heiko Stübner wrote: > Am Dienstag, 9. September 2025, 16:48:25 Mitteleuropäische Sommerzeit schrieb Jonas Karlman: >> On 9/9/2025 2:28 PM, FUKAUMI Naoki wrote: >>> Hi Jonas, >>> >>> On 7/27/25 23:44, Jonas Karlman wrote: >>>> The Radxa E24C is a compact, high-performance network computer >>>> developed by Radxa, based on the Rockchip RK3528A SoC. >>>> >>>> Add initial device tree for the Radxa E24C. >>>> >>>> Signed-off-by: Jonas Karlman >>>> Reviewed-by: Andrew Lunn >>>> --- >>>> Schematics: https://dl.radxa.com/e/e24c/docs/radxa_e24c_v1200_schematic.pdf >>>> --- >>>> arch/arm64/boot/dts/rockchip/Makefile | 1 + >>>> .../boot/dts/rockchip/rk3528-radxa-e24c.dts | 519 ++++++++++++++++++ >>>> 2 files changed, 520 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3528-radxa-e24c.dts >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile >>>> index 0662fcf00628..dc62fd5305be 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>>> @@ -92,6 +92,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-armsom-sige1.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-nanopi-zero2.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-radxa-e20c.dtb >>>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-radxa-e24c.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-rock-2a.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-rock-2f.dtb >>>> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3562-evb2-v10.dtb >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e24c.dts b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e24c.dts >>>> new file mode 100644 >>>> index 000000000000..225f2b0c5339 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e24c.dts >>>> @@ -0,0 +1,519 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> + >>>> +/dts-v1/; >>>> + >>>> +#include >>>> +#include >>>> +#include "rk3528.dtsi" >>>> + >>>> +/ { >>>> + model = "Radxa E24C"; >>>> + compatible = "radxa,e24c", "rockchip,rk3528"; >>>> + >>>> + aliases { >>>> + ethernet0 = &gmac1; >>>> + i2c0 = &i2c0; >>>> + i2c1 = &i2c1; >>>> + i2c5 = &i2c5; >>>> + mmc0 = &sdhci; >>>> + mmc1 = &sdmmc; >>>> + rtc0 = &hym8563; >>>> + rtc1 = &rk805; >>>> + serial0 = &uart0; >>>> + }; >>>> + >>>> + chosen { >>>> + stdout-path = "serial0:1500000n8"; >>>> + }; >>>> + >>>> + adc-keys { >>>> + compatible = "adc-keys"; >>>> + io-channels = <&saradc 0>; >>>> + io-channel-names = "buttons"; >>>> + keyup-threshold-microvolt = <1800000>; >>>> + poll-interval = <100>; >>>> + >>>> + button-maskrom { >>>> + label = "MASKROM"; >>>> + linux,code = ; >>>> + press-threshold-microvolt = <0>; >>>> + }; >>>> + }; >>>> + >>>> + gpio-keys { >>>> + compatible = "gpio-keys"; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = <&gpio0_a0_user>; >>>> + >>>> + button-user { >>>> + gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_LOW>; >>>> + label = "USER"; >>>> + linux,code = ; >>> >>> I prefer to assign BTN_0 to the 1st button :) >> >> The E20C (and other RK boards) already use BTN_1 for user button, it >> only seem to be the recently added E54C that is using BTN_0. >> >> For consistency I suggest we keep using BTN_1 for this user button and >> possible fixup E54C, if you want to use same button for all variants. > > Yep, that would also keep the amount of userspace-facing changes > minimal. I mixed up e54c and e52c so my statement was not fully correct above, however there is a mixed use of BTN_1 and BTN_0 for user button: - rk3588s-nanopi-r6c/r6s uses BTN_1, added in v6.9-rc1 - rk3588-friendlyelec-cm3588-nas uses BTN_1, added in v6.11-rc1 - rk3582-radxa-e52c uses BTN_0, added in v6.14-rc1 - rk3528-radxa-e20c uses BTN_1, added in v6.15-rc1 - rk3576-nanopi-m5 uses BTN_1, added in v6.17-rc1 Majority seem to be using BTN_1 for a user button. Regards, Jonas > > Heiko > > >