From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yixun Lan <dlan@gentoo.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Iker Pedrosa <ikerpedrosam@gmail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mmc: spacemit,sdhci: add reset support
Date: Mon, 22 Dec 2025 09:16:31 +0100 [thread overview]
Message-ID: <a4458673-b219-41c4-90f3-b089a8ef76ba@kernel.org> (raw)
In-Reply-To: <20251222021202-GYA1977180@gentoo.org>
On 22/12/2025 03:12, Yixun Lan wrote:
>>> required:
>>> - compatible
>>> - reg
>>> - interrupts
>>> - clocks
>>> - clock-names
>>> + - resets
>>> + - reset-names
>>
>> This is an ABI break without mentioning in commit msg and without any
>> justification.
>>
> Indeed, this will introduce a breakage when combining new kernel + old dtb
>
> Since in current case, the eMMC works fine without reset line operation,
> I then would make this property optional (drop it from 'required' section)
> and switch to use devm_reset_control_get_optional_xx() API in driver code
>
> Does this looks good to you?
>
Yes
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-22 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 8:20 [PATCH 0/3] mmc: sdhci-of-k1: add reset support Yixun Lan
2025-12-21 8:20 ` [PATCH 1/3] dt-bindings: mmc: spacemit,sdhci: " Yixun Lan
2025-12-21 15:09 ` Krzysztof Kozlowski
2025-12-22 2:12 ` Yixun Lan
2025-12-22 8:16 ` Krzysztof Kozlowski [this message]
2025-12-21 8:20 ` [PATCH 2/3] mmc: sdhci-of-k1: " Yixun Lan
2025-12-21 8:20 ` [PATCH 3/3] riscv: dts: spacemit: sdhci: " Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4458673-b219-41c4-90f3-b089a8ef76ba@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=ikerpedrosam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox