[PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Parth Pancholi]

From: Parth Pancholi <parth.pancholi@toradex.com>

Correct the McASP nodes - mcasp3 and mcasp4 with the right
DMAs thread IDs as per TISCI documentation [1] for J784s4.
This fixes the related McASPs probe failure due to incorrect
DMA IDs.

Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids/ [1]
Fixes: 5095ec4aa1ea ("arm64: dts: ti: k3-j784s4-main: Add McASP nodes")
Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
index f170f80f00c1..d4ac1c9872a5 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
@@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
 		interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "tx", "rx";
-		dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
+		dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
 		dma-names = "tx", "rx";
 		clocks = <&k3_clks 268 0>;
 		clock-names = "fck";
@@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
 		interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "tx", "rx";
-		dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
+		dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
 		dma-names = "tx", "rx";
 		clocks = <&k3_clks 269 0>;
 		clock-names = "fck";
-- 
2.34.1

Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Nishanth Menon]

On 10:50-20240730, Parth Pancholi wrote:
> On Tue, 2024-07-30 at 11:37 +0200, Parth Pancholi wrote:
> This message originated from outside your organization
> 
> From: Parth Pancholi <parth.pancholi@toradex.com>
> 
> Correct the McASP nodes - mcasp3 and mcasp4 with the right
> DMAs thread IDs as per TISCI documentation [1] for J784s4.
> This fixes the related McASPs probe failure due to incorrect
> DMA IDs.
> 
> Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids/<http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids> [1]
> Fixes: 5095ec4aa1ea ("arm64: dts: ti: k3-j784s4-main: Add McASP nodes")
> Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> ---
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index f170f80f00c1..d4ac1c9872a5 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
> interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "tx", "rx";
> - dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
> + dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
> dma-names = "tx", "rx";
> clocks = <&k3_clks 268 0>;
> clock-names = "fck";
> @@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
> interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "tx", "rx";
> - dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
> + dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
> dma-names = "tx", "rx";
> clocks = <&k3_clks 269 0>;
> clock-names = "fck";
> 
I think your patch got corrupted. Could you use git send-email or a
proper client?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Francesco Dolcini]

Hello Nishanth,

On Tue, Jul 30, 2024 at 06:04:44AM -0500, Nishanth Menon wrote:
> On 10:50-20240730, Parth Pancholi wrote:
> > On Tue, 2024-07-30 at 11:37 +0200, Parth Pancholi wrote:
> > This message originated from outside your organization
> > 
> > From: Parth Pancholi <parth.pancholi@toradex.com>
> > 
> > Correct the McASP nodes - mcasp3 and mcasp4 with the right
> > DMAs thread IDs as per TISCI documentation [1] for J784s4.
> > This fixes the related McASPs probe failure due to incorrect
> > DMA IDs.
> > 
> > Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids/<http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids> [1]
> > Fixes: 5095ec4aa1ea ("arm64: dts: ti: k3-j784s4-main: Add McASP nodes")
> > Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> > ---
> > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > index f170f80f00c1..d4ac1c9872a5 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > @@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
> > interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-names = "tx", "rx";
> > - dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
> > + dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
> > dma-names = "tx", "rx";
> > clocks = <&k3_clks 268 0>;
> > clock-names = "fck";
> > @@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
> > interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-names = "tx", "rx";
> > - dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
> > + dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
> > dma-names = "tx", "rx";
> > clocks = <&k3_clks 269 0>;
> > clock-names = "fck";
> > 
> I think your patch got corrupted. Could you use git send-email or a
> proper client?

Are you sure it was not your side to mess-up with it?

I tested and it applies fine to me

$ b4 shazam 20240730093754.1659782-1-parth105105@gmail.com
Grabbing thread from lore.kernel.org/all/20240730093754.1659782-1-parth105105%40gmail.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1
---
Applying: arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Francesco Dolcini]

Hello,

On Tue, Jul 30, 2024 at 11:37:54AM +0200, Parth Pancholi wrote:
> From: Parth Pancholi <parth.pancholi@toradex.com>
> 
> Correct the McASP nodes - mcasp3 and mcasp4 with the right
> DMAs thread IDs as per TISCI documentation [1] for J784s4.
> This fixes the related McASPs probe failure due to incorrect
> DMA IDs.
> 
> Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids/ [1]
> Fixes: 5095ec4aa1ea ("arm64: dts: ti: k3-j784s4-main: Add McASP nodes")
> Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>

+ Jayesh that is the author of the commit fixed here.

Francesco

Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Nishanth Menon]

On 14:01-20240730, Francesco Dolcini wrote:
> Are you sure it was not your side to mess-up with it?
> 
> I tested and it applies fine to me
> 
> $ b4 shazam 20240730093754.1659782-1-parth105105@gmail.com
> Grabbing thread from lore.kernel.org/all/20240730093754.1659782-1-parth105105%40gmail.com/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 2 messages in the thread
> Checking attestation on all messages, may take a moment...

It looks like Parth had CCed Jayesh in response[1] in html email and
that is what I saw in my mailbox. but anyways, no harm done.

Will wait for Jayesh to review.

[1] message-ID
94a0be3616425c7aef7bb0507d60ee11d4776545.camel@toradex.com in https://lore.kernel.org/linux-arm-kernel/20240730110444.fctc2lje62ewg4ob@safari/T/#t

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Jayesh Choudhary]

Hello Parth,

Thank you for the patch.

On 30/07/24 15:07, Parth Pancholi wrote:
> From: Parth Pancholi <parth.pancholi@toradex.com>
> 
> Correct the McASP nodes - mcasp3 and mcasp4 with the right
> DMAs thread IDs as per TISCI documentation [1] for J784s4.
> This fixes the related McASPs probe failure due to incorrect
> DMA IDs.
> 
> Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids/ [1]
> Fixes: 5095ec4aa1ea ("arm64: dts: ti: k3-j784s4-main: Add McASP nodes")
> Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index f170f80f00c1..d4ac1c9872a5 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
>   		interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
>   		interrupt-names = "tx", "rx";
> -		dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
> +		dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
>   		dma-names = "tx", "rx";
>   		clocks = <&k3_clks 268 0>;
>   		clock-names = "fck";
> @@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
>   		interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
>   		interrupt-names = "tx", "rx";
> -		dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
> +		dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
>   		dma-names = "tx", "rx";
>   		clocks = <&k3_clks 269 0>;
>   		clock-names = "fck";
Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>


Warm Regards,
Jayesh

Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

[Nishanth Menon]

Hi Parth Pancholi,

On Tue, 30 Jul 2024 11:37:54 +0200, Parth Pancholi wrote:
> Correct the McASP nodes - mcasp3 and mcasp4 with the right
> DMAs thread IDs as per TISCI documentation [1] for J784s4.
> This fixes the related McASPs probe failure due to incorrect
> DMA IDs.
> 
> 

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs
      commit: 402d336053a5d827c70ec11109e079811e86e0e8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D