From: Neil Armstrong <neil.armstrong@linaro.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>
Cc: Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Konrad Dybcio <konradybcio@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Connor Abbott <cwabbott0@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 02/11] drm/msm: adreno: rename quirks that are features
Date: Mon, 25 Nov 2024 09:14:59 +0100 [thread overview]
Message-ID: <a46b4151-fa44-4ec9-80f1-f3151749c529@linaro.org> (raw)
In-Reply-To: <20241123192551.ederap4nmtjifrdq@hu-akhilpo-hyd.qualcomm.com>
On 23/11/2024 20:25, Akhil P Oommen wrote:
> On Tue, Nov 19, 2024 at 06:56:37PM +0100, Neil Armstrong wrote:
>> Half of the current "Quirks" are in fact features, so rename
>> the defines with FEAT instead of QUIRK.
>>
>> They will be moved in a separate bitfield in a second time.
>>
>> No functional changes.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 62 +++++++++++++++---------------
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +-
>> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 7 ++--
>> 4 files changed, 38 insertions(+), 37 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> index 0c560e84ad5a53bb4e8a49ba4e153ce9cf33f7ae..825c820def315968d508973c8ae40c7c7b646569 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> @@ -743,7 +743,7 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT,
>> .init = a6xx_gpu_init,
>> .zapfw = "a615_zap.mbn",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -769,7 +769,7 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT,
>> .init = a6xx_gpu_init,
>> .a6xx = &(const struct a6xx_info) {
>> .protect = &a630_protect,
>> @@ -839,7 +839,7 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT,
>> .init = a6xx_gpu_init,
>> .zapfw = "a615_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -864,8 +864,8 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .zapfw = "a620_zap.mbn",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -892,7 +892,7 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_1M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT,
>> .init = a6xx_gpu_init,
>> .zapfw = "a630_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -911,7 +911,7 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_1M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT,
>> .init = a6xx_gpu_init,
>> .zapfw = "a640_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -934,8 +934,8 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_1M + SZ_128K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .zapfw = "a650_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -961,8 +961,8 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_1M + SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .zapfw = "a660_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -981,8 +981,8 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_1M + SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .a6xx = &(const struct a6xx_info) {
>> .hwcg = a690_hwcg,
>> @@ -1000,8 +1000,8 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_512K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .zapfw = "a660_zap.mbn",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -1028,7 +1028,7 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_2M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT,
>> .init = a6xx_gpu_init,
>> .zapfw = "a640_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -1046,8 +1046,8 @@ static const struct adreno_info a6xx_gpus[] = {
>> },
>> .gmem = SZ_4M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .zapfw = "a690_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -1331,7 +1331,7 @@ static const struct adreno_info a7xx_gpus[] = {
>> },
>> .gmem = SZ_128K,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_HW_APRIV,
>> + .quirks = ADRENO_FEAT_HAS_HW_APRIV,
>> .init = a6xx_gpu_init,
>> .zapfw = "a702_zap.mbn",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -1355,9 +1355,9 @@ static const struct adreno_info a7xx_gpus[] = {
>> },
>> .gmem = SZ_2M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV |
>> - ADRENO_QUIRK_PREEMPTION,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV |
>> + ADRENO_FEAT_PREEMPTION,
>> .init = a6xx_gpu_init,
>> .zapfw = "a730_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -1377,9 +1377,9 @@ static const struct adreno_info a7xx_gpus[] = {
>> },
>> .gmem = 3 * SZ_1M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV |
>> - ADRENO_QUIRK_PREEMPTION,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV |
>> + ADRENO_FEAT_PREEMPTION,
>> .init = a6xx_gpu_init,
>> .zapfw = "a740_zap.mdt",
>> .a6xx = &(const struct a6xx_info) {
>> @@ -1400,9 +1400,9 @@ static const struct adreno_info a7xx_gpus[] = {
>> },
>> .gmem = 3 * SZ_1M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV |
>> - ADRENO_QUIRK_PREEMPTION,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV |
>> + ADRENO_FEAT_PREEMPTION,
>> .init = a6xx_gpu_init,
>> .a6xx = &(const struct a6xx_info) {
>> .hwcg = a740_hwcg,
>> @@ -1422,9 +1422,9 @@ static const struct adreno_info a7xx_gpus[] = {
>> },
>> .gmem = 3 * SZ_1M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> - .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
>> - ADRENO_QUIRK_HAS_HW_APRIV |
>> - ADRENO_QUIRK_PREEMPTION,
>> + .quirks = ADRENO_FEAT_HAS_CACHED_COHERENT |
>> + ADRENO_FEAT_HAS_HW_APRIV |
>> + ADRENO_FEAT_PREEMPTION,
>> .init = a6xx_gpu_init,
>> .zapfw = "gen70900_zap.mbn",
>> .a6xx = &(const struct a6xx_info) {
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> index 019610341df1506c89f44e86b8d1deeb27d61857..2ebd3fac212576a1507e0b6afe2560cd0408dd89 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> @@ -2478,7 +2478,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
>> adreno_gpu->gmu_is_wrapper = of_device_is_compatible(node, "qcom,adreno-gmu-wrapper");
>>
>> adreno_gpu->base.hw_apriv =
>> - !!(config->info->quirks & ADRENO_QUIRK_HAS_HW_APRIV);
>> + !!(config->info->quirks & ADRENO_FEAT_HAS_HW_APRIV);
>>
>> /* gpu->info only gets assigned in adreno_gpu_init() */
>> is_a7xx = config->info->family == ADRENO_7XX_GEN1 ||
>> @@ -2495,7 +2495,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
>> }
>>
>> if ((enable_preemption == 1) || (enable_preemption == -1 &&
>> - (config->info->quirks & ADRENO_QUIRK_PREEMPTION)))
>> + (config->info->quirks & ADRENO_FEAT_PREEMPTION)))
>> ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs_a7xx, 4);
>> else if (is_a7xx)
>> ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs_a7xx, 1);
>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
>> index 9ffe91920fbfb4841b28aabec9fbde94539fdd83..09d4569f77528c2a20cabc814668c4c930dd07f1 100644
>> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c
>> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
>> @@ -207,7 +207,7 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
>>
>> priv->is_a2xx = info->family < ADRENO_3XX;
>> priv->has_cached_coherent =
>> - !!(info->quirks & ADRENO_QUIRK_HAS_CACHED_COHERENT);
>> + !!(info->quirks & ADRENO_FEAT_HAS_CACHED_COHERENT);
>>
>> gpu = info->init(drm);
>> if (IS_ERR(gpu)) {
>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> index e71f420f8b3a8e6cfc52dd1c4d5a63ef3704a07f..8782c25e8a393ec7d9dc23ad450908d039bd08c5 100644
>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> @@ -54,9 +54,10 @@ enum adreno_family {
>> #define ADRENO_QUIRK_TWO_PASS_USE_WFI BIT(0)
>> #define ADRENO_QUIRK_FAULT_DETECT_MASK BIT(1)
>> #define ADRENO_QUIRK_LMLOADKILL_DISABLE BIT(2)
>> -#define ADRENO_QUIRK_HAS_HW_APRIV BIT(3)
>> -#define ADRENO_QUIRK_HAS_CACHED_COHERENT BIT(4)
>> -#define ADRENO_QUIRK_PREEMPTION BIT(5)
>> +
>
> IMO, we should not keep features separate. In future, we should just append the next
> quirk/feature at the bottom without disturbing the existing bit
> mappings. Just to ensure we don't accidentally duplicate a bit number.
>
> I agree on using 'ADRENO_FEAT' to distinguish features.
Ack, this is the conclusion on patch 3, I'll drop the next one and not
separate the flags.
Neil
>
> -Akhil
>
>> +#define ADRENO_FEAT_HAS_HW_APRIV BIT(3)
>> +#define ADRENO_FEAT_HAS_CACHED_COHERENT BIT(4)
>> +#define ADRENO_FEAT_PREEMPTION BIT(5)
>>
>> /* Helper for formating the chip_id in the way that userspace tools like
>> * crashdec expect.
>>
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2024-11-25 8:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 17:56 [PATCH v2 00/11] drm/msm: adreno: add support for DDR bandwidth scaling via GMU Neil Armstrong
2024-11-19 17:56 ` [PATCH v2 01/11] opp: core: implement dev_pm_opp_get_bw Neil Armstrong
2024-11-25 5:18 ` Viresh Kumar
2024-11-19 17:56 ` [PATCH v2 02/11] drm/msm: adreno: rename quirks that are features Neil Armstrong
2024-11-23 19:25 ` Akhil P Oommen
2024-11-25 8:14 ` Neil Armstrong [this message]
2024-11-19 17:56 ` [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable Neil Armstrong
2024-11-20 11:18 ` Dmitry Baryshkov
2024-11-20 18:54 ` Rob Clark
2024-11-21 18:44 ` Dmitry Baryshkov
2024-11-21 19:48 ` Rob Clark
2024-11-21 22:26 ` Dmitry Baryshkov
2024-11-19 17:56 ` [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag Neil Armstrong
2024-11-20 11:19 ` Dmitry Baryshkov
2024-11-20 12:37 ` Neil Armstrong
2024-11-21 18:44 ` Dmitry Baryshkov
2024-11-21 19:50 ` Rob Clark
2024-11-21 19:53 ` Rob Clark
2024-11-23 19:43 ` Akhil P Oommen
2024-11-25 8:16 ` Neil Armstrong
2024-11-27 16:00 ` Akhil P Oommen
2024-11-27 19:01 ` neil.armstrong
2024-11-19 17:56 ` [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU Neil Armstrong
2024-11-20 11:42 ` Dmitry Baryshkov
2024-11-20 12:37 ` Neil Armstrong
2024-11-21 18:45 ` Dmitry Baryshkov
2024-11-23 21:22 ` Akhil P Oommen
2024-11-23 22:46 ` Akhil P Oommen
2024-11-25 8:12 ` Neil Armstrong
2024-11-27 15:29 ` Akhil P Oommen
2024-11-27 15:47 ` neil.armstrong
2024-11-30 20:36 ` Akhil P Oommen
2024-12-11 8:23 ` neil.armstrong
2024-11-19 17:56 ` [PATCH v2 06/11] drm/msm: adreno: dynamically generate GMU bw table Neil Armstrong
2024-11-19 17:56 ` [PATCH v2 07/11] drm/msm: adreno: find bandwidth index of OPP and set it along freq index Neil Armstrong
2024-11-20 11:44 ` Dmitry Baryshkov
2024-11-19 17:56 ` [PATCH v2 08/11] drm/msm: adreno: request for maximum bus bandwidth usage Neil Armstrong
2024-11-23 22:59 ` Akhil P Oommen
2024-11-25 8:14 ` Neil Armstrong
2024-11-27 15:46 ` Akhil P Oommen
2024-11-27 15:55 ` neil.armstrong
2024-11-19 17:56 ` [PATCH v2 09/11] drm/msm: adreno: enable GMU bandwidth for A740 and A750 Neil Armstrong
2024-11-20 11:45 ` Dmitry Baryshkov
2024-11-19 17:56 ` [PATCH v2 10/11] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU Neil Armstrong
2024-11-20 11:47 ` Dmitry Baryshkov
2024-11-20 12:38 ` Neil Armstrong
2024-11-19 17:56 ` [PATCH v2 11/11] arm64: qcom: dts: sm8650: " Neil Armstrong
2024-11-20 11:47 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46b4151-fa44-4ec9-80f1-f3151749c529@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cwabbott0@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=nm@ti.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=rafael@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox