From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3559FC433EF for ; Tue, 19 Apr 2022 07:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231706AbiDSHif (ORCPT ); Tue, 19 Apr 2022 03:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349450AbiDSHie (ORCPT ); Tue, 19 Apr 2022 03:38:34 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8FC822BFA for ; Tue, 19 Apr 2022 00:35:51 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id b15so20123940edn.4 for ; Tue, 19 Apr 2022 00:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=a+QTYrwAFOSdj+HO0jDyyYz3Rq8uobWXCZRRDSs0HW8=; b=Za/gh2JeihC5CqQTT7cfAfTRJLbYQzGR+qhKQ+h2yZoW32Cr8SBXVL5Ft34bVVGZRM EcFdtqW+RdAlu9sNt3WUv3wQ/TBlNgwa6Rjpf78+mTjnPeW0GWLor/xqWawikKKzQZGJ QZs8gPFIsXZR7ZKpTnMb4ihTwRW0AjjDKQooWgKo+u9L4/dksyhEE5Plm+Karl0V3rLO XLu6nMZ2Ge3vnkMPjIPciX6SIt4IcRUKHH1Z2Fh+oaL1T+VaDmUuHi4krnrPTQ9QKU+f Fuk+Ghfkljvng2dcWUDcBP3I7fJBohARiowY91PhSMLHmmD5G1btTZ4cXkW95UrDQzjK LR3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=a+QTYrwAFOSdj+HO0jDyyYz3Rq8uobWXCZRRDSs0HW8=; b=BNsp7OCxMY2vxJBIrZHZ3alF2Mds72Nvlagdz4jVi/CwAlMFUyS3YkRn7ZP2hqo/iN cmj7OH5pnOSwjW3F5uJmg/s7LvZSIODuQ0PosS8551LIwqZcFTu4vpyYUtqP20b6Q4nz GXy6+4hEU06JyrE9LIuXFXQgJIQZVnGxtANaYYuPJj1cXsk74LK8qihrc5DXy1HiiwVG UlSMLnJdo5mE4l5dIJU8bFUWrmyc12dz4Mdhz3rAj698K/PSKfuEePDYXrB2ZzIoBJSt 5s05tSZEuWezR9vYl33UGEqOGa2e3NDDXiwU/HupMYJ/SAZSDjkf0aFB6ZtKAGXPpfwC HGwA== X-Gm-Message-State: AOAM530ZZKpmT5HBQDdbB9UXeA5eZ3HwnkYpz+gQekMRAgpeKM6qBV1c Q78dDaDM9YENW/vq2jNJ6HHQRA== X-Google-Smtp-Source: ABdhPJxir5QFAKY03Mb+fblB+AU8kLc/73Tnx51jWfCk7swCwIZVx4UZiEvNrwg0RZiVRBKLAWuceA== X-Received: by 2002:a05:6402:5186:b0:423:e004:ef1c with SMTP id q6-20020a056402518600b00423e004ef1cmr10618599edd.349.1650353750242; Tue, 19 Apr 2022 00:35:50 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id v26-20020aa7d65a000000b00424064b8ed2sm31911edr.33.2022.04.19.00.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 00:35:49 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 09:35:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1 3/4] arm64: dts: Add aqp8039-t2 board Content-Language: en-US To: Bryan O'Donoghue , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: shawn.guo@linaro.org, jun.nie@linaro.org, benl@squareup.com, jwillcox@squareup.com, jgates@squareup.com, mchen@squareup.com, zac@squareup.com, Leo Yan References: <20220419010903.3109514-1-bryan.odonoghue@linaro.org> <20220419010903.3109514-4-bryan.odonoghue@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220419010903.3109514-4-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2022 03:09, Bryan O'Donoghue wrote: > The apq8039-t2 is an apq8039/msm8939 based board paired with a wcn3680b > WiFi chipset. > > Co-developed-by: Shawn Guo > Signed-off-by: Shawn Guo > Co-developed-by: Jun Nie > Signed-off-by: Jun Nie > Co-developed-by: Benjamin Li > Signed-off-by: Benjamin Li > Co-developed-by: James Willcox > Signed-off-by: James Willcox > Co-developed-by: Leo Yan > Signed-off-by: Leo Yan > Co-developed-by: Joseph Gates > Signed-off-by: Joseph Gates > Co-developed-by: Max Chen > Signed-off-by: Max Chen > Co-developed-by: Zac Crosby > Signed-off-by: Zac Crosby > Signed-off-by: Bryan O'Donoghue > --- (...) > + pinctrl_panel: panel { > + pinmux { > + pins = "gpio25"; > + function = "gpio"; > + }; > + }; > + > + msmgpio_spe_reg: msmgpio_spe_reg { Same comments as for your patch 2. > + pinmux { > + pins = "gpio108"; > + function = "gpio"; > + output-high; > + }; > + }; (...) > + lcd_iovcc_vreg: lcd-iovcc-vreg { Generic node names, so if you need some specific prefix, at least follow it with "regulator", so "lcd-iovcc-regulator" > + compatible = "regulator-fixed"; > + regulator-name = "lcd_iovcc"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcd_iovcc>; > + gpios = <&msmgpio 9 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <300>; > + enable-active-high; > + }; > + > + lcd_avdd_vreg: lcd-avdd-vreg { > + compatible = "regulator-fixed"; > + regulator-name = "lcd_avdd"; > + regulator-min-microvolt = <5600000>; > + regulator-max-microvolt = <5600000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcd_avdd>; > + gpios = <&msmgpio 86 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <300>; > + enable-active-high; > + }; > + > + lcd_avee_vreg: lcd-avee-vreg { > + compatible = "regulator-fixed"; > + regulator-name = "lcd_avee"; > + regulator-min-microvolt = <5600000>; > + regulator-max-microvolt = <5600000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcd_avee>; > + gpios = <&msmgpio 87 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <300>; > + enable-active-high; > + }; > + > + bl: backlight { > + compatible = "gpio-backlight"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight>; > + gpios = <&msmgpio 98 GPIO_ACTIVE_HIGH>; > + }; > + > + pp_spe_3v3_vreg: pp_spe_3v3_vreg { Please apply all comments from patch 2. Best regards, Krzysztof